[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

xicm commented on code in PR #6986: URL: https://github.com/apache/hudi/pull/6986#discussion_r1007788563 ## hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java: ## @@ -874,21 +887,30 @@ private static Object rewritePrimaryTypeWithDiffSchemaType(Object oldValue,

[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

xicm commented on code in PR #6986: URL: https://github.com/apache/hudi/pull/6986#discussion_r1007788563 ## hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java: ## @@ -874,21 +887,30 @@ private static Object rewritePrimaryTypeWithDiffSchemaType(Object oldValue,

[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

xicm commented on code in PR #6986: URL: https://github.com/apache/hudi/pull/6986#discussion_r1007788563 ## hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java: ## @@ -874,21 +887,30 @@ private static Object rewritePrimaryTypeWithDiffSchemaType(Object oldValue,

[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

xicm commented on code in PR #6986: URL: https://github.com/apache/hudi/pull/6986#discussion_r1000314284 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/TestCDCDataFrameSuite.scala: ## @@ -593,8 +593,8 @@ class TestCDCDataFrameSuite extends Hood