[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2023-01-16 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1071511854 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java: ## @@ -283,44 +270,14 @@ public void preWrite(String instantTime, Writ

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2023-01-05 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1062647677 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java: ## @@ -188,7 +188,6 @@ public static HoodieTableMetaClient initTableIfNotExists(

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2023-01-03 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1060687626 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieClient.java: ## @@ -85,6 +91,8 @@ protected BaseHoodieClient(HoodieEngineContext context,

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2022-12-28 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1058485652 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java: ## @@ -277,7 +277,7 @@ protected void writeTableMetadata(HoodieTable ta

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2022-12-28 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1058485340 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java: ## @@ -277,7 +277,7 @@ protected void writeTableMetadata(HoodieTable ta

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2022-12-28 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1058482453 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java: ## @@ -277,7 +277,7 @@ protected void writeTableMetadata(HoodieTable ta

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2022-12-28 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1058454424 ## hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [hudi] xushiyan commented on a diff in pull request #6732: [HUDI-4148] Add client for hudi table service manager

2022-12-27 Thread GitBox
xushiyan commented on code in PR #6732: URL: https://github.com/apache/hudi/pull/6732#discussion_r1057816433 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java: ## @@ -188,6 +188,7 @@ public static HoodieTableMetaClient initTableIfNotExists(