[GitHub] [hudi] yanghua commented on a change in pull request #2122: [HUDI-1274] Make hive synchronization supports hourly partition

2020-10-28 Thread GitBox
yanghua commented on a change in pull request #2122: URL: https://github.com/apache/hudi/pull/2122#discussion_r513320519 ## File path: hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestPartitionValueExtractor.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the

[GitHub] [hudi] yanghua commented on a change in pull request #2122: [HUDI-1274] Make hive synchronization supports hourly partition

2020-10-26 Thread GitBox
yanghua commented on a change in pull request #2122: URL: https://github.com/apache/hudi/pull/2122#discussion_r512375913 ## File path: hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/PartitionValueExtractorTest.java ## @@ -0,0 +1,17 @@ +package

[GitHub] [hudi] yanghua commented on a change in pull request #2122: [HUDI-1274] Make hive synchronization supports hourly partition

2020-09-29 Thread GitBox
yanghua commented on a change in pull request #2122: URL: https://github.com/apache/hudi/pull/2122#discussion_r496439235 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedDayPartitionValueExtractor.java ## @@ -36,30 +36,35 @@ private