[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-03 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r569905107 ## File path: hudi-flink/src/test/java/org/apache/hudi/operator/StreamWriteFunctionTest.java ## @@ -58,22 +59,24 @@ private static final Map EXPECTED =

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-03 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r569872885 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/BaseFlinkCommitActionExecutor.java ## @@ -91,104 +92,44 @@ pub

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-03 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r569539307 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/BaseFlinkCommitActionExecutor.java ## @@ -91,104 +92,44 @@ pub

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-03 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r569535044 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ## @@ -249,7 +250,17 @@ public String getLastCo

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-02 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r568370892 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ## @@ -249,7 +250,17 @@ public String getLastCo

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-02 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r568409884 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ## @@ -249,7 +250,17 @@ public String getLastCo

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-01 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r568370892 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ## @@ -249,7 +250,17 @@ public String getLastCo

[GitHub] [hudi] yanghua commented on a change in pull request #2506: [HUDI-1557] Make Flink write pipeline write task scalable

2021-02-01 Thread GitBox
yanghua commented on a change in pull request #2506: URL: https://github.com/apache/hudi/pull/2506#discussion_r567513264 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java ## @@ -26,9 +26,9 @@ */ public class Ins