[GitHub] [hudi] yanghua commented on pull request #3674: [HUDI-2440] Add dependency change diff script for dependency governace

2021-09-30 Thread GitBox
yanghua commented on pull request #3674: URL: https://github.com/apache/hudi/pull/3674#issuecomment-930860695 @xushiyan I have addresses some suggestions. Any new inputs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] yanghua commented on pull request #3674: [HUDI-2440] Add dependency change diff script for dependency governace

2021-09-26 Thread GitBox
yanghua commented on pull request #3674: URL: https://github.com/apache/hudi/pull/3674#issuecomment-927459881 @xushiyan Thanks for sharing your thoughts. Let's discuss some points. > i see the point here is to allow PR reviewer easily identify dep changes. Yes, that's one of

[GitHub] [hudi] yanghua commented on pull request #3674: [HUDI-2440] Add dependency change diff script for dependency governace

2021-09-23 Thread GitBox
yanghua commented on pull request #3674: URL: https://github.com/apache/hudi/pull/3674#issuecomment-925613960 I received many reports about dependency conflict around hudi, e.g. [here](https://github.com/apache/incubator-kyuubi/pull/994) and Chinese WeChat group. Considering Hudi depends