yihua commented on code in PR #6467:
URL: https://github.com/apache/hudi/pull/6467#discussion_r952040628
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -327,9 +327,9 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> IGNORE_FAILED = ConfigOptions
.key("write.ignore.failed")
.booleanType()
- .defaultValue(true)
+ .defaultValue(false)
.withDescription("Flag to indicate whether to ignore any non exception
error (e.g. writestatus error). within a checkpoint batch.\n"
- + "By default true (in favor of streaming progressing over data
integrity)");
+ + "By default false (in favor of streaming progressing over data
integrity)");
Review Comment:
Docs need to be updated. The statement `in favor of streaming progressing
over data integrity` is no longer valid for `false`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -96,7 +96,7 @@ private FlinkOptions() {
public static final String NO_PRE_COMBINE = "no_precombine";
public static final ConfigOption<String> PRECOMBINE_FIELD = ConfigOptions
- .key("payload.ordering.field")
+ .key("precombine.field")
Review Comment:
Is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
