zhedoubushishi opened a new pull request #2833:
URL: https://github.com/apache/hudi/pull/2833


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   This is just a immature demo for discussion.
   
   Similar to flink 
[ConfigOption](https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java),
 and based on the changes in this 
[pr](https://github.com/apache/hudi/pull/1094/files), I wrote a demo for using 
configOption for HoodieBootstrapConfig. 
   
   The advantage of pr is that it binds property key, property defaultValue, 
property description, property deprecated names together which is 
straightforward for developers to use. And for the next step, we could also do 
something similar to Flink to automatically add/update property description on 
the website: 
https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/description/Description.java.
 Also this is extensible, we can bind more features if needed.
   
   The disadvantage is for users who are now using e.g. 
```HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP``` in their client code, they 
need to either replace it with 
```HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP``` or 
```hoodie.bootstrap.base.path```.
   
   ## Brief change log
   
   - Add configOption & refactor HoodieBootstrapConfig
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   
   ## Committer checklist
   
    - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [x] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to