Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
wombatu-kun commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2028558096 > @wombatu-kun Thanks for the contribution! Are you interested in more code restructuring and core abstraction work? Feel free to reach out to me on Hudi Slack. @yihua Yes, i'm

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
yihua merged PR #10866: URL: https://github.com/apache/hudi/pull/10866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
yihua commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2028548116 @wombatu-kun Thanks for the contribution! Are you interested in more code restructuring and core abstraction work? Feel free to reach out to me on Hudi Slack. -- This is an automated

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2028045511 ## CI report: * c5f68a42d67d749e8b8218d937d808901ffefcb6 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2028025772 ## CI report: * cc2ead88aba164d6cb0971d8a77fc668acc355b8 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2028023649 ## CI report: * cc2ead88aba164d6cb0971d8a77fc668acc355b8 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-30 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1545284823 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java: ## @@ -21,29 +21,36 @@ import

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-29 Thread via GitHub
yihua commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1545129986 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java: ## @@ -21,29 +21,36 @@ import org.apache.hudi.common.config.ConfigProperty;

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-29 Thread via GitHub
yihua commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1545123027 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java: ## @@ -21,29 +21,36 @@ import org.apache.hudi.common.config.ConfigProperty;

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-29 Thread via GitHub
wombatu-kun commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2027189611 @yihua I made fixes by all your comments. Review please and merge if everything is ok. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-23 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2016496479 ## CI report: * cc2ead88aba164d6cb0971d8a77fc668acc355b8 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-23 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2016480860 ## CI report: * 497a8c65ded43253b375c7504779357ef02bf560 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-23 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2016478967 ## CI report: * 497a8c65ded43253b375c7504779357ef02bf560 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-20 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2009415118 ## CI report: * 497a8c65ded43253b375c7504779357ef02bf560 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-20 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2009203434 ## CI report: * 113f4e5717cdf97aed4f91cecd965c4cec02dec0 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-20 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2009215967 ## CI report: * 113f4e5717cdf97aed4f91cecd965c4cec02dec0 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-19 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529606423 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java: ## @@ -2418,15 +2418,15 @@ public void testSqlSourceSource()

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005765864 ## CI report: * 113f4e5717cdf97aed4f91cecd965c4cec02dec0 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005722576 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005717768 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
wombatu-kun commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005715865 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005678158 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-2005673058 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529616940 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamerTestBase.java: ## @@ -266,9 +266,9 @@ public void setupTest() {

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529616434 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java: ## @@ -27,22 +27,22 @@ public class SourceTestConfig { public static

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529606592 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJdbcSource.java: ## @@ -73,12 +73,12 @@ public static void beforeAll() throws Exception {

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
wombatu-kun commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529606423 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java: ## @@ -2418,15 +2418,15 @@ public void testSqlSourceSource()

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
yihua commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529100966 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java: ## @@ -2418,15 +2418,15 @@ public void testSqlSourceSource() throws

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-18 Thread via GitHub
yihua commented on code in PR #10866: URL: https://github.com/apache/hudi/pull/10866#discussion_r1529083756 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java: ## @@ -27,22 +27,22 @@ public class SourceTestConfig { public static final

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-1997375554 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-1997167795 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 Azure:

Re: [PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10866: URL: https://github.com/apache/hudi/pull/10866#issuecomment-1997155096 ## CI report: * 538d59f11cfca29af8550391f0ce7a491279c0a9 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

[PR] [HUDI-7187] Fix integ test props to honor new streamer properties [hudi]

2024-03-14 Thread via GitHub
wombatu-kun opened a new pull request, #10866: URL: https://github.com/apache/hudi/pull/10866 ### Change Logs As of now, all integ tests properties file are holding deltastreamer props. I've changed them to streamer props. ### Impact none ### Risk level (write