Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-12 Thread via GitHub
jonvex commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1562940754 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def trans

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-12 Thread via GitHub
yihua commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1562929292 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def transl

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
hudi-bot commented on PR #10998: URL: https://github.com/apache/hudi/pull/10998#issuecomment-2050666813 ## CI report: * e7e51394cc39b914503b7e1e3608cdb3ff690a30 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
jonvex commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1561821789 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def trans

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
yihua commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1561742623 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def transl

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
yihua commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1561716214 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def transl

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
hudi-bot commented on PR #10998: URL: https://github.com/apache/hudi/pull/10998#issuecomment-2050520984 ## CI report: * ea501ae87f61ff965f558360bb703bfad595c2a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
hudi-bot commented on PR #10998: URL: https://github.com/apache/hudi/pull/10998#issuecomment-2050508252 ## CI report: * ea501ae87f61ff965f558360bb703bfad595c2a0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
nsivabalan commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1561644552 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def t

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
hudi-bot commented on PR #10998: URL: https://github.com/apache/hudi/pull/10998#issuecomment-2050413788 ## CI report: * ea501ae87f61ff965f558360bb703bfad595c2a0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
hudi-bot commented on PR #10998: URL: https://github.com/apache/hudi/pull/10998#issuecomment-2050403305 ## CI report: * ea501ae87f61ff965f558360bb703bfad595c2a0 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

[PR] [HUDI-7604] Make table name config work properly [hudi]

2024-04-11 Thread via GitHub
jonvex opened a new pull request, #10998: URL: https://github.com/apache/hudi/pull/10998 ### Change Logs DataSourceWriteOptions.TABLE_NAME() should function like "hoodie.table.name" ### Impact Fixes annoyance ### Risk level (write none, low medium or high below)