stream2000 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1956177100
> A runtime error will be introduced here. Passing
com.codahale.metrics.Meter as a parameter to flink code will cause a
NoSuchMethodError, unless the flink code is also shaded, but the bu
zhuanshenbsj1 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1926124497
A runtime error will be introduced here. Passing com.codahale.metrics.Meter
as a parameter to flink code will cause a NoSuchMethodError, unless the flink
code is also shaded, but the b
danny0405 merged PR #9118:
URL: https://github.com/apache/hudi/pull/9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache
stream2000 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1361435492
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/BulkInsertWriterHelper.java:
##
@@ -69,14 +71,21 @@ public class BulkInsertWriterHelper {
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1764497532
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 6ee9b9fcbbf2ed709f2a5c12829ce43dee92f0e2 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1764204966
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8738f767895a396e88c163a8d785d5e92277fad8 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1764190201
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8738f767895a396e88c163a8d785d5e92277fad8 Azure:
[SUCCES
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1360403842
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/BulkInsertWriterHelper.java:
##
@@ -69,14 +71,21 @@ public class BulkInsertWriterHelper {
stream2000 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1763604724
@danny0405 Hi Danny, could we merge this PR since the test failures are just
unstable case? Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the messa
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761999841
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8738f767895a396e88c163a8d785d5e92277fad8 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761619670
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 68bf4bccc6fcac8c2f96e4223bab206992af314b Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761552441
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 68bf4bccc6fcac8c2f96e4223bab206992af314b Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761205902
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 68bf4bccc6fcac8c2f96e4223bab206992af314b Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761146764
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* c930542593c9ff008a3d5cee08be617fc7fbfcb0 Azure:
[SUCCES
stream2000 closed pull request #9118: [HUDI-2141] Support flink stream write
metrics
URL: https://github.com/apache/hudi/pull/9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1761044227
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* c930542593c9ff008a3d5cee08be617fc7fbfcb0 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1760681513
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 4b4d15361b3096e27cc3c54c3347c2cf9224c895 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1760676179
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 4b4d15361b3096e27cc3c54c3347c2cf9224c895 Azure:
[SUCCES
stream2000 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1357668260
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkStreamWriteMetrics.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Fou
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1357583122
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkStreamWriteMetrics.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foun
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759430102
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 4b4d15361b3096e27cc3c54c3347c2cf9224c895 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759269289
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 4b4d15361b3096e27cc3c54c3347c2cf9224c895 Azure:
[PENDIN
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759253106
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 4b4d15361b3096e27cc3c54c3347c2cf9224c895 UNKNOWN
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759172124
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
Bot commands
@hudi-bot supports the following
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759157812
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
Bot commands
@hudi-bot supports the following
danny0405 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1759104229
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1758820147
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
Bot commands
@hudi-bot supports the following
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1758813978
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* ee3bbd6595f8a69ecaf53d9ac2b445533958832c Azure:
[FAILUR
stream2000 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1758786265
@danny0405 Hi Danny, I have addressed all comments, PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
stream2000 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1758785514
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757979131
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* ee3bbd6595f8a69ecaf53d9ac2b445533958832c Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757957453
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* ee3bbd6595f8a69ecaf53d9ac2b445533958832c Azure:
[FAILUR
stream2000 commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757863389
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757850550
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* ee3bbd6595f8a69ecaf53d9ac2b445533958832c Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757505901
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8d732e29104fbde138b6ab3fe6df8fb63e10ab07 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757486587
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8d732e29104fbde138b6ab3fe6df8fb63e10ab07 Azure:
[SUCCES
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757344904
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* 8d732e29104fbde138b6ab3fe6df8fb63e10ab07 Azure:
[SUCCES
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1354583732
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##
@@ -488,11 +505,24 @@ private void flushRemaining(boolean endInput) {
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1354581902
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunction.java:
##
@@ -155,5 +168,15 @@ private void flushData(boolean endInput)
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757038861
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* a9b387e611bdc9c492a27c6adffe2bf74662be96 Azure:
[FAILUR
hudi-bot commented on PR #9118:
URL: https://github.com/apache/hudi/pull/9118#issuecomment-1757025319
## CI report:
* f6d7dd97c73898206da91b17144326a7dbbffae8 UNKNOWN
* c62db1fdf94ee2c1f9b9e539f7a4b1bb866beb7e UNKNOWN
* a9b387e611bdc9c492a27c6adffe2bf74662be96 Azure:
[FAILUR
stream2000 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1354278561
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##
@@ -385,16 +393,24 @@ private String getBucketID(HoodieRecord record
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1353905841
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##
@@ -385,16 +393,24 @@ private String getBucketID(HoodieRecord record)
danny0405 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1353905559
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##
@@ -488,11 +505,24 @@ private void flushRemaining(boolean endInput) {
44 matches
Mail list logo