[GitHub] zheng-da commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously

2018-03-23 Thread GitBox
zheng-da commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375851756 Yes, it's out of the scope of this PR. NNVM is the right place for graph optimization. I'm just curious what k

[GitHub] asitstands opened a new issue #10235: Build fails with USE_CUDNN = 0

2018-03-23 Thread GitBox
asitstands opened a new issue #10235: Build fails with USE_CUDNN = 0 URL: https://github.com/apache/incubator-mxnet/issues/10235 @zheng-da I got the following errors during the build with `USE_CUDNN = 0`. It looks like introduced with #10116. ``` src/operator/nn/batch_norm.cu(71

[GitHub] TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously

2018-03-23 Thread GitBox
TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375851062 @zheng-da Thanks for the explaination and the great effort for this issue. I agree that end users have no need to

[GitHub] rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900514 ## File path: src/kvstore/kvstore_dist.h ## @@ -228,17 +228,18 @@ class KVStoreDist :

[GitHub] rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900514 ## File path: src/kvstore/kvstore_dist.h ## @@ -228,17 +228,18 @@ class KVStoreDist :

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176899908 ## File path: src/kvstore/kvstore_dist.h ## @@ -228,17 +228,18 @@ class KVStor

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900453 ## File path: tests/nightly/dist_sync_kvstore.py ## @@ -278,39 +316,49 @@ def

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900420 ## File path: src/kvstore/kvstore_dist.h ## @@ -506,41 +514,46 @@ class KVStor

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900404 ## File path: src/kvstore/kvstore_dist.h ## @@ -228,17 +228,18 @@ class KVStor

[GitHub] rahul003 commented on issue #10232: [MXNET-136] [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI

2018-03-23 Thread GitBox
rahul003 commented on issue #10232: [MXNET-136] [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-375847064 @cjolivier01 The build with CMake and USE_DIST_KVSTORE fails with an error I had shown you earlier. Th

[GitHub] rahul003 commented on issue #10232: [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI

2018-03-23 Thread GitBox
rahul003 commented on issue #10232: [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-375847064 @cjolivier01 The build with CMake and USE_DIST_KVSTORE fails with an error I had shown you earlier. This is appare

[GitHub] zheng-da commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn

2018-03-23 Thread GitBox
zheng-da commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn URL: https://github.com/apache/incubator-mxnet/pull/10021#issuecomment-375846575 @ashokei @pengzhao-intel do you know when the Intel MKLDNN team will fix the bug in MKLDNN?

[GitHub] rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-374869941 Removed the setting of profiler state to not running in destructor. The server process has its

[incubator-mxnet] branch master updated: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample (#10229)

2018-03-23 Thread nswamy
This is an automated email from the ASF dual-hosted git repository. nswamy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 4950f66 [MXNET-116] Inference - Object

[GitHub] nswamy closed pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy closed pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] eric-haibin-lin commented on issue #10231: [MXNET-16] move dmlc-core & nnvm

2018-03-23 Thread GitBox
eric-haibin-lin commented on issue #10231: [MXNET-16] move dmlc-core & nnvm URL: https://github.com/apache/incubator-mxnet/pull/10231#issuecomment-375846221 @mbaijal could you review license changes? I noticed that two files under src/nnvm didn't have the apache header

[incubator-mxnet] branch nlp_toolkit updated: fix stale grad, rename base s2s class (#17)

2018-03-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch nlp_toolkit in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/nlp_toolkit by this push: new 6875333 fix stale grad, re

[GitHub] iblis17 commented on issue #10149: WIP: import Julia binding

2018-03-23 Thread GitBox
iblis17 commented on issue #10149: WIP: import Julia binding URL: https://github.com/apache/incubator-mxnet/pull/10149#issuecomment-375845762 I added a doc job (1ba9c57), but still no idea how to push outputs from Jenkins. Th

[GitHub] solin319 opened a new pull request #10234: [MXNET-135] mx.image.imread support s3

2018-03-23 Thread GitBox
solin319 opened a new pull request #10234: [MXNET-135] mx.image.imread support s3 URL: https://github.com/apache/incubator-mxnet/pull/10234 In current mxnet version, mx.image.imread can only read file in local file system. We used dmlc::Stream to read date, it can read file from many ot

[GitHub] iblis17 commented on a change in pull request #10149: WIP: import Julia binding

2018-03-23 Thread GitBox
iblis17 commented on a change in pull request #10149: WIP: import Julia binding URL: https://github.com/apache/incubator-mxnet/pull/10149#discussion_r176899040 ## File path: julia/deps/cblas.h ## @@ -0,0 +1,544 @@ +#ifndef CBLAS_H Review comment: For the Julia built f

[GitHub] zheng-da commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously

2018-03-23 Thread GitBox
zheng-da commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375844272 @TaoLv It's difficult. We discussed this before. Who should add this "reorder" operator? Model developer? It w

[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-23 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375844097 @szha New tutorial here: http://mxnet-ci-doc.s3-accelerate.dualstack.amaz

[GitHub] sxjscience commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-23 Thread GitBox
sxjscience commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-375842813 In the python side, we can call functions in two ways. 1)Using kwargs, i.e mx.nd.Pooling(data, kernel=kernel, p

[GitHub] rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-375835736 @piiswrong and @cjolivier01 I've implemented a new interface now. Merged with the existing inte

[GitHub] CoinCheung commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-23 Thread GitBox
CoinCheung commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-375840984 We merely changed the order in the function body rather than the function declarations, and it did pass the te

[GitHub] lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none()

2018-03-23 Thread GitBox
lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none() URL: https://github.com/apache/incubator-mxnet/issues/10220#issuecomment-375840105 Here is a minimum sample to reproduce this error ```python import mxnet as nd from mxnet import nd, sym, autogr

[GitHub] Lucasyc opened a new issue #10233: Endless Clone when importing on PowerPC

2018-03-23 Thread GitBox
Lucasyc opened a new issue #10233: Endless Clone when importing on PowerPC URL: https://github.com/apache/incubator-mxnet/issues/10233 Note: We are using ppc64le so we have to build from source. After all installation we try to import mxnet and then python shell get stuck. We looked int

[GitHub] lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none()

2018-03-23 Thread GitBox
lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none() URL: https://github.com/apache/incubator-mxnet/issues/10220#issuecomment-375840105 Here is a minimum sample to reproduce this error ```python import mxnet as nd from mxnet import nd, sym, autogr

[GitHub] zhangchen-qinyinghua commented on issue #9613: Transition matrix is not updated during the train in the lstm_crf example

2018-03-23 Thread GitBox
zhangchen-qinyinghua commented on issue #9613: Transition matrix is not updated during the train in the lstm_crf example URL: https://github.com/apache/incubator-mxnet/issues/9613#issuecomment-375840160 @anirudh2290 The problem is, the transition matrix should be made one of the parame

[GitHub] lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none()

2018-03-23 Thread GitBox
lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none() URL: https://github.com/apache/incubator-mxnet/issues/10220#issuecomment-375840105 Here is a minimum sample to reproduce this error ```python import mxnet as nd from mxnet import nd, sym, autogr

[GitHub] lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none()

2018-03-23 Thread GitBox
lightingghost commented on issue #10220: Check failed: !ndinputs.back()->is_none() URL: https://github.com/apache/incubator-mxnet/issues/10220#issuecomment-375840105 Here is a minimum sample to reproduce the error ```python import mxnet as nd from mxnet import nd, sym, autogra

[GitHub] rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-375835736 @piiswrong and @cjolivier01 I've implemented a new interface now. Merged with the existing inte

[GitHub] TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously

2018-03-23 Thread GitBox
TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375836486 One minor suggestion: why not implement reorder as a operator and dependency check to dependency engine? S

[GitHub] sxjscience commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-23 Thread GitBox
sxjscience commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-375836392 We need to either break the backward compatibility of the CPP package or the backward compatibility of the Pyth

[GitHub] rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-375835736 @piiswrong and @cjolivier01 I've implemented a new interface now. Merged with the existing inte

[GitHub] rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-375835736 @piiswrong and @cjolivier01 I've implemented a new interface now. Merged with the existing inte

[GitHub] rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#issuecomment-375835656 @piiswrong Could you please review? This is an automate

[GitHub] rahul003 commented on issue #8390: ValueError: need more than 1 value to unpack

2018-03-23 Thread GitBox
rahul003 commented on issue #8390: ValueError: need more than 1 value to unpack URL: https://github.com/apache/incubator-mxnet/issues/8390#issuecomment-375833844 Need to add the label converter, gluon This is an automated mes

[GitHub] sxjscience closed issue #4045: inferred shape error with FullyConnected layer

2018-03-23 Thread GitBox
sxjscience closed issue #4045: inferred shape error with FullyConnected layer URL: https://github.com/apache/incubator-mxnet/issues/4045 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] nickeleres commented on issue #4045: inferred shape error with FullyConnected layer

2018-03-23 Thread GitBox
nickeleres commented on issue #4045: inferred shape error with FullyConnected layer URL: https://github.com/apache/incubator-mxnet/issues/4045#issuecomment-375833045 I believe this issue was resolved, thank you > On Mar 23, 2018, at 5:42 PM, Rahul Huilgol wrote: > > @nickel

[GitHub] rahul003 commented on issue #4045: inferred shape error with FullyConnected layer

2018-03-23 Thread GitBox
rahul003 commented on issue #4045: inferred shape error with FullyConnected layer URL: https://github.com/apache/incubator-mxnet/issues/4045#issuecomment-375832949 @nickeleres If you are still facing this issue, please use our discussion forum to get help. https://discuss.mxnet.io --

[GitHub] rahul003 commented on issue #4045: inferred shape error with FullyConnected layer

2018-03-23 Thread GitBox
rahul003 commented on issue #4045: inferred shape error with FullyConnected layer URL: https://github.com/apache/incubator-mxnet/issues/4045#issuecomment-375832239 Needs to be labeled Question, Symbol, Howto This is an autom

[GitHub] rahul003 commented on issue #4045: inferred shape error with FullyConnected layer

2018-03-23 Thread GitBox
rahul003 commented on issue #4045: inferred shape error with FullyConnected layer URL: https://github.com/apache/incubator-mxnet/issues/4045#issuecomment-375832239 Needs to be labeled Question This is an automated message fr

[GitHub] anirudhacharya commented on issue #10118: [MXNET-106][ONNX-MXNET] Adding ONNX Model zoo tests.

2018-03-23 Thread GitBox
anirudhacharya commented on issue #10118: [MXNET-106][ONNX-MXNET] Adding ONNX Model zoo tests. URL: https://github.com/apache/incubator-mxnet/pull/10118#issuecomment-375831579 @nswamy @piiswrong Please review this PR. This i

[GitHub] haojin2 commented on a change in pull request #10208: [MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr

2018-03-23 Thread GitBox
haojin2 commented on a change in pull request #10208: [MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr URL: https://github.com/apache/incubator-mxnet/pull/10208#discussion_r176890725 ## File path: src/operator/tensor/elemwise_binary_broadcast_op.h ## @@ -76,

[GitHub] piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators

2018-03-23 Thread GitBox
piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r176889828 ## File path: src/operator/contrib/bilinear_resize-inl.h ## @@ -0,0 +1,

[GitHub] piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators

2018-03-23 Thread GitBox
piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r176889815 ## File path: src/operator/contrib/adaptive_avg_pooling-inl.h ## @@ -0,

[GitHub] piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators

2018-03-23 Thread GitBox
piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r176889746 ## File path: src/operator/contrib/adaptive_avg_pooling.cc ## @@ -0,0 +

[GitHub] piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators

2018-03-23 Thread GitBox
piiswrong commented on a change in pull request #9688: [MXNET-108] Adding BilinearResize2D and AdaptiveAvgPool2d operators URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r176889719 ## File path: src/operator/contrib/adaptive_avg_pooling.cc ## @@ -0,0 +

[GitHub] szha commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-23 Thread GitBox
szha commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375825106 @ThomasDelteil can you do a rebase? There were recent module moves that broke CI.

[GitHub] rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#issuecomment-375784506 Yeah we should turn it on This is an automated message

[GitHub] anirudhacharya opened a new pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

2018-03-23 Thread GitBox
anirudhacharya opened a new pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests URL: https://github.com/apache/incubator-mxnet/pull/10216 Raising PR to run the CI pipeline for this code This is an automated message

[GitHub] rahul003 opened a new pull request #10232: [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI

2018-03-23 Thread GitBox
rahul003 opened a new pull request #10232: [WIP] [DO_NOT_MERGE] Enabling USE_DIST_KVSTORE flag for CI URL: https://github.com/apache/incubator-mxnet/pull/10232 ## Description ## Enabled for make to start with. CMake would need some dependencies installed. ## Checklist ## ##

[GitHub] eric-haibin-lin commented on issue #10208: [MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr

2018-03-23 Thread GitBox
eric-haibin-lin commented on issue #10208: [MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr URL: https://github.com/apache/incubator-mxnet/pull/10208#issuecomment-375820626 @marcoabreu the pylint result failed on lines not added by this PR. Is there anything not tested on CI

[GitHub] rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-23 Thread GitBox
rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#issuecomment-373228390 ![Example profile where this operation can help. Server process of kvstore during distr

[GitHub] cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats

2018-03-23 Thread GitBox
cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats URL: https://github.com/apache/incubator-mxnet/pull/10228#issuecomment-375816614 the option can be turned on and off at will. I think calling into engine and adjusting the value from

[GitHub] cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats

2018-03-23 Thread GitBox
cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats URL: https://github.com/apache/incubator-mxnet/pull/10228#issuecomment-375816813 Plus, this way it saves it and resores ---

[GitHub] cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats

2018-03-23 Thread GitBox
cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats URL: https://github.com/apache/incubator-mxnet/pull/10228#issuecomment-375816614 the option can be turned on and off at will. I think calling into engine and adjusting the value from

[GitHub] cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats

2018-03-23 Thread GitBox
cjolivier01 commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats URL: https://github.com/apache/incubator-mxnet/pull/10228#issuecomment-375816614 the option can be turned on and off at will. I think calling it from Profiler::SetConfig() would be we

[GitHub] anirudhacharya closed pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

2018-03-23 Thread GitBox
anirudhacharya closed pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests URL: https://github.com/apache/incubator-mxnet/pull/10216 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] anirudhacharya commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

2018-03-23 Thread GitBox
anirudhacharya commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r176876550 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -46,5 +43,5 @@ def i

[GitHub] eric-haibin-lin opened a new pull request #10231: [MXNET-16] move dmlc-core & nnvm

2018-03-23 Thread GitBox
eric-haibin-lin opened a new pull request #10231: [MXNET-16] move dmlc-core & nnvm URL: https://github.com/apache/incubator-mxnet/pull/10231 #10213 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to r

[GitHub] szha commented on a change in pull request #10225: fix word language model script and readme

2018-03-23 Thread GitBox
szha commented on a change in pull request #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#discussion_r176874393 ## File path: example/gluon/word_language_model/README.md ## @@ -1,67 +1,59 @@ # Word-level languag

[GitHub] nswamy commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r176874283 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -46,5 +43,5 @@ def import_mo

[GitHub] reminisce closed issue #10227: Flaky test: test_operator.test_layer_norm

2018-03-23 Thread GitBox
reminisce closed issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] eric-haibin-lin commented on issue #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty

2018-03-23 Thread GitBox
eric-haibin-lin commented on issue #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty URL: https://github.com/apache/incubator-mxnet/pull/10213#issuecomment-375808964 The CI is not running. I'm going to close it and create a new one. -

[GitHub] eric-haibin-lin closed pull request #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty

2018-03-23 Thread GitBox
eric-haibin-lin closed pull request #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty URL: https://github.com/apache/incubator-mxnet/pull/10213 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] szhengac commented on a change in pull request #10225: fix word language model script and readme

2018-03-23 Thread GitBox
szhengac commented on a change in pull request #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#discussion_r176873734 ## File path: example/gluon/word_language_model/README.md ## @@ -1,67 +1,59 @@ # Word-level lan

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176871026 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/ObjectDetect

[GitHub] eric-haibin-lin commented on issue #10094: [MXNET-89] Bug fix for bucketing module

2018-03-23 Thread GitBox
eric-haibin-lin commented on issue #10094: [MXNET-89] Bug fix for bucketing module URL: https://github.com/apache/incubator-mxnet/pull/10094#issuecomment-375808391 Sorry I missed the notification when you tagged me. Looks good. -

[GitHub] eric-haibin-lin commented on a change in pull request #10149: WIP: import Julia binding

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10149: WIP: import Julia binding URL: https://github.com/apache/incubator-mxnet/pull/10149#discussion_r176871398 ## File path: julia/README-DEV.md ## @@ -0,0 +1,13 @@ +# Workflow for making a release Review comment:

[GitHub] eric-haibin-lin commented on a change in pull request #10149: WIP: import Julia binding

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10149: WIP: import Julia binding URL: https://github.com/apache/incubator-mxnet/pull/10149#discussion_r176872523 ## File path: julia/deps/cblas.h ## @@ -0,0 +1,544 @@ +#ifndef CBLAS_H Review comment: Is it necess

[GitHub] piiswrong commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats

2018-03-23 Thread GitBox
piiswrong commented on issue #10228: [MXNET-134] Don't do imperative bulk when profiling aggregate stats URL: https://github.com/apache/incubator-mxnet/pull/10228#issuecomment-375807526 How about making engine->bulk_size always 0 when aggregate is running? -

[GitHub] anirudh2290 commented on a change in pull request #10014: [MXNET-81] Fix crash with mx.nd.ones

2018-03-23 Thread GitBox
anirudh2290 commented on a change in pull request #10014: [MXNET-81] Fix crash with mx.nd.ones URL: https://github.com/apache/incubator-mxnet/pull/10014#discussion_r176872373 ## File path: src/imperative/imperative_utils.h ## @@ -70,12 +70,14 @@ inline Context GetContext(c

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176870901 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/ObjectDetect

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176866146 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176867484 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176866239 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176867058 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176867417 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176868169 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176869129 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176869347 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176869213 ## File path: scala-package/examples/src/main/scala/ml/dmlc/mxnetexamples/inferex

[GitHub] nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
nswamy commented on a change in pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229#discussion_r176871872 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/ObjectDetect

[GitHub] rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#issuecomment-375784506 Yeah we should turn it on for all builds This is an aut

[GitHub] rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on issue #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#issuecomment-375804869 Thanks @cjolivier01 and @haojin2 , reduced some multiplications, added const to more places and changed couple of variab

[GitHub] rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
rahul003 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176869283 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -171,28 +210,31 @@ class KVStor

[GitHub] eric-haibin-lin commented on issue #9396: inference speed drop after updating mxnet from 0.10.0 to 1.0.0

2018-03-23 Thread GitBox
eric-haibin-lin commented on issue #9396: inference speed drop after updating mxnet from 0.10.0 to 1.0.0 URL: https://github.com/apache/incubator-mxnet/issues/9396#issuecomment-375800483 @DickJC123 thanks! That will be great. --

[GitHub] piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

2018-03-23 Thread GitBox
piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r176864388 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -46,5 +43,5 @@ def import

[incubator-mxnet] branch master updated: [MXNet-111] Doc for gluon.data.transforms (#10155)

2018-03-23 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 5c7407d [MXNet-111] Doc for gluon.data.t

[GitHub] piiswrong closed pull request #10155: [MXNet-111] Doc for gluon.data.transforms

2018-03-23 Thread GitBox
piiswrong closed pull request #10155: [MXNet-111] Doc for gluon.data.transforms URL: https://github.com/apache/incubator-mxnet/pull/10155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] piiswrong commented on issue #10215: [WIP] Avoid MKLDNN in-place data conversion in NDArray synchronously

2018-03-23 Thread GitBox
piiswrong commented on issue #10215: [WIP] Avoid MKLDNN in-place data conversion in NDArray synchronously URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375798589 sure This is an automated message from

[GitHub] msurguy opened a new issue #10230: libomp.so is missing in Docker builds for armv6

2018-03-23 Thread GitBox
msurguy opened a new issue #10230: libomp.so is missing in Docker builds for armv6 URL: https://github.com/apache/incubator-mxnet/issues/10230 ## Description After compiling and deploying MXNet to Raspberry Pi Zero using the new Docker builds, the `libomp.so` error prevents import of MX

[GitHub] lanking520 commented on issue #10179: [MXNET-116] object detector class added

2018-03-23 Thread GitBox
lanking520 commented on issue #10179: [MXNET-116] object detector class added URL: https://github.com/apache/incubator-mxnet/pull/10179#issuecomment-375796536 Please move to: https://github.com/apache/incubator-mxnet/pull/10229. --

[GitHub] lanking520 opened a new pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample

2018-03-23 Thread GitBox
lanking520 opened a new pull request #10229: [MXNET-116] Inference - ObjectDetector and SSDObjectDetectorExample URL: https://github.com/apache/incubator-mxnet/pull/10229 ## Description ## Add Object Detection Class for MXNet Inference API, also add test and example to it. This code is

[GitHub] szha commented on issue #10225: fix word language model script and readme

2018-03-23 Thread GitBox
szha commented on issue #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#issuecomment-375796103 It's mostly useful when many HybridBlocks are stacked together. Right now there are no such cases.

[GitHub] szha commented on a change in pull request #10225: fix word language model script and readme

2018-03-23 Thread GitBox
szha commented on a change in pull request #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#discussion_r176860890 ## File path: example/gluon/word_language_model/README.md ## @@ -1,67 +1,59 @@ # Word-level languag

[GitHub] sxjscience commented on a change in pull request #10225: fix word language model script and readme

2018-03-23 Thread GitBox
sxjscience commented on a change in pull request #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#discussion_r176860732 ## File path: example/gluon/word_language_model/README.md ## @@ -1,67 +1,59 @@ # Word-level l

[GitHub] szhengac commented on issue #10225: fix word language model script and readme

2018-03-23 Thread GitBox
szhengac commented on issue #10225: fix word language model script and readme URL: https://github.com/apache/incubator-mxnet/pull/10225#issuecomment-375794911 but it may be useful if some internal blocks were hybridblock, especially when users want to create their custom layers using hybrid

  1   2   3   >