[GitHub] jinhuang415 commented on issue #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-25 Thread GitBox
jinhuang415 commented on issue #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#issuecomment-384533399 @zheng-da Correct my word, for mkldnn_OIhw4i16o4i change in mkldnn_base.cc, this format is needed by int8 otherwise will

[GitHub] jinhuang415 commented on issue #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-25 Thread GitBox
jinhuang415 commented on issue #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#issuecomment-384533399 @zheng-da Correct my word, for mkldnn_OIhw4i16o4i change in mkldnn_base.cc, this format is needed by int8 otherwise will

[GitHub] Paul0M commented on issue #7958: Engine shutdown

2018-04-25 Thread GitBox
Paul0M commented on issue #7958: Engine shutdown URL: https://github.com/apache/incubator-mxnet/issues/7958#issuecomment-384528403 Hi, I've got the same error. using PIL, this can be avoid as: ```python from PIL import ImageFile ImageFile.LOAD_TRUNCATED_IMAGES = True ``` B

[GitHub] ashokei commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency

2018-04-25 Thread GitBox
ashokei commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency URL: https://github.com/apache/incubator-mxnet/pull/10616#discussion_r184280082 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -89,6 +91,33 @@ def get_tensors(args,

[GitHub] spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384523082 [FER+ Emotion Recognition](https://github.com/onnx/models/tree/master/emotion_ferplus) is using legacy attri

[GitHub] spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384523082 [FER+ Emotion Recognition](https://github.com/onnx/models/tree/master/emotion_ferplus) is using legacy attri

[GitHub] spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
spidyDev commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384523082 FER+ Emotion Recognition is using legacy attribute for convolution , **auto_pad**, which we do not support.

[GitHub] zheng-da closed pull request #10691: Fix a CUDNN macro.

2018-04-25 Thread GitBox
zheng-da closed pull request #10691: Fix a CUDNN macro. URL: https://github.com/apache/incubator-mxnet/pull/10691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[GitHub] zheng-da commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency

2018-04-25 Thread GitBox
zheng-da commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency URL: https://github.com/apache/incubator-mxnet/pull/10616#discussion_r184275445 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -89,6 +91,33 @@ def get_tensors(args

[GitHub] eric-haibin-lin closed pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-25 Thread GitBox
eric-haibin-lin closed pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed belo

[incubator-mxnet] branch master updated: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU (#10371)

2018-04-25 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 8727cae [MXNET-263] Support for dot(dn

[GitHub] threeleafzerg opened a new pull request #10696: Extend MXNet Distributed Training by MPI AllReduce

2018-04-25 Thread GitBox
threeleafzerg opened a new pull request #10696: Extend MXNet Distributed Training by MPI AllReduce URL: https://github.com/apache/incubator-mxnet/pull/10696 ## Description ## We extend MXNet distributed training by adding one new type of kvstore (dist_sync_mpi). In this type of k

[GitHub] zheng-da commented on issue #10678: invalidate MKLDNN memory for reused NDArrays.

2018-04-25 Thread GitBox
zheng-da commented on issue #10678: invalidate MKLDNN memory for reused NDArrays. URL: https://github.com/apache/incubator-mxnet/pull/10678#issuecomment-384518069 @eric-haibin-lin This test case is different, at least from Python. I'm thinking of writing a C++ unit test for graph execution

[GitHub] haojin2 commented on issue #10693: [MXNET-346] Fix flaky test for hard sigmoid

2018-04-25 Thread GitBox
haojin2 commented on issue #10693: [MXNET-346] Fix flaky test for hard sigmoid URL: https://github.com/apache/incubator-mxnet/pull/10693#issuecomment-384512855 Closing now as @piiswrong got the changes integrated into #10687.

[GitHub] haojin2 closed pull request #10693: [MXNET-346] Fix flaky test for hard sigmoid

2018-04-25 Thread GitBox
haojin2 closed pull request #10693: [MXNET-346] Fix flaky test for hard sigmoid URL: https://github.com/apache/incubator-mxnet/pull/10693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] lilhope commented on issue #10674: How to resize mx.NDArray 2d tensor with interp = 'Nearest'

2018-04-25 Thread GitBox
lilhope commented on issue #10674: How to resize mx.NDArray 2d tensor with interp = 'Nearest' URL: https://github.com/apache/incubator-mxnet/issues/10674#issuecomment-384512132 Using the mx.nd.Upsampling This is an automated

[GitHub] piiswrong commented on issue #10693: [MXNET-346] Fix flaky test for hard sigmoid

2018-04-25 Thread GitBox
piiswrong commented on issue #10693: [MXNET-346] Fix flaky test for hard sigmoid URL: https://github.com/apache/incubator-mxnet/pull/10693#issuecomment-384511285 @marcoabreu any idea why kernel died in tutorial test? http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator

[incubator-mxnet] 03/04: Revert "invalidate outputs for imperative."

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit b428937968adf177e0260361c972e502e839edb5 Author: Da Zheng AuthorDate: Wed Apr 25 17:37:03 2018 -0700 Revert

[incubator-mxnet] 01/04: invalidate outputs for imperative.

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit a5d7893511d80f76b6dc0f8ee03e6aee3ff98fc1 Author: Da Zheng AuthorDate: Tue Apr 24 20:29:31 2018 + invalid

[incubator-mxnet] 02/04: Invalidate all MKLDNN memory for reused NDArray.

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 860bfa8aa8e885b455c0a2e49b0980e899252ee6 Author: Da Zheng AuthorDate: Wed Apr 25 16:08:00 2018 -0700 Invalid

[incubator-mxnet] 04/04: remove mkldnn memory invalidation in graph execution.

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 8b91bce2da915c92203c39120b58c98c945fd1fa Author: Da Zheng AuthorDate: Wed Apr 25 18:07:26 2018 -0700 remove

[incubator-mxnet] branch master updated (0cd082b -> 8b91bce)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 0cd082b fix for asymmetric padding (#10676) new a5d7893 invalidate outputs for imperative. new 860

[GitHub] piiswrong closed pull request #10678: invalidate MKLDNN memory for reused NDArrays.

2018-04-25 Thread GitBox
piiswrong closed pull request #10678: invalidate MKLDNN memory for reused NDArrays. URL: https://github.com/apache/incubator-mxnet/pull/10678 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] arundasan91 commented on a change in pull request #10685: Update fit.py

2018-04-25 Thread GitBox
arundasan91 commented on a change in pull request #10685: Update fit.py URL: https://github.com/apache/incubator-mxnet/pull/10685#discussion_r184268301 ## File path: example/image-classification/common/fit.py ## @@ -238,7 +238,7 @@ def fit(args, network, data_loader, **kwar

[GitHub] CodingCat commented on a change in pull request #10462: [MXNET-62] add test against spark integration

2018-04-25 Thread GitBox
CodingCat commented on a change in pull request #10462: [MXNET-62] add test against spark integration URL: https://github.com/apache/incubator-mxnet/pull/10462#discussion_r184266172 ## File path: scala-package/spark/src/test/scala/org/apache/mxnet/spark/MXNetGeneralSuite.scala ###

[GitHub] anirudhacharya commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
anirudhacharya commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384498768 These are the tests running on onnx CI with the latest master - https://github.com/onnx/onnx/blob/maste

[GitHub] anirudhacharya commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
anirudhacharya commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384498768 These are the tests running on onnx CI with the latest master - https://github.com/onnx/onnx/blob/maste

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-04-25 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 8f18c9e Bump the publish ti

[GitHub] wkcn commented on issue #10684: How do I install mxnet on Termux?

2018-04-25 Thread GitBox
wkcn commented on issue #10684: How do I install mxnet on Termux? URL: https://github.com/apache/incubator-mxnet/issues/10684#issuecomment-384494009 You could compile the source code of MXNet. I tried it in Termux but it took a long time. ---

[GitHub] wkcn commented on issue #10689: MXNet conv should check the number of elements in strides, padding, etc.

2018-04-25 Thread GitBox
wkcn commented on issue #10689: MXNet conv should check the number of elements in strides, padding, etc. URL: https://github.com/apache/incubator-mxnet/issues/10689#issuecomment-384493545 It seems that the shape of arr1 is (10,10,30,1), and the shape of arr2 is (10,10,30,30). The cpu o

[GitHub] luoyetx opened a new issue #10695: SymbolBlock has no `_reg_params` which cause save/load params fails

2018-04-25 Thread GitBox
luoyetx opened a new issue #10695: SymbolBlock has no `_reg_params` which cause save/load params fails URL: https://github.com/apache/incubator-mxnet/issues/10695 ## Description block with symbol block as child doesn't save/load symbol block's parameters. ## Environment info (Requ

[GitHub] lupesko commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
lupesko commented on issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694#issuecomment-384489700 @anirudhacharya @spidyDev @Roshrini This is

[GitHub] lupesko opened a new issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out

2018-04-25 Thread GitBox
lupesko opened a new issue #10694: Importing an ONNX model (from model zoo) to MXNet errors out URL: https://github.com/apache/incubator-mxnet/issues/10694 ## Description Importing an ONNX model to MXNet errors out. Model: [FER+ Emotion Recognition](https://github.com/onnx/models/tre

[GitHub] haojin2 opened a new pull request #10693: [MXNET-346] Fix flaky test for hard sigmoid

2018-04-25 Thread GitBox
haojin2 opened a new pull request #10693: [MXNET-346] Fix flaky test for hard sigmoid URL: https://github.com/apache/incubator-mxnet/pull/10693 ## Description ## Same as title. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. -

[GitHub] szha commented on a change in pull request #10687: Fix multi context hybrid

2018-04-25 Thread GitBox
szha commented on a change in pull request #10687: Fix multi context hybrid URL: https://github.com/apache/incubator-mxnet/pull/10687#discussion_r184246131 ## File path: tests/python/unittest/test_gluon.py ## @@ -966,6 +968,12 @@ def test_save_load(): net.load_params

[GitHub] zheng-da commented on a change in pull request #10687: Fix multi context hybrid

2018-04-25 Thread GitBox
zheng-da commented on a change in pull request #10687: Fix multi context hybrid URL: https://github.com/apache/incubator-mxnet/pull/10687#discussion_r184245816 ## File path: tests/python/unittest/test_gluon.py ## @@ -966,6 +968,12 @@ def test_save_load(): net.load_pa

[GitHub] rahul003 commented on a change in pull request #10685: Update fit.py

2018-04-25 Thread GitBox
rahul003 commented on a change in pull request #10685: Update fit.py URL: https://github.com/apache/incubator-mxnet/pull/10685#discussion_r184245569 ## File path: example/image-classification/common/fit.py ## @@ -238,7 +238,7 @@ def fit(args, network, data_loader, **kwargs)

[GitHub] rahul003 commented on a change in pull request #10685: Update fit.py

2018-04-25 Thread GitBox
rahul003 commented on a change in pull request #10685: Update fit.py URL: https://github.com/apache/incubator-mxnet/pull/10685#discussion_r184245569 ## File path: example/image-classification/common/fit.py ## @@ -238,7 +238,7 @@ def fit(args, network, data_loader, **kwargs)

[GitHub] szha commented on a change in pull request #10687: Fix multi context hybrid

2018-04-25 Thread GitBox
szha commented on a change in pull request #10687: Fix multi context hybrid URL: https://github.com/apache/incubator-mxnet/pull/10687#discussion_r184245550 ## File path: tests/python/unittest/test_gluon.py ## @@ -966,6 +968,12 @@ def test_save_load(): net.load_params

[GitHub] spidyDev commented on issue #10588: Error while trying to run LeakyRelu layer with 1-d input

2018-04-25 Thread GitBox
spidyDev commented on issue #10588: Error while trying to run LeakyRelu layer with 1-d input URL: https://github.com/apache/incubator-mxnet/issues/10588#issuecomment-384478214 @cjolivier01 Please tag this as : Operator, Bug

[GitHub] KellenSunderland opened a new issue #10692: Executor's set_monitor_callback leaks memory in high-level languages.

2018-04-25 Thread GitBox
KellenSunderland opened a new issue #10692: Executor's set_monitor_callback leaks memory in high-level languages. URL: https://github.com/apache/incubator-mxnet/issues/10692 ## Description Executor's set_monitor_callback leaks memory in high-level languages. ## Environment info (R

[GitHub] zheng-da opened a new pull request #10691: Fix a CUDNN macro.

2018-04-25 Thread GitBox
zheng-da opened a new pull request #10691: Fix a CUDNN macro. URL: https://github.com/apache/incubator-mxnet/pull/10691 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR.

[GitHub] ThomasDelteil commented on issue #10628: [MXNET-342] Fix the multi worker Dataloader

2018-04-25 Thread GitBox
ThomasDelteil commented on issue #10628: [MXNET-342] Fix the multi worker Dataloader URL: https://github.com/apache/incubator-mxnet/pull/10628#issuecomment-384453317 closing for now after @piiswrong design concerns. The bug is still present though.

[GitHub] ThomasDelteil closed pull request #10628: [MXNET-342] Fix the multi worker Dataloader

2018-04-25 Thread GitBox
ThomasDelteil closed pull request #10628: [MXNET-342] Fix the multi worker Dataloader URL: https://github.com/apache/incubator-mxnet/pull/10628 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] piiswrong closed pull request #10690: Add known issues to Release notes

2018-04-25 Thread GitBox
piiswrong closed pull request #10690: Add known issues to Release notes URL: https://github.com/apache/incubator-mxnet/pull/10690 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[incubator-mxnet] branch v1.2.0 updated: Add known issue to NEWS.md

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.2.0 by this push: new 1bebe24 Add known issue to NEWS.md 1bebe

[GitHub] anirudh2290 opened a new pull request #10690: Add known issues to Release notes

2018-04-25 Thread GitBox
anirudh2290 opened a new pull request #10690: Add known issues to Release notes URL: https://github.com/apache/incubator-mxnet/pull/10690 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable

[GitHub] zheng-da opened a new issue #10689: MXNet conv should check the number of elements in strides, padding, etc.

2018-04-25 Thread GitBox
zheng-da opened a new issue #10689: MXNet conv should check the number of elements in strides, padding, etc. URL: https://github.com/apache/incubator-mxnet/issues/10689 MXNet conv doesn't check the number of elements in strides, padding, etc. Below is the code from @anirudh2290 that

[GitHub] zheng-da commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-25 Thread GitBox
zheng-da commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#issuecomment-384441792 ```python import mxnet as mx arr = mx.nd.random.uniform(shape=(10, 10, 32, 32)) weight1 = mx.nd.random.un

[GitHub] haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184211691 ## File path: tests/python/unittest/test_operator.py ## @@ -1581,6 +1581,27 @@ def test_bmin(a,

[GitHub] anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184211108 ## File path: tests/python/unittest/test_operator.py ## @@ -1581,6 +1581,27 @@ def test_b

[GitHub] haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184208948 ## File path: tests/python/unittest/test_operator.py ## @@ -1581,6 +1581,27 @@ def test_bmin(a,

[GitHub] haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
haojin2 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184208948 ## File path: tests/python/unittest/test_operator.py ## @@ -1581,6 +1581,27 @@ def test_bmin(a,

[GitHub] piiswrong closed pull request #10688: Fix asymmetric padding(#10676)

2018-04-25 Thread GitBox
piiswrong closed pull request #10688: Fix asymmetric padding(#10676) URL: https://github.com/apache/incubator-mxnet/pull/10688 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[incubator-mxnet] branch v1.2.0 updated: Merge asymmetric padding(#10676)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.2.0 by this push: new 5ab574f Merge asymmetric padding(#10676)

[GitHub] zhanghang1989 commented on issue #9989: Cannot train example gluon style transfer

2018-04-25 Thread GitBox
zhanghang1989 commented on issue #9989: Cannot train example gluon style transfer URL: https://github.com/apache/incubator-mxnet/issues/9989#issuecomment-384435679 I will look into it and get back to you. This is an automat

[GitHub] anirudh2290 opened a new pull request #10688: Fix asymmetric padding(#10676)

2018-04-25 Thread GitBox
anirudh2290 opened a new pull request #10688: Fix asymmetric padding(#10676) URL: https://github.com/apache/incubator-mxnet/pull/10688 ## Description ## Add #10676 to Release branch ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR.

[GitHub] anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184206277 ## File path: src/operator/mshadow_op.h ## @@ -317,6 +317,12 @@ MXNET_BINARY_MATH_OP_NC(e

[GitHub] anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184205812 ## File path: src/operator/mshadow_op.h ## @@ -317,6 +317,12 @@ MXNET_BINARY_MATH_OP_NC(e

[GitHub] cjolivier01 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
cjolivier01 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184205145 ## File path: tests/python/unittest/test_operator.py ## @@ -1581,6 +1581,27 @@ def test_bmin

[GitHub] cjolivier01 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR

2018-04-25 Thread GitBox
cjolivier01 commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184203737 ## File path: src/operator/mshadow_op.h ## @@ -317,6 +317,12 @@ MXNET_BINARY_MATH_OP_NC(eq,

[GitHub] ashokei commented on issue #10619: handle NDArray slice properly for mkldnn layout

2018-04-25 Thread GitBox
ashokei commented on issue #10619: handle NDArray slice properly for mkldnn layout URL: https://github.com/apache/incubator-mxnet/pull/10619#issuecomment-384429059 @zheng-da can you please review and accept PR, unittest is added. please add approver also, thanks. -

[GitHub] anirudh2290 commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-25 Thread GitBox
anirudh2290 commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#issuecomment-384428751 I ran the following simple script with the code pulled from your branch: ``` import mxnet as mx arr =

[GitHub] anirudh2290 commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-25 Thread GitBox
anirudh2290 commented on issue #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#issuecomment-384428751 I ran the following simple script with the code pulled from your branch: ``` import mxnet as mx arr =

[GitHub] KaiserSozo commented on issue #10532: NDArray failed to allocate CPU memory

2018-04-25 Thread GitBox
KaiserSozo commented on issue #10532: NDArray failed to allocate CPU memory URL: https://github.com/apache/incubator-mxnet/issues/10532#issuecomment-384427810 Anybody here? This is an automated message from the Apache Git Ser

[GitHub] piiswrong closed pull request #10676: fix for asymmetric padding

2018-04-25 Thread GitBox
piiswrong closed pull request #10676: fix for asymmetric padding URL: https://github.com/apache/incubator-mxnet/pull/10676 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-mxnet] branch master updated: fix for asymmetric padding (#10676)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 0cd082b fix for asymmetric padding (#106

[GitHub] lanking520 commented on issue #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on issue #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#issuecomment-384425498 The recent commit including the new API functions, currently we call them "New". To access them, build the package and call New and yo

[GitHub] lanking520 commented on issue #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on issue #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#issuecomment-384425498 The recent commit including the new API functions, currently we call them "New". To access them, build the package and call New and yo

[GitHub] lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r184196480 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala ## @@ -136,2

[GitHub] lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r184196188 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala ## @@ -136,2

[GitHub] lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r184196188 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala ## @@ -136,2

[GitHub] lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design

2018-04-25 Thread GitBox
lanking520 commented on a change in pull request #10660: [MXNET-357][WIP] New Scala API Design URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r184195708 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala ## @@ -136,2

[GitHub] cjolivier01 closed pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-25 Thread GitBox
cjolivier01 closed pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-mxnet] branch master updated: Use default nvcc when configured nvcc not present. (#10566)

2018-04-25 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 663df0f Use default nvcc when con

[incubator-mxnet] branch v1.2.0 updated: Use default nvcc when configured nvcc not present. (#10569)

2018-04-25 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.2.0 by this push: new 9c47098 Use default nvcc when con

[GitHub] cjolivier01 closed pull request #10569: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-25 Thread GitBox
cjolivier01 closed pull request #10569: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10569 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ashokei commented on issue #10616: ensure same mkldnn engine is used for consistency

2018-04-25 Thread GitBox
ashokei commented on issue #10616: ensure same mkldnn engine is used for consistency URL: https://github.com/apache/incubator-mxnet/pull/10616#issuecomment-384415826 @zheng-da added unittest, @marcoabreu can you please merge if ok. thanks. --

[GitHub] anirudh2290 commented on issue #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-25 Thread GitBox
anirudh2290 commented on issue #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#issuecomment-384412656 @cjolivier01 would you be able to take a look ? ---

[GitHub] anirudh2290 commented on issue #10569: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-25 Thread GitBox
anirudh2290 commented on issue #10569: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10569#issuecomment-384412557 @cjolivier01 would you be able to take a look ? ---

[GitHub] piiswrong opened a new pull request #10687: Fix multi context hybrid

2018-04-25 Thread GitBox
piiswrong opened a new pull request #10687: Fix multi context hybrid URL: https://github.com/apache/incubator-mxnet/pull/10687 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for y

[GitHub] anirudh2290 commented on issue #10676: fix for asymmetric padding

2018-04-25 Thread GitBox
anirudh2290 commented on issue #10676: fix for asymmetric padding URL: https://github.com/apache/incubator-mxnet/pull/10676#issuecomment-384407896 @piiswrong @eric-haibin-lin is this good to merge ? This is an automated messag

[GitHub] crawforc3 opened a new issue #10686: Building from source fails

2018-04-25 Thread GitBox
crawforc3 opened a new issue #10686: Building from source fails URL: https://github.com/apache/incubator-mxnet/issues/10686 I've been following the instructions from [this page](https://mxnet.incubator.apache.org/install/index.html) to build MXnet from source for Linux + R + CPU and am r

[GitHub] larroy commented on issue #8729: Build amalgamation using a docker

2018-04-25 Thread GitBox
larroy commented on issue #8729: Build amalgamation using a docker URL: https://github.com/apache/incubator-mxnet/issues/8729#issuecomment-384403312 @wykvictor thanks for the feedback, we will likely improve this in the short future. I also think we need some kind of platform detection in

[incubator-mxnet] branch master updated: hard sigmoid together with unit test (#10633)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new efe5314 hard sigmoid together with unit

[GitHub] piiswrong closed pull request #10633: [MXNET-346] Hard Sigmoid Operator

2018-04-25 Thread GitBox
piiswrong closed pull request #10633: [MXNET-346] Hard Sigmoid Operator URL: https://github.com/apache/incubator-mxnet/pull/10633 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] anirudh2290 commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-25 Thread GitBox
anirudh2290 commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r184167522 ## File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc ## @@ -32,6 +3

[GitHub] haojin2 commented on a change in pull request #10633: [MXNET-346] Hard Sigmoid Operator

2018-04-25 Thread GitBox
haojin2 commented on a change in pull request #10633: [MXNET-346] Hard Sigmoid Operator URL: https://github.com/apache/incubator-mxnet/pull/10633#discussion_r184167279 ## File path: src/operator/tensor/elemwise_unary_op.h ## @@ -388,6 +388,94 @@ void CastCompute(const nnvm

[GitHub] piiswrong commented on a change in pull request #10633: [MXNET-346] Hard Sigmoid Operator

2018-04-25 Thread GitBox
piiswrong commented on a change in pull request #10633: [MXNET-346] Hard Sigmoid Operator URL: https://github.com/apache/incubator-mxnet/pull/10633#discussion_r184165156 ## File path: src/operator/tensor/elemwise_unary_op.h ## @@ -388,6 +388,94 @@ void CastCompute(const nn

[incubator-mxnet] branch v1.2.0 updated: Mark ONNX-MXNet experimental (#10677)

2018-04-25 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.2.0 by this push: new 3da2939 Mark ONNX-MXNet experiment

[GitHub] marcoabreu closed pull request #10677: Mark ONNX-MXNet experimental

2018-04-25 Thread GitBox
marcoabreu closed pull request #10677: Mark ONNX-MXNet experimental URL: https://github.com/apache/incubator-mxnet/pull/10677 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[incubator-mxnet] branch master updated: Update CONTRIBUTORS.md (#10680)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 50c8d6a Update CONTRIBUTORS.md (#10680)

[GitHub] piiswrong closed pull request #10680: Update CONTRIBUTORS.md

2018-04-25 Thread GitBox
piiswrong closed pull request #10680: Update CONTRIBUTORS.md URL: https://github.com/apache/incubator-mxnet/pull/10680 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[incubator-mxnet] branch master updated: update doc for grad in autograd.py (#10683)

2018-04-25 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 9c601b0 update doc for grad in autograd.

[GitHub] piiswrong closed pull request #10683: update doc for grad in autograd.py

2018-04-25 Thread GitBox
piiswrong closed pull request #10683: update doc for grad in autograd.py URL: https://github.com/apache/incubator-mxnet/pull/10683 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] haojin2 commented on issue #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors

2018-04-25 Thread GitBox
haojin2 commented on issue #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors URL: https://github.com/apache/incubator-mxnet/pull/10550#issuecomment-384365246 @eric-haibin-lin Benchmark Results: (density% speedup of write inplace) (density% speedup of write

[GitHub] haojin2 commented on a change in pull request #10645: [MXNET-354] Support elemwise_add/sub between dense and row sparse tensors on CPU/GPU

2018-04-25 Thread GitBox
haojin2 commented on a change in pull request #10645: [MXNET-354] Support elemwise_add/sub between dense and row sparse tensors on CPU/GPU URL: https://github.com/apache/incubator-mxnet/pull/10645#discussion_r184160050 ## File path: src/operator/tensor/elemwise_binary_op-inl.h

[incubator-mxnet] branch master updated: [MX-307] Upgrade timeout to 10 minutes per test (#10682)

2018-04-25 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 16d8e16 [MX-307] Upgrade timeout t

[GitHub] marcoabreu closed pull request #10682: [MX-307] Upgrade timeout to 10 minutes per test

2018-04-25 Thread GitBox
marcoabreu closed pull request #10682: [MX-307] Upgrade timeout to 10 minutes per test URL: https://github.com/apache/incubator-mxnet/pull/10682 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] haojin2 commented on issue #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors

2018-04-25 Thread GitBox
haojin2 commented on issue #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors URL: https://github.com/apache/incubator-mxnet/pull/10550#issuecomment-384366007 Benchmark Script: ```python import mxnet as mx import numpy as np from mxnet.test_utils import r

  1   2   >