[GitHub] eric-haibin-lin commented on a change in pull request #12058: MKLDNN can be turned off with env var

2018-08-15 Thread GitBox
eric-haibin-lin commented on a change in pull request #12058: MKLDNN can be turned off with env var URL: https://github.com/apache/incubator-mxnet/pull/12058#discussion_r210393011 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -262,6 +262,12 @@ void CreateOpExecs

[GitHub] eric-haibin-lin commented on a change in pull request #12058: MKLDNN can be turned off with env var

2018-08-15 Thread GitBox
eric-haibin-lin commented on a change in pull request #12058: MKLDNN can be turned off with env var URL: https://github.com/apache/incubator-mxnet/pull/12058#discussion_r210393506 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -137,6 +137,10 @@ static inline

[GitHub] vishaalkapoor commented on issue #12165: [MXAPPS-581] Enable remaining tests in CI.

2018-08-15 Thread GitBox
vishaalkapoor commented on issue #12165: [MXAPPS-581] Enable remaining tests in CI. URL: https://github.com/apache/incubator-mxnet/pull/12165#issuecomment-413329816 Thanks for the review, @sandeep-krishnamurthy. These tests take around 40 minutes at present. With these notebooks, likely ~

[GitHub] vishaalkapoor edited a comment on issue #12165: [MXAPPS-581] Enable remaining tests in CI.

2018-08-15 Thread GitBox
vishaalkapoor edited a comment on issue #12165: [MXAPPS-581] Enable remaining tests in CI. URL: https://github.com/apache/incubator-mxnet/pull/12165#issuecomment-413329816 Thanks for the review, @sandeep-krishnamurthy. The nightly tests take around 40 minutes at present. With these noteboo

[GitHub] vishaalkapoor edited a comment on issue #12165: [MXAPPS-581] Enable remaining tests in CI.

2018-08-15 Thread GitBox
vishaalkapoor edited a comment on issue #12165: [MXAPPS-581] Enable remaining tests in CI. URL: https://github.com/apache/incubator-mxnet/pull/12165#issuecomment-413329816 Thanks for the review, @sandeep-krishnamurthy. The nightly tests take around 40 minutes at present. With the additiona

[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update

2018-08-15 Thread GitBox
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413332107 That switching to separate Python 2 and 3 in CI is breaking this. I'm working on a patch. ---

[GitHub] szha commented on issue #12183: Patch: Update contribute.md (Fix links to subscribe for users and contributors)

2018-08-15 Thread GitBox
szha commented on issue #12183: Patch: Update contribute.md (Fix links to subscribe for users and contributors) URL: https://github.com/apache/incubator-mxnet/pull/12183#issuecomment-413337164 can you do a rebase? `git remote add apache https://github.com/apache/incubator-mxnet; git pull a

[GitHub] apeforest commented on issue #7590: Gradient function not returning enough gradient

2018-08-15 Thread GitBox
apeforest commented on issue #7590: Gradient function not returning enough gradient URL: https://github.com/apache/incubator-mxnet/issues/7590#issuecomment-413341052 Ran the example in https://github.com/pangyupo/mxnet_center_loss/ and not able to reproduce the error any more. @sandeep-kr

[GitHub] zhreshold commented on issue #12118: fix potential floating number overflow, enable float16

2018-08-15 Thread GitBox
zhreshold commented on issue #12118: fix potential floating number overflow, enable float16 URL: https://github.com/apache/incubator-mxnet/pull/12118#issuecomment-413341420 CI always fails at deploy stage. Do you have a clue? @larroy ---

[GitHub] larroy commented on issue #12118: fix potential floating number overflow, enable float16

2018-08-15 Thread GitBox
larroy commented on issue #12118: fix potential floating number overflow, enable float16 URL: https://github.com/apache/incubator-mxnet/pull/12118#issuecomment-413343804 minor problem with doc generation. Are you rebased against master? -

[GitHub] muralibalki opened a new issue #12185: from_logits definition seems different from what is expected?

2018-08-15 Thread GitBox
muralibalki opened a new issue #12185: from_logits definition seems different from what is expected? URL: https://github.com/apache/incubator-mxnet/issues/12185 In loss functions like SoftmaxCrossEntropy, the definition of from_logits is: from_logits (bool, default False) – Whether input

[GitHub] zhreshold commented on issue #12118: fix potential floating number overflow, enable float16

2018-08-15 Thread GitBox
zhreshold commented on issue #12118: fix potential floating number overflow, enable float16 URL: https://github.com/apache/incubator-mxnet/pull/12118#issuecomment-413344153 @larroy Yep, just rebased 2 hours ago This is an aut

[GitHub] thomelane opened a new pull request #12186: Added comment to docs regarding ToTensor transform

2018-08-15 Thread GitBox
thomelane opened a new pull request #12186: Added comment to docs regarding ToTensor transform URL: https://github.com/apache/incubator-mxnet/pull/12186 ## Description ## Added note in documentation regarding order of transforms. User mentioned this in https://github.com/apache/i

[GitHub] thomelane edited a comment on issue #10906: transforms.Compose not working as expected.

2018-08-15 Thread GitBox
thomelane edited a comment on issue #10906: transforms.Compose not working as expected. URL: https://github.com/apache/incubator-mxnet/issues/10906#issuecomment-413346482 Submitted a PR to mention this in the documentation https://github.com/apache/incubator-mxnet/pull/12186 @sandeep-k

[GitHub] thomelane commented on issue #10906: transforms.Compose not working as expected.

2018-08-15 Thread GitBox
thomelane commented on issue #10906: transforms.Compose not working as expected. URL: https://github.com/apache/incubator-mxnet/issues/10906#issuecomment-413346482 Submitted a PR to mention this in the documentation https://github.com/apache/incubator-mxnet/pull/12186 @sandeep-krishnamu

[GitHub] zheng-da opened a new pull request #12187: Make sure input symbol names are unique in control flow operators.

2018-08-15 Thread GitBox
zheng-da opened a new pull request #12187: Make sure input symbol names are unique in control flow operators. URL: https://github.com/apache/incubator-mxnet/pull/12187 ## Description ## This is to fix the issue described in https://github.com/apache/incubator-mxnet/issues/12163

[GitHub] cclauss opened a new pull request #12188: [MXNET-696] Simplify the logic behind the reload(mxnet) test

2018-08-15 Thread GitBox
cclauss opened a new pull request #12188: [MXNET-696] Simplify the logic behind the reload(mxnet) test URL: https://github.com/apache/incubator-mxnet/pull/12188 ## Description ## Simplify the logic behind the reload(mxnet) test Implements Python porting best practice [__use featur

[GitHub] hcho3 opened a new pull request #12189: Drop dmlc-core commits that break MXNet build

2018-08-15 Thread GitBox
hcho3 opened a new pull request #12189: Drop dmlc-core commits that break MXNet build URL: https://github.com/apache/incubator-mxnet/pull/12189 ## Description ## Partially reverts apache/incubator-mxnet#12129 by dropping commits dmlc/dmlc-core#409 and dmlc/dmlc-core#399. These co

[GitHub] junrushao1994 commented on issue #12106: [MXNET-795] Fix a bug that CutSubgraph works only when each subgraph has its distinct name

2018-08-15 Thread GitBox
junrushao1994 commented on issue #12106: [MXNET-795] Fix a bug that CutSubgraph works only when each subgraph has its distinct name URL: https://github.com/apache/incubator-mxnet/pull/12106#issuecomment-413351219 @piiswrong Would you like to take a look? ---

[GitHub] thomelane opened a new pull request #12190: Updated Symbol tutorial with Gluon

2018-08-15 Thread GitBox
thomelane opened a new pull request #12190: Updated Symbol tutorial with Gluon URL: https://github.com/apache/incubator-mxnet/pull/12190 ## Description ## Added references to Gluon in the Symbol tutorial, i.e. mention that it is used after hybridization. ## Checklist ## ###

[GitHub] thomelane commented on issue #10571: Gluon not mentioned in Symbol API tutorial

2018-08-15 Thread GitBox
thomelane commented on issue #10571: Gluon not mentioned in Symbol API tutorial URL: https://github.com/apache/incubator-mxnet/issues/10571#issuecomment-413352153 Submitted pull request for updates https://github.com/apache/incubator-mxnet/pull/12190 @indhub good to close this issue now

[GitHub] cclauss opened a new pull request #12191: Define cmp() in Python 3 for line 222

2018-08-15 Thread GitBox
cclauss opened a new pull request #12191: Define cmp() in Python 3 for line 222 URL: https://github.com/apache/incubator-mxnet/pull/12191 [__cmp()__ was removed in Python 3](https://docs.python.org/3/whatsnew/3.0.html#ordering-comparisons) so this PR recreates it if required leveraging the

[GitHub] ankkhedia commented on issue #10267: Continue train in R: what is begin_round?

2018-08-15 Thread GitBox
ankkhedia commented on issue #10267: Continue train in R: what is begin_round? URL: https://github.com/apache/incubator-mxnet/issues/10267#issuecomment-413352500 Hi @NiklasDL Thanks for trying out MXNetR. I understand your confusion regarding begin.round and num.round. As @some-guy1 sugge

[GitHub] ankkhedia commented on issue #12032: mxnet

2018-08-15 Thread GitBox
ankkhedia commented on issue #12032: mxnet URL: https://github.com/apache/incubator-mxnet/issues/12032#issuecomment-413354093 @nswamy @sandeep-krishnamurthy Could you please close this issue due to inactivity as the issue is not reproducible. @gulinlin Please feel free to reopen th

[GitHub] cclauss commented on issue #8270: 10 Undefined names in Python code

2018-08-15 Thread GitBox
cclauss commented on issue #8270: 10 Undefined names in Python code URL: https://github.com/apache/incubator-mxnet/issues/8270#issuecomment-413354049 [flake8](http://flake8.pycqa.org) testing of https://github.com/apache/incubator-mxnet on Python 3.7.0 $ __flake8 . --count --select=

[GitHub] junrushao1994 opened a new pull request #12192: Fix flaky tests in control flow

2018-08-15 Thread GitBox
junrushao1994 opened a new pull request #12192: Fix flaky tests in control flow URL: https://github.com/apache/incubator-mxnet/pull/12192 ## Description ## Fix flaky tests present in #12112 . (I think it is a very tiny change, so do not have to add a JIRA-ID.) ## Checklist #

[GitHub] junrushao1994 commented on issue #12112: flaky test: test_contrib_control_flow.test_while_loop_for_foreach

2018-08-15 Thread GitBox
junrushao1994 commented on issue #12112: flaky test: test_contrib_control_flow.test_while_loop_for_foreach URL: https://github.com/apache/incubator-mxnet/issues/12112#issuecomment-413354748 See #12192 This is an automated m

[GitHub] vandanavk commented on issue #12191: [MXNET-696] Define cmp() in Python 3 for line 222

2018-08-15 Thread GitBox
vandanavk commented on issue #12191: [MXNET-696] Define cmp() in Python 3 for line 222 URL: https://github.com/apache/incubator-mxnet/pull/12191#issuecomment-413354949 @piyushghai This is an automated message from the Apache

[GitHub] thomelane commented on issue #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering ops

2018-08-15 Thread GitBox
thomelane commented on issue #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering ops URL: https://github.com/apache/incubator-mxnet/pull/11134#issuecomment-413354975 @sxjscience any chance you could add a small update to the documentation saying that the output is sorted. thank

[GitHub] cclauss edited a comment on issue #8270: 1 Syntax error and 5 undefined names in Python code

2018-08-15 Thread GitBox
cclauss edited a comment on issue #8270: 1 Syntax error and 5 undefined names in Python code URL: https://github.com/apache/incubator-mxnet/issues/8270#issuecomment-413354049 * #12191 should fix __cmp()__ * #12188 Should fix __reload()__ * https://github.com/apache/incubator-mxnet/c

[GitHub] cclauss edited a comment on issue #8270: 1 Syntax error and 5 undefined names in Python code

2018-08-15 Thread GitBox
cclauss edited a comment on issue #8270: 1 Syntax error and 5 undefined names in Python code URL: https://github.com/apache/incubator-mxnet/issues/8270#issuecomment-413354049 * #12191 should fix __cmp()__ * #12188 Should fix __reload()__ * https://github.com/apache/incubator-mxnet/c

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210419363 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ## @@ -171,8 +

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210421479 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ## @@ -136,11

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210425921 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala ##

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210426414 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala ##

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210426653 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ## @@ -228,15

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210426198 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala ##

[GitHub] nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210424754 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ## @@ -228,15

[GitHub] nswamy closed issue #12032: mxnet

2018-08-15 Thread GitBox
nswamy closed issue #12032: mxnet URL: https://github.com/apache/incubator-mxnet/issues/12032 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] anirudhacharya commented on issue #12066: Unable to library the package "mxnet" in R 3.5.1 on Mac

2018-08-15 Thread GitBox
anirudhacharya commented on issue #12066: Unable to library the package "mxnet" in R 3.5.1 on Mac URL: https://github.com/apache/incubator-mxnet/issues/12066#issuecomment-413358852 @sandeep-krishnamurthy please close this issue, it has been resolved. @Ruoyu-Qian feel free to comment

[GitHub] piyushghai commented on a change in pull request #12191: [MXNET-696] Define cmp() in Python 3 for line 222

2018-08-15 Thread GitBox
piyushghai commented on a change in pull request #12191: [MXNET-696] Define cmp() in Python 3 for line 222 URL: https://github.com/apache/incubator-mxnet/pull/12191#discussion_r210429565 ## File path: tests/nightly/model_backwards_compatibility_check/common.py ## @@ -29,6

[GitHub] piyushghai commented on issue #12191: [MXNET-696] Define cmp() in Python 3 for line 222

2018-08-15 Thread GitBox
piyushghai commented on issue #12191: [MXNET-696] Define cmp() in Python 3 for line 222 URL: https://github.com/apache/incubator-mxnet/pull/12191#issuecomment-413359018 LGTM This is an automated message from the Apache Git Se

[GitHub] thomelane commented on issue #9587: metric.F1 doc needs clarification

2018-08-15 Thread GitBox
thomelane commented on issue #9587: metric.F1 doc needs clarification URL: https://github.com/apache/incubator-mxnet/issues/9587#issuecomment-413359343 @szha @indhub the docs were updated as part of https://github.com/apache/incubator-mxnet/pull/9777 so this can be closed, thanks! --

[GitHub] eric-haibin-lin closed pull request #11983: Add handling for grad req type other than kNullOp for indices

2018-08-15 Thread GitBox
eric-haibin-lin closed pull request #11983: Add handling for grad req type other than kNullOp for indices URL: https://github.com/apache/incubator-mxnet/pull/11983 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] eric-haibin-lin commented on issue #11983: Add handling for grad req type other than kNullOp for indices

2018-08-15 Thread GitBox
eric-haibin-lin commented on issue #11983: Add handling for grad req type other than kNullOp for indices URL: https://github.com/apache/incubator-mxnet/pull/11983#issuecomment-413359552 @haojin2 could you create a github issue asking for test utils for different reqs? Thanks ---

[incubator-mxnet] branch master updated: add handling for grad req type other than kNullOp for indices (#11983)

2018-08-15 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 0455a11 add handling for grad req type

[GitHub] larroy commented on issue #12118: fix potential floating number overflow, enable float16

2018-08-15 Thread GitBox
larroy commented on issue #12118: fix potential floating number overflow, enable float16 URL: https://github.com/apache/incubator-mxnet/pull/12118#issuecomment-413360215 https://github.com/apache/incubator-mxnet/pull/11990 ---

[GitHub] larroy edited a comment on issue #12118: fix potential floating number overflow, enable float16

2018-08-15 Thread GitBox
larroy edited a comment on issue #12118: fix potential floating number overflow, enable float16 URL: https://github.com/apache/incubator-mxnet/pull/12118#issuecomment-413360215 It's broken in master https://github.com/apache/incubator-mxnet/pull/11990 --

[GitHub] thomelane commented on issue #8415: python api docs: links to external resources broken

2018-08-15 Thread GitBox
thomelane commented on issue #8415: python api docs: links to external resources broken URL: https://github.com/apache/incubator-mxnet/issues/8415#issuecomment-413360594 @aaronmarkham it looks like you've fixed these! at least the examples you've listed. going to request for close, but re

[GitHub] thomelane commented on issue #7652: Need a clear and thorough tutorial for writing custom operators in c++ with nnvm

2018-08-15 Thread GitBox
thomelane commented on issue #7652: Need a clear and thorough tutorial for writing custom operators in c++ with nnvm URL: https://github.com/apache/incubator-mxnet/issues/7652#issuecomment-413361442 @sandeep-krishnamurthy @yzhliu this issue was resolved as part of https://github.com/apach

[GitHub] apeforest closed pull request #12175: Update codeowner

2018-08-15 Thread GitBox
apeforest closed pull request #12175: Update codeowner URL: https://github.com/apache/incubator-mxnet/pull/12175 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (f

[GitHub] apeforest opened a new pull request #12193: Fix broken anchor in doc

2018-08-15 Thread GitBox
apeforest opened a new pull request #12193: Fix broken anchor in doc URL: https://github.com/apache/incubator-mxnet/pull/12193 ## Description ## Fix broken anchor in doc. This is an automated message from the Apache Git

[GitHub] eric-haibin-lin commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup

2018-08-15 Thread GitBox
eric-haibin-lin commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup URL: https://github.com/apache/incubator-mxnet/pull/11234#discussion_r210432881 ## File path: python/mxnet/lr_scheduler.py ## @@ -29,8 +30,31 @@ class LRSched

[GitHub] piiswrong commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup

2018-08-15 Thread GitBox
piiswrong commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup URL: https://github.com/apache/incubator-mxnet/pull/11234#discussion_r210433767 ## File path: python/mxnet/lr_scheduler.py ## @@ -138,33 +171,73 @@ def __call__(sel

[GitHub] azai91 commented on issue #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-15 Thread GitBox
azai91 commented on issue #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#issuecomment-413364085 @pengzhao-intel I am running to an issue with the LRN backwards operation. The results are different if we run the operation wi

[GitHub] thomelane commented on issue #7539: Change font from comic sans in diagrams

2018-08-15 Thread GitBox
thomelane commented on issue #7539: Change font from comic sans in diagrams URL: https://github.com/apache/incubator-mxnet/issues/7539#issuecomment-413366753 @altosaar this was most likely a design choice to avoid discrimination against dyslexics. As a British Dyslexic myself I fully su

[GitHub] lanking520 commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
lanking520 commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210436756 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala ##

[GitHub] hcho3 commented on issue #11209: [MXNET-536] implement var/std operators

2018-08-15 Thread GitBox
hcho3 commented on issue #11209: [MXNET-536] implement var/std operators URL: https://github.com/apache/incubator-mxnet/pull/11209#issuecomment-413367709 @piiswrong I added tests for axis. This is an automated message from the

[GitHub] piiswrong closed pull request #11248: improve memory allocation error

2018-08-15 Thread GitBox
piiswrong closed pull request #11248: improve memory allocation error URL: https://github.com/apache/incubator-mxnet/pull/11248 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] piiswrong closed pull request #11472: Add mirror to Gluon

2018-08-15 Thread GitBox
piiswrong closed pull request #11472: Add mirror to Gluon URL: https://github.com/apache/incubator-mxnet/pull/11472 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] piiswrong closed pull request #11254: add blocklist

2018-08-15 Thread GitBox
piiswrong closed pull request #11254: add blocklist URL: https://github.com/apache/incubator-mxnet/pull/11254 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] piiswrong closed pull request #11953: do not regularize beta and bias

2018-08-15 Thread GitBox
piiswrong closed pull request #11953: do not regularize beta and bias URL: https://github.com/apache/incubator-mxnet/pull/11953 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] safrooze commented on issue #11913: Unexpectedly poor copy() performance

2018-08-15 Thread GitBox
safrooze commented on issue #11913: Unexpectedly poor copy() performance URL: https://github.com/apache/incubator-mxnet/issues/11913#issuecomment-413372266 @wkcn You are correct that the evaluation is lazy, but calling nd.waitall() does indeed wait for everything to finish, so calling nd.w

[GitHub] azai91 commented on issue #12058: MKLDNN can be turned off with env var

2018-08-15 Thread GitBox
azai91 commented on issue #12058: MKLDNN can be turned off with env var URL: https://github.com/apache/incubator-mxnet/pull/12058#issuecomment-413372396 ``` ubuntu@ip-172-31-11-93:~/incubator-mxnet-2/example/image-classification$ python benchmark_score.py Assertion failure at kmp_runt

[GitHub] safrooze edited a comment on issue #11913: Unexpectedly poor copy() performance

2018-08-15 Thread GitBox
safrooze edited a comment on issue #11913: Unexpectedly poor copy() performance URL: https://github.com/apache/incubator-mxnet/issues/11913#issuecomment-413372266 @wkcn You are correct that the evaluation is lazy, but calling nd.waitall() does indeed wait for everything to finish, so calli

[GitHub] azai91 commented on issue #12058: MKLDNN can be turned off with env var

2018-08-15 Thread GitBox
azai91 commented on issue #12058: MKLDNN can be turned off with env var URL: https://github.com/apache/incubator-mxnet/pull/12058#issuecomment-413372544 moved the log into the fallback code so it should work for gluon / imperative as well. that being said, we should probably clean up the lo

[GitHub] azai91 commented on issue #12058: MKLDNN can be turned off with env var

2018-08-15 Thread GitBox
azai91 commented on issue #12058: MKLDNN can be turned off with env var URL: https://github.com/apache/incubator-mxnet/pull/12058#issuecomment-413372561 @eric-haibin-lin <3 This is an automated message from the Apache Git Serv

[GitHub] thomelane commented on issue #8969: A couple of issues in benchmark_score.py

2018-08-15 Thread GitBox
thomelane commented on issue #8969: A couple of issues in benchmark_score.py URL: https://github.com/apache/incubator-mxnet/issues/8969#issuecomment-413373799 @indhub @yzhliu would appreciate if you could close this issue, many thanks! --

[GitHub] thomelane commented on issue #8969: A couple of issues in benchmark_score.py

2018-08-15 Thread GitBox
thomelane commented on issue #8969: A couple of issues in benchmark_score.py URL: https://github.com/apache/incubator-mxnet/issues/8969#issuecomment-413373776 @juliensimon just tested this out and I don't hit either of these issues. With regards to Issue 1, there is logic to extract

[GitHub] yzhliu closed issue #7539: Change font from comic sans in diagrams

2018-08-15 Thread GitBox
yzhliu closed issue #7539: Change font from comic sans in diagrams URL: https://github.com/apache/incubator-mxnet/issues/7539 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-mxnet] branch master updated: Fix a minor bug in deformable_im2col.cuh (#12060)

2018-08-15 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 0fbdff8 Fix a minor bug in deformable_im

[GitHub] piiswrong closed pull request #12060: Fix a minor bug in deformable_im2col.cuh

2018-08-15 Thread GitBox
piiswrong closed pull request #12060: Fix a minor bug in deformable_im2col.cuh URL: https://github.com/apache/incubator-mxnet/pull/12060 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] thomelane commented on issue #8165: missing arguments in SSD example train.py

2018-08-15 Thread GitBox
thomelane commented on issue #8165: missing arguments in SSD example train.py URL: https://github.com/apache/incubator-mxnet/issues/8165#issuecomment-413375827 @caiqi I realise this is from a long time ago, but were you able to provide a few more details so we can check whether this is sti

[GitHub] sandeep-krishnamurthy commented on a change in pull request #12090: [MXNET-791] Pick with negative indices

2018-08-15 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #12090: [MXNET-791] Pick with negative indices URL: https://github.com/apache/incubator-mxnet/pull/12090#discussion_r210443051 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -112,6 +114,14 @@ struct

[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter

2018-08-15 Thread GitBox
stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210444554 ## File path: python/mxnet/image/image.py ## @@ -1207,8 +1230,25 @@ def next(self):

[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter

2018-08-15 Thread GitBox
stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210444554 ## File path: python/mxnet/image/image.py ## @@ -1207,8 +1230,25 @@ def next(self):

[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter

2018-08-15 Thread GitBox
stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210444730 ## File path: python/mxnet/image/image.py ## @@ -1207,8 +1230,25 @@ def next(self):

[GitHub] haojin2 commented on issue #12090: [MXNET-791] Pick with negative indices

2018-08-15 Thread GitBox
haojin2 commented on issue #12090: [MXNET-791] Pick with negative indices URL: https://github.com/apache/incubator-mxnet/pull/12090#issuecomment-413377269 Please rebase with the latest master, then do a `git submodule update --init --recursive`, then do a `git push --force origin ` ---

[GitHub] junrushao1994 commented on issue #12192: Fix flaky tests in control flow

2018-08-15 Thread GitBox
junrushao1994 commented on issue #12192: Fix flaky tests in control flow URL: https://github.com/apache/incubator-mxnet/pull/12192#issuecomment-413378255 @haojin2 It is very helpful of you! (especially when I have no access to ec2) ---

[GitHub] thomelane commented on issue #7873: Issues on training CIFAR10 with official example code

2018-08-15 Thread GitBox
thomelane commented on issue #7873: Issues on training CIFAR10 with official example code URL: https://github.com/apache/incubator-mxnet/issues/7873#issuecomment-413378360 @stoneyang I couldn't replicate this issue unfortunately. Can you still reproduce this issue? It doesn't look like

[GitHub] lanking520 commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

2018-08-15 Thread GitBox
lanking520 commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210445749 ## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ## @@ -228

[GitHub] junrushao1994 closed issue #11599: Autograd fails when using `take` operator repeatedly

2018-08-15 Thread GitBox
junrushao1994 closed issue #11599: Autograd fails when using `take` operator repeatedly URL: https://github.com/apache/incubator-mxnet/issues/11599 This is an automated message from the Apache Git Service. To respond to the

[GitHub] junrushao1994 commented on issue #11599: Autograd fails when using `take` operator repeatedly

2018-08-15 Thread GitBox
junrushao1994 commented on issue #11599: Autograd fails when using `take` operator repeatedly URL: https://github.com/apache/incubator-mxnet/issues/11599#issuecomment-413378649 Closed since #11983 is merged. Thank you @haojin2! -

[GitHub] haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py

2018-08-15 Thread GitBox
haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py URL: https://github.com/apache/incubator-mxnet/pull/12194 ## Description ## Fix for #12179. ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR)

[GitHub] haojin2 commented on issue #12179: Spelling mistake in "mxnet/symbol/image.py" in which "gen_image" is written to be "gen_iamge"

2018-08-15 Thread GitBox
haojin2 commented on issue #12179: Spelling mistake in "mxnet/symbol/image.py" in which "gen_image" is written to be "gen_iamge" URL: https://github.com/apache/incubator-mxnet/issues/12179#issuecomment-413379540 It's a pure typo, see the ndarray counterpart: https://github.com/apache/incu

[GitHub] haojin2 commented on issue #11990: [MXNET-744] Docs build tools update

2018-08-15 Thread GitBox
haojin2 commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413380408 This commit is causing problems on CI: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-12188/1/p

[GitHub] haojin2 commented on issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11716#issuecomment-413381383 @sandeep-krishnamurthy Related fix is merged, should be good to close. --

[GitHub] haojin2 commented on issue #11718: test_operator.test_laop has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11718: test_operator.test_laop has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11718#issuecomment-413381475 @sandeep-krishnamurthy Related fix is merged, should be good to close. -

[GitHub] haojin2 commented on issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11692#issuecomment-413381573 @sandeep-krishnamurthy Related fix is merged, should be good to close. --

[GitHub] haojin2 commented on issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11691#issuecomment-413381613 @sandeep-krishnamurthy Related fix is merged, should be good to close. -

[GitHub] haojin2 commented on issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11697#issuecomment-413381713 @sandeep-krishnamurthy Related PR is merged, should be good to close. ---

[GitHub] haojin2 commented on issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11698#issuecomment-413381757 @sandeep-krishnamurthy Related PR is merged, should be good to close. ---

[GitHub] haojin2 commented on issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11694#issuecomment-413382053 @sandeep-krishnamurthy Related PR is merged, should be good to close.

[GitHub] haojin2 commented on issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11700#issuecomment-413382080 @sandeep-krishnamurthy Related PR is merged, should be good to close.

[GitHub] haojin2 commented on issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11703#issuecomment-413382252 @sandeep-krishnamurthy Related PR is merged, should be good to close. --

[GitHub] haojin2 commented on issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11695#issuecomment-413382212 @sandeep-krishnamurthy Related PR is merged, should be good to close.

[GitHub] haojin2 commented on issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11702#issuecomment-413382228 @sandeep-krishnamurthy Related PR is merged, should be good to close.

[GitHub] haojin2 commented on issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11740#issuecomment-413382270 @sandeep-krishnamurthy Related PR is merged, should be good to close.

[GitHub] haojin2 commented on issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11704#issuecomment-413382440 @sandeep-krishnamurthy Related PR is merged, should be good to close. ---

[GitHub] haojin2 commented on issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness

2018-08-15 Thread GitBox
haojin2 commented on issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11738#issuecomment-413382532 @sandeep-krishnamurthy Related PR is merged, should be good to close. ---

<    1   2   3   >