[GitHub] s0nghuiming closed issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv

2018-12-28 Thread GitBox
s0nghuiming closed issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv URL: https://github.com/apache/incubator-mxnet/issues/13746 This is an automated message from the Apache Git Service. To respond

[GitHub] mxnet-label-bot commented on issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv

2018-12-28 Thread GitBox
mxnet-label-bot commented on issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv URL: https://github.com/apache/incubator-mxnet/issues/13746#issuecomment-450472092 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest som

[GitHub] s0nghuiming opened a new issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv

2018-12-28 Thread GitBox
s0nghuiming opened a new issue #13746: Duplicated test in test_gluon.py, test_reshape_conv_slice_conv URL: https://github.com/apache/incubator-mxnet/issues/13746 ## Description There are two duplicate name tests in test_gluon.py. Test name is test_reshape_conv_slice_conv. They have d

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-12-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e0b6fc2 Bump the publish ti

[GitHub] makefile commented on issue #8884: forward can't run parallelly using multi-gpus when custom operator using numpy

2018-12-28 Thread GitBox
makefile commented on issue #8884: forward can't run parallelly using multi-gpus when custom operator using numpy URL: https://github.com/apache/incubator-mxnet/issues/8884#issuecomment-450471793 The issue still exist in lastest version 1.3.1 or 1.5.0 in master @sxjscience @vandanavk .

[GitHub] mseth10 commented on issue #13681: Making MKL-DNN default on MXNet master

2018-12-28 Thread GitBox
mseth10 commented on issue #13681: Making MKL-DNN default on MXNet master URL: https://github.com/apache/incubator-mxnet/pull/13681#issuecomment-450469210 @azai91 I have added you as a collaborator to my mxnet repo. You should be able to re-trigger now. Sorry for the delayed reaponse. FY

[GitHub] wlbksy opened a new pull request #13745: Fix the order of error term's operands

2018-12-28 Thread GitBox
wlbksy opened a new pull request #13745: Fix the order of error term's operands URL: https://github.com/apache/incubator-mxnet/pull/13745 Error term should be "actual minus predicted". This PR should be no op, since all related error terms are either squared or transformed into absol

[GitHub] azai91 commented on issue #13681: Making MKL-DNN default on MXNet master

2018-12-28 Thread GitBox
azai91 commented on issue #13681: Making MKL-DNN default on MXNet master URL: https://github.com/apache/incubator-mxnet/pull/13681#issuecomment-450453726 that would be ideal. would be a lot cleaner to just retrigger on this PR compared with starting a new one just for one additional commit.

[GitHub] pengzhao-intel commented on issue #13681: Making MKL-DNN default on MXNet master

2018-12-28 Thread GitBox
pengzhao-intel commented on issue #13681: Making MKL-DNN default on MXNet master URL: https://github.com/apache/incubator-mxnet/pull/13681#issuecomment-450453440 @azai91 could you let @mseth10 adding you into collaborator list so that we can continue work in this PR? https://help.gi

[GitHub] azai91 commented on issue #13681: Making MKL-DNN default on MXNet master

2018-12-28 Thread GitBox
azai91 commented on issue #13681: Making MKL-DNN default on MXNet master URL: https://github.com/apache/incubator-mxnet/pull/13681#issuecomment-450453173 mseth is out for the next two weeks so I am continuing his PR on https://github.com/apache/incubator-mxnet/pull/13744. @pengzhao-intel @T

[GitHub] azai91 opened a new pull request #13744: Making MKL-DNN default on MXNet master (continue from #13681)

2018-12-28 Thread GitBox
azai91 opened a new pull request #13744: Making MKL-DNN default on MXNet master (continue from #13681) URL: https://github.com/apache/incubator-mxnet/pull/13744 ## Description ## This PR extends #13681 ## Checklist ## ### Essentials ### Please feel free to remove inapplicabl

[GitHub] pengzhao-intel commented on issue #13681: Making MKL-DNN default on MXNet master

2018-12-28 Thread GitBox
pengzhao-intel commented on issue #13681: Making MKL-DNN default on MXNet master URL: https://github.com/apache/incubator-mxnet/pull/13681#issuecomment-450452300 @mseth10 @azai91 could you rebase and pass the CI? This will be the final step before the merge:) Thanks all of your efforts.

[GitHub] azai91 opened a new issue #13743: Flaky test in windows GPU CI

2018-12-28 Thread GitBox
azai91 opened a new issue #13743: Flaky test in windows GPU CI URL: https://github.com/apache/incubator-mxnet/issues/13743 In the windows-GPU stage of the CI, different `test_random` tests fail. `test_random.test_exponential_generator` fails on commit `6a293fc` but passes after updat

[GitHub] mxnet-label-bot commented on issue #13743: Flaky test in windows GPU CI

2018-12-28 Thread GitBox
mxnet-label-bot commented on issue #13743: Flaky test in windows GPU CI URL: https://github.com/apache/incubator-mxnet/issues/13743#issuecomment-450451378 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the appropriate M

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-12-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 0192bb8 Bump the publish ti

[GitHub] ZhennanQin commented on issue #13729: [Don't merge] check CI

2018-12-28 Thread GitBox
ZhennanQin commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-450449780 @apeforest mshadow PR is created at https://github.com/dmlc/mshadow/pull/367, please help to merge it. Then I will edit this PR. Thanks. --

[GitHub] ZhennanQin commented on a change in pull request #13729: [Don't merge] check CI

2018-12-28 Thread GitBox
ZhennanQin commented on a change in pull request #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#discussion_r244435328 ## File path: src/operator/convolution_v1-inl.h ## @@ -335,10 +335,10 @@ class ConvolutionV1Op : public Operator {

[GitHub] azai91 closed pull request #13464: [WIP] Feature/mklnn default make + test on jenkins

2018-12-28 Thread GitBox
azai91 closed pull request #13464: [WIP] Feature/mklnn default make + test on jenkins URL: https://github.com/apache/incubator-mxnet/pull/13464 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] eric-haibin-lin opened a new pull request #13742: Reorder module import orders for dist-kvstore

2018-12-28 Thread GitBox
eric-haibin-lin opened a new pull request #13742: Reorder module import orders for dist-kvstore URL: https://github.com/apache/incubator-mxnet/pull/13742 ## Description ## For distributed training, a new process is launched when importing the `kvstore_server` module. This should be impo

[GitHub] sandeep-krishnamurthy commented on issue #13717: ONNX import: Hardmax

2018-12-28 Thread GitBox
sandeep-krishnamurthy commented on issue #13717: ONNX import: Hardmax URL: https://github.com/apache/incubator-mxnet/pull/13717#issuecomment-450424250 @vandanavk - Can you please rebase and we are ready to go here This is an a

[incubator-mxnet] branch master updated: ONNX test code cleanup - part 2 (#13738)

2018-12-28 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 2f202af ONNX test code cleanup - part 2 (

[GitHub] sandeep-krishnamurthy closed pull request #13738: ONNX test code cleanup - part 2

2018-12-28 Thread GitBox
sandeep-krishnamurthy closed pull request #13738: ONNX test code cleanup - part 2 URL: https://github.com/apache/incubator-mxnet/pull/13738 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sandeep-krishnamurthy closed pull request #13654: ONNX import/export: Add missing tests, ONNX export: LogSoftMax

2018-12-28 Thread GitBox
sandeep-krishnamurthy closed pull request #13654: ONNX import/export: Add missing tests, ONNX export: LogSoftMax URL: https://github.com/apache/incubator-mxnet/pull/13654 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for th

[incubator-mxnet] branch master updated (116d01e -> be3d945)

2018-12-28 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 116d01e AdamW operator (Fixing Weight Decay Regularization in Adam) (#13728) add be3d945 ONNX import/ex

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-12-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 56b2791 Bump the publish ti

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-12-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 20307d8 Bump the publish ti

[GitHub] apeforest commented on issue #12440: Add stable nrm2 for L2 normalization

2018-12-28 Thread GitBox
apeforest commented on issue #12440: Add stable nrm2 for L2 normalization URL: https://github.com/apache/incubator-mxnet/pull/12440#issuecomment-450400255 @ZhennanQin Could you please help to review this PR? Thanks! This is an

[GitHub] apeforest commented on issue #13729: [Don't merge] check CI

2018-12-28 Thread GitBox
apeforest commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-450399438 LGTM, thanks a lot for your help. Please update the PR title and description when it's ready for review. Thanks -

[GitHub] apeforest commented on a change in pull request #13729: [Don't merge] check CI

2018-12-28 Thread GitBox
apeforest commented on a change in pull request #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#discussion_r244372724 ## File path: src/operator/convolution_v1-inl.h ## @@ -335,10 +335,10 @@ class ConvolutionV1Op : public Operator {

[GitHub] vandanavk commented on issue #12205: Lint errors in examples

2018-12-28 Thread GitBox
vandanavk commented on issue #12205: Lint errors in examples URL: https://github.com/apache/incubator-mxnet/issues/12205#issuecomment-450383951 @cchung100m thanks for looking into this! Could you open a PR for review on https://github.com/apache/incubator-mxnet? Everyone in the communit

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244340245 ## File path: src/operator/nn/mkldnn/mkldnn_slice-inl.h ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341288 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -829,6 +809,31 @@ void SliceOpForward(const nnvm::NodeAttrs& a

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341735 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -829,6 +809,31 @@ void SliceOpForward(const nnvm::NodeAttrs& a

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341140 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -432,7 +420,16 @@ inline bool SliceForwardInferStorageType(con

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-12-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 5335fa4 Bump the publish ti

[GitHub] soeque1 commented on a change in pull request #13647: Update lip reading example

2018-12-28 Thread GitBox
soeque1 commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r244285330 ## File path: example/gluon/lipnet/LICENSE ## @@ -0,0 +1,21 @@ +MIT License Review comment: Remove inapprop

[GitHub] soeque1 commented on a change in pull request #13647: Update lip reading example

2018-12-28 Thread GitBox
soeque1 commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r244285130 ## File path: example/gluon/lipnet/.gitignore ## @@ -0,0 +1,106 @@ +# Byte-compiled / optimized / DLL files Re

[GitHub] cchung100m commented on issue #12205: Lint errors in examples

2018-12-28 Thread GitBox
cchung100m commented on issue #12205: Lint errors in examples URL: https://github.com/apache/incubator-mxnet/issues/12205#issuecomment-450320991 Hi @vandanavk , Sorry for the late reply. I have been working on this issue very hard in the past month, and I solved most reported

[GitHub] aaronmarkham commented on issue #13708: Fixing a symlink issue with R install

2018-12-28 Thread GitBox
aaronmarkham commented on issue #13708: Fixing a symlink issue with R install URL: https://github.com/apache/incubator-mxnet/pull/13708#issuecomment-450316134 > @aaronmarkham you may want to merge this one... @lupesko Can you check the response regarding targeting a specific version?