[GitHub] IvyGongoogle commented on issue #14159: how to infer using fp16 for c++ api

2019-02-14 Thread GitBox
IvyGongoogle commented on issue #14159: how to infer using fp16 for c++ api URL: https://github.com/apache/incubator-mxnet/issues/14159#issuecomment-463942859 I use

[GitHub] yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463932903 Usually using `thread_local` rand generator is not a good idea, not only in the sense of system design, but it could be

[GitHub] yzhliu commented on a change in pull request #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu commented on a change in pull request #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#discussion_r257130502 ## File path: src/operator/rnn_impl.h ## @@ -176,13 +176,17 @@ void LstmForwardTraining(DType*

[GitHub] arcadiaphy edited a comment on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
arcadiaphy edited a comment on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463937133 @stephenrawls Thanks for mentioning related issues, they are all singleton destructing problems. Crash

[GitHub] arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463937133 Thanks for mentioning related issues, they are all singleton destructing problems. Crash happens when accessing

[GitHub] lanking520 commented on issue #14141: [v1.4.x] Update MKL-DNN to fix the OSX build issue

2019-02-14 Thread GitBox
lanking520 commented on issue #14141: [v1.4.x] Update MKL-DNN to fix the OSX build issue URL: https://github.com/apache/incubator-mxnet/pull/14141#issuecomment-463936741 @TaoLv Contribute back to master? This is an automated

[GitHub] yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463932903 Usually using `thread_local` rand generator is not a good idea, not only in the sense of system design, but it could be

[GitHub] yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463932903 Usually using `thread_local` rand generator is not a good idea, not only in the sense of system design, but it could be

[GitHub] yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu edited a comment on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463932903 Usually using `thread_local` rand generator is not a good idea, not only in the sense of system design, but it could be

[GitHub] yzhliu commented on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu commented on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463932903 Usually using `thread_local` rand generator is not a good idea, not only in the sense of system design, but it could be invalid.

[GitHub] lanking520 commented on issue #14168: Fixes spelling

2019-02-14 Thread GitBox
lanking520 commented on issue #14168: Fixes spelling URL: https://github.com/apache/incubator-mxnet/pull/14168#issuecomment-463932480 Looks like a random crash, restart the test to see if it is reproducible This is an

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-02-14 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 6cc0265 Bump the publish

[GitHub] stephenrawls commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
stephenrawls commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463931063 I see, thanks for background. I didn't look closely so just assumed it was about GPU memory. Re: "I

[GitHub] yzhliu commented on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
yzhliu commented on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463926812 @lebeg Can we port it to https://github.com/apache/incubator-mxnet/blob/master/include/mxnet/random_generator.h ? It is designed

[GitHub] arcadiaphy edited a comment on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
arcadiaphy edited a comment on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463925092 @stephenrawls The object pool is used to quickly allocate variables when threaded engine schedules

[GitHub] arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463925092 @stephenrawls The object pool is used to quickly allocate variables when threaded engine schedules computing

[GitHub] eric-haibin-lin commented on issue #14159: how to infer using fp16 for c++ api

2019-02-14 Thread GitBox
eric-haibin-lin commented on issue #14159: how to infer using fp16 for c++ api URL: https://github.com/apache/incubator-mxnet/issues/14159#issuecomment-463923202 @leleamol This is an automated message from the Apache Git

[GitHub] eric-haibin-lin commented on a change in pull request #14173: [WIP] MXNet AMP (automatic mixed precision)

2019-02-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #14173: [WIP] MXNet AMP (automatic mixed precision) URL: https://github.com/apache/incubator-mxnet/pull/14173#discussion_r257116232 ## File path: .gitmodules ## @@ -25,7 +25,7 @@ url =

[GitHub] eric-haibin-lin commented on a change in pull request #14153: Fix shape inference pass

2019-02-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#discussion_r257115789 ## File path: src/executor/infer_graph_attr_pass.cc ## @@ -282,26 +285,28 @@ nnvm::Graph

[GitHub] TaoLv commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
TaoLv commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257109238 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -104,7 +104,8

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104571 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -104,7 +104,8

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104385 ## File path: src/operator/nn/cudnn/cudnn_pooling-inl.h ## @@ -167,102 +169,215

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104440 ## File path: src/operator/nn/cudnn/cudnn_pooling-inl.h ## @@ -81,7 +81,8 @@

[GitHub] stephenrawls commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
stephenrawls commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463902821 @arcadiaphy I'm relatively new to the code base so take this with a grain of salt, but my guess is the

[GitHub] ptrendx commented on a change in pull request #14153: Fix shape inference pass

2019-02-14 Thread GitBox
ptrendx commented on a change in pull request #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#discussion_r257101056 ## File path: src/executor/infer_graph_attr_pass.cc ## @@ -282,26 +285,28 @@ nnvm::Graph InferAttr(nnvm::Graph &,

[GitHub] ChaiBapchya commented on issue #14174: unix cpu Static build CPU 14.04 Scala

2019-02-14 Thread GitBox
ChaiBapchya commented on issue #14174: unix cpu Static build CPU 14.04 Scala URL: https://github.com/apache/incubator-mxnet/issues/14174#issuecomment-463901757 @mxnet-label-bot add [Scala, Build] This is an automated message

[GitHub] mxnet-label-bot commented on issue #14174: unix cpu Static build CPU 14.04 Scala

2019-02-14 Thread GitBox
mxnet-label-bot commented on issue #14174: unix cpu Static build CPU 14.04 Scala URL: https://github.com/apache/incubator-mxnet/issues/14174#issuecomment-463901218 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the

[GitHub] IvyGongoogle commented on issue #14159: how to infer using fp16 for c++ api

2019-02-14 Thread GitBox
IvyGongoogle commented on issue #14159: how to infer using fp16 for c++ api URL: https://github.com/apache/incubator-mxnet/issues/14159#issuecomment-463901098 @lanking520 I use python to train a mxnet model (such as resnet-50 ) with `--dtype=float16`,but I want to using C++ api to infer

[GitHub] ChaiBapchya opened a new issue #14174: unix cpu Static build CPU 14.04 Scala

2019-02-14 Thread GitBox
ChaiBapchya opened a new issue #14174: unix cpu Static build CPU 14.04 Scala URL: https://github.com/apache/incubator-mxnet/issues/14174 In an unrelated PR https://github.com/apache/incubator-mxnet/pull/14168 (fixes spelling), Unix CPU in CI failed for the test - Static build CPU 14.04

[GitHub] nchafni commented on issue #10076: Build error w/ TVM in NNVM.

2019-02-14 Thread GitBox
nchafni commented on issue #10076: Build error w/ TVM in NNVM. URL: https://github.com/apache/incubator-mxnet/issues/10076#issuecomment-463900930 hitting this error as well, git submodule update --init --recursive doesn't work for me, has this been solved?

[GitHub] ptrendx opened a new pull request #14173: [WIP] MXNet AMP (automatic mixed precision)

2019-02-14 Thread GitBox
ptrendx opened a new pull request #14173: [WIP] MXNet AMP (automatic mixed precision) URL: https://github.com/apache/incubator-mxnet/pull/14173 ## Description ## Whis is a Work in Progress PR for AMP (automatic mixed precision) support for MXNet, similar to pyTorch version found in

[GitHub] arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2019-02-14 Thread GitBox
arcadiaphy commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-463896662 @KellenSunderland I found the memory leaks in ASAN reports of image classification example mainly come from

[GitHub] DickJC123 commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
DickJC123 commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257089824 ## File path: python/mxnet/gluon/nn/conv_layers.py ## @@ -716,7 +718,8 @@

[GitHub] stu1130 closed pull request #13858: implement random resize crop as operator

2019-02-14 Thread GitBox
stu1130 closed pull request #13858: implement random resize crop as operator URL: https://github.com/apache/incubator-mxnet/pull/13858 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] stu1130 closed pull request #13679: add crop gluon transform

2019-02-14 Thread GitBox
stu1130 closed pull request #13679: add crop gluon transform URL: https://github.com/apache/incubator-mxnet/pull/13679 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] stu1130 commented on issue #13858: implement random resize crop as operator

2019-02-14 Thread GitBox
stu1130 commented on issue #13858: implement random resize crop as operator URL: https://github.com/apache/incubator-mxnet/pull/13858#issuecomment-463880409 @ankkhedia @zhreshold it's not ready to review, close it for now

[GitHub] stu1130 closed pull request #13694: make center_crop as operator

2019-02-14 Thread GitBox
stu1130 closed pull request #13694: make center_crop as operator URL: https://github.com/apache/incubator-mxnet/pull/13694 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-02-14 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new f30e5de Bump the publish

[GitHub] BigBigWolf-AI commented on issue #14109: mxnet doesn't have instructions for verifying installation (was: mxnet安装完成后没有验证是否安装成功的过程)

2019-02-14 Thread GitBox
BigBigWolf-AI commented on issue #14109: mxnet doesn't have instructions for verifying installation (was: mxnet安装完成后没有验证是否安装成功的过程) URL: https://github.com/apache/incubator-mxnet/issues/14109#issuecomment-463875486 > Translation for @BigBigWolf-AI's request: > Operating system: Windows

[GitHub] BigBigWolf-AI commented on issue #14109: mxnet doesn't have instructions for verifying installation (was: mxnet安装完成后没有验证是否安装成功的过程)

2019-02-14 Thread GitBox
BigBigWolf-AI commented on issue #14109: mxnet doesn't have instructions for verifying installation (was: mxnet安装完成后没有验证是否安装成功的过程) URL: https://github.com/apache/incubator-mxnet/issues/14109#issuecomment-463874963 > @BigBigWolf-AI Please refer to [Validate your MXNet

[GitHub] lanking520 commented on issue #14159: how to infer using fp16 for c++ api

2019-02-14 Thread GitBox
lanking520 commented on issue #14159: how to infer using fp16 for c++ api URL: https://github.com/apache/incubator-mxnet/issues/14159#issuecomment-463872462 Grab someone may know about C++: @leleamol here This is an

[GitHub] anirudhacharya commented on issue #13960: Use In-place operator to prevent memory spikes in optimizer updates

2019-02-14 Thread GitBox
anirudhacharya commented on issue #13960: Use In-place operator to prevent memory spikes in optimizer updates URL: https://github.com/apache/incubator-mxnet/pull/13960#issuecomment-463871683 Thanks for merging and thanks to @szha for the tip here -

[GitHub] eric-haibin-lin commented on issue #14171: multi-precision AdamW update op

2019-02-14 Thread GitBox
eric-haibin-lin commented on issue #14171: multi-precision AdamW update op URL: https://github.com/apache/incubator-mxnet/pull/14171#issuecomment-463871681 @ptrendx you might be interested This is an automated message from

[incubator-mxnet] branch master updated: Fix jar path and add missing ones for spark jobs (#14020)

2019-02-14 Thread lanking
This is an automated email from the ASF dual-hosted git repository. lanking pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 8416c56 Fix jar path and add missing

[GitHub] lanking520 merged pull request #14020: Fix jar path and add missing ones for spark jobs

2019-02-14 Thread GitBox
lanking520 merged pull request #14020: Fix jar path and add missing ones for spark jobs URL: https://github.com/apache/incubator-mxnet/pull/14020 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ZhennanQin commented on issue #13986: [Quantization]'Symbol' object has no attribute 'get_backend_symbol'

2019-02-14 Thread GitBox
ZhennanQin commented on issue #13986: [Quantization]'Symbol' object has no attribute 'get_backend_symbol' URL: https://github.com/apache/incubator-mxnet/issues/13986#issuecomment-463870422 I think it's an environment issue that you're mixed using old version of mxnet with recent

[GitHub] eric-haibin-lin commented on a change in pull request #14153: Fix shape inference pass

2019-02-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#discussion_r257076083 ## File path: src/executor/infer_graph_attr_pass.cc ## @@ -282,26 +285,28 @@ nnvm::Graph

[GitHub] eric-haibin-lin commented on issue #13986: [Quantization]'Symbol' object has no attribute 'get_backend_symbol'

2019-02-14 Thread GitBox
eric-haibin-lin commented on issue #13986: [Quantization]'Symbol' object has no attribute 'get_backend_symbol' URL: https://github.com/apache/incubator-mxnet/issues/13986#issuecomment-463868561 @ZhennanQin @taolv This

[GitHub] eric-haibin-lin merged pull request #13960: Use In-place operator to prevent memory spikes in optimizer updates

2019-02-14 Thread GitBox
eric-haibin-lin merged pull request #13960: Use In-place operator to prevent memory spikes in optimizer updates URL: https://github.com/apache/incubator-mxnet/pull/13960 This is an automated message from the Apache Git

[incubator-mxnet] branch master updated: In-place updates for Nadam, Adadelta, Adamax and SGLD (#13960)

2019-02-14 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new a4e249b In-place updates for Nadam,

[GitHub] eric-haibin-lin commented on issue #13975: Fix quote on LBSGD docs

2019-02-14 Thread GitBox
eric-haibin-lin commented on issue #13975: Fix quote on LBSGD docs URL: https://github.com/apache/incubator-mxnet/pull/13975#issuecomment-463854365 I've updated the description. The issue is left open. This is an automated

[incubator-mxnet] branch master updated: Fix quote on LBSGD docs (#13975)

2019-02-14 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 0e08891 Fix quote on LBSGD docs

[GitHub] eric-haibin-lin merged pull request #13975: Fix quote on LBSGD docs

2019-02-14 Thread GitBox
eric-haibin-lin merged pull request #13975: Fix quote on LBSGD docs URL: https://github.com/apache/incubator-mxnet/pull/13975 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] eric-haibin-lin edited a comment on issue #14098: softmax for fp16 with fp32 accumulator

2019-02-14 Thread GitBox
eric-haibin-lin edited a comment on issue #14098: softmax for fp16 with fp32 accumulator URL: https://github.com/apache/incubator-mxnet/pull/14098#issuecomment-463852755 LGTM. @ptrendx any other concerns? Would AMP skip the cast if softmax accumulation for fp16 inputs is done in fp32?

[GitHub] eric-haibin-lin commented on issue #14098: softmax for fp16 with fp32 accumulator

2019-02-14 Thread GitBox
eric-haibin-lin commented on issue #14098: softmax for fp16 with fp32 accumulator URL: https://github.com/apache/incubator-mxnet/pull/14098#issuecomment-463852755 LGTM. @ptrendx any other concerns? This is an automated

[incubator-mxnet] branch master updated: Fixes libjpeg-turbo dependecy under Ubuntu 16.04 (#14127)

2019-02-14 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new cf46ca4 Fixes libjpeg-turbo

[GitHub] marcoabreu merged pull request #14127: Fixes libjpeg-turbo dependecy under Ubuntu 16.04

2019-02-14 Thread GitBox
marcoabreu merged pull request #14127: Fixes libjpeg-turbo dependecy under Ubuntu 16.04 URL: https://github.com/apache/incubator-mxnet/pull/14127 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ankkhedia commented on issue #14024: Julia: split symbolic-node.jl into several snippets

2019-02-14 Thread GitBox
ankkhedia commented on issue #14024: Julia: split symbolic-node.jl into several snippets URL: https://github.com/apache/incubator-mxnet/pull/14024#issuecomment-463851741 @marcoabreu Could you please review this PR? This is

[GitHub] ankkhedia commented on issue #14020: Fix jar path and add missing ones for spark jobs

2019-02-14 Thread GitBox
ankkhedia commented on issue #14020: Fix jar path and add missing ones for spark jobs URL: https://github.com/apache/incubator-mxnet/pull/14020#issuecomment-463851606 @lanking520 ping for review/merge. This is an automated

[incubator-mxnet] branch v1.3.x updated: Fixes installation nightly test by filtering out the git commands (#14145)

2019-02-14 Thread srochel
This is an automated email from the ASF dual-hosted git repository. srochel pushed a commit to branch v1.3.x in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.3.x by this push: new 87eb1ad Fixes installation nightly

[GitHub] srochel merged pull request #14145: v1.3.x - backports nightly test fix

2019-02-14 Thread GitBox
srochel merged pull request #14145: v1.3.x - backports nightly test fix URL: https://github.com/apache/incubator-mxnet/pull/14145 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] ankkhedia commented on issue #13975: Fix quote on LBSGD docs

2019-02-14 Thread GitBox
ankkhedia commented on issue #13975: Fix quote on LBSGD docs URL: https://github.com/apache/incubator-mxnet/pull/13975#issuecomment-463851214 @ThomasDelteil Could you please take a look into comments by @Roshrini This is an

[GitHub] vandanavk commented on issue #7853: ndarray.choose_element_0index not differentiable / bug in gradients after slicing?

2019-02-14 Thread GitBox
vandanavk commented on issue #7853: ndarray.choose_element_0index not differentiable / bug in gradients after slicing? URL: https://github.com/apache/incubator-mxnet/issues/7853#issuecomment-463850347 Error on MXNet v1.5 (built from source). Tested on OSX ```

[GitHub] ankkhedia commented on issue #13960: Use In-place operator to prevent memory spikes in optimizer updates

2019-02-14 Thread GitBox
ankkhedia commented on issue #13960: Use In-place operator to prevent memory spikes in optimizer updates URL: https://github.com/apache/incubator-mxnet/pull/13960#issuecomment-463850355 @sandeep-krishnamurthy Could you please review/merge this PR?

[GitHub] ankkhedia commented on issue #13955: adding the gluon implementation of deformable convolution

2019-02-14 Thread GitBox
ankkhedia commented on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-463848823 @suyz526 Could you please look into the review comments above?

[GitHub] ankkhedia commented on issue #13938: [MXNET-1291] solve pylint errors in examples with issue no.12205

2019-02-14 Thread GitBox
ankkhedia commented on issue #13938: [MXNET-1291] solve pylint errors in examples with issue no.12205 URL: https://github.com/apache/incubator-mxnet/pull/13938#issuecomment-463848237 @cchung100m Could you please look into the comments above?

[incubator-mxnet] branch master updated: Add pixelshuffle layers (#13571)

2019-02-14 Thread thomasdelteil
This is an automated email from the ASF dual-hosted git repository. thomasdelteil pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new de5cda2 Add pixelshuffle

[GitHub] ankkhedia commented on issue #13930: Add batchify transformer to help end to end models

2019-02-14 Thread GitBox
ankkhedia commented on issue #13930: Add batchify transformer to help end to end models URL: https://github.com/apache/incubator-mxnet/pull/13930#issuecomment-463848097 @sandeep-krishnamurthy Could you please look into the review comments above?

[GitHub] ThomasDelteil closed issue #13548: [Feature Request / Proposal] Pixel shuffle layer

2019-02-14 Thread GitBox
ThomasDelteil closed issue #13548: [Feature Request / Proposal] Pixel shuffle layer URL: https://github.com/apache/incubator-mxnet/issues/13548 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ThomasDelteil merged pull request #13571: Add pixelshuffle layers

2019-02-14 Thread GitBox
ThomasDelteil merged pull request #13571: Add pixelshuffle layers URL: https://github.com/apache/incubator-mxnet/pull/13571 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ankkhedia commented on issue #13906: [MXNET-703] Update onnx-tensorrt for int8/fp16 support

2019-02-14 Thread GitBox
ankkhedia commented on issue #13906: [MXNET-703] Update onnx-tensorrt for int8/fp16 support URL: https://github.com/apache/incubator-mxnet/pull/13906#issuecomment-463847839 @Roshrini @vandanavk ping for review! This is an

[GitHub] leleamol commented on issue #9857: C++ test Core dump DROPOUT_PERF.TimingGPU

2019-02-14 Thread GitBox
leleamol commented on issue #9857: C++ test Core dump DROPOUT_PERF.TimingGPU URL: https://github.com/apache/incubator-mxnet/issues/9857#issuecomment-463847789 The issue is not related to C++ API. Removing the C++ label. @mxnet-label-bot remove [C++]

[GitHub] ankkhedia commented on issue #13858: implement random resize crop as operator

2019-02-14 Thread GitBox
ankkhedia commented on issue #13858: implement random resize crop as operator URL: https://github.com/apache/incubator-mxnet/pull/13858#issuecomment-463847361 @stu1130 Could you look into review comments? @zhreshold ping for review!

[GitHub] ankkhedia commented on issue #13643: Remove mklml pre-install in ci

2019-02-14 Thread GitBox
ankkhedia commented on issue #13643: Remove mklml pre-install in ci URL: https://github.com/apache/incubator-mxnet/pull/13643#issuecomment-463847196 @xinyu-intel Could you please look into the review comments? This is an

[GitHub] ankkhedia commented on issue #13816: Add default parameters for Scala NDArray.arange

2019-02-14 Thread GitBox
ankkhedia commented on issue #13816: Add default parameters for Scala NDArray.arange URL: https://github.com/apache/incubator-mxnet/pull/13816#issuecomment-463846091 @szha Could you please look into the updated PR and review/merge?

[GitHub] lebeg closed pull request #13689: (WIP): Jetson build with CMake and TensorRT

2019-02-14 Thread GitBox
lebeg closed pull request #13689: (WIP): Jetson build with CMake and TensorRT URL: https://github.com/apache/incubator-mxnet/pull/13689 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ankkhedia commented on issue #13763: [contrib][op] fix MultiBoxPrior confusing results if first ratio is not 1.0

2019-02-14 Thread GitBox
ankkhedia commented on issue #13763: [contrib][op] fix MultiBoxPrior confusing results if first ratio is not 1.0 URL: https://github.com/apache/incubator-mxnet/pull/13763#issuecomment-463843348 @eric-haibin-lin ping for review! @zhreshold Could you look into above comments?

[GitHub] simonmaurer commented on issue #14159: how to infer using fp16 for c++ api

2019-02-14 Thread GitBox
simonmaurer commented on issue #14159: how to infer using fp16 for c++ api URL: https://github.com/apache/incubator-mxnet/issues/14159#issuecomment-463842917 interested as well. @lanking520 so what you're saying is that C++ inference using float16 is not yet possible? is that also true

[GitHub] ankkhedia commented on issue #13715: Add C++ Predictor class for inference

2019-02-14 Thread GitBox
ankkhedia commented on issue #13715: Add C++ Predictor class for inference URL: https://github.com/apache/incubator-mxnet/pull/13715#issuecomment-463842488 @stu1130 @ChaiBapchya It seems that your comments has been addressed. Could you review it again?

[GitHub] ankkhedia commented on issue #13694: make center_crop as operator

2019-02-14 Thread GitBox
ankkhedia commented on issue #13694: make center_crop as operator URL: https://github.com/apache/incubator-mxnet/pull/13694#issuecomment-463841738 @stu1130 Did you get a chance to revisit this PR? This is an automated message

[GitHub] ankkhedia commented on issue #13668: Update MKL-DNN to fix the Dense layer issue

2019-02-14 Thread GitBox
ankkhedia commented on issue #13668: Update MKL-DNN to fix the Dense layer issue URL: https://github.com/apache/incubator-mxnet/pull/13668#issuecomment-463841548 @zheng-da Ping for review ! This is an automated message from

[GitHub] ankkhedia commented on issue #13612: add pos_weight for SigmoidBinaryCrossEntropyLoss

2019-02-14 Thread GitBox
ankkhedia commented on issue #13612: add pos_weight for SigmoidBinaryCrossEntropyLoss URL: https://github.com/apache/incubator-mxnet/pull/13612#issuecomment-463841211 @eureka7mt Could you please look into the CI failures?

[GitHub] aaronmarkham commented on issue #13886: Fixes for wine detection tutorial

2019-02-14 Thread GitBox
aaronmarkham commented on issue #13886: Fixes for wine detection tutorial URL: https://github.com/apache/incubator-mxnet/pull/13886#issuecomment-463841154 I also just fixed the conflict from the new license header. This is an

[GitHub] ankkhedia commented on issue #13571: Add pixelshuffle layers

2019-02-14 Thread GitBox
ankkhedia commented on issue #13571: Add pixelshuffle layers URL: https://github.com/apache/incubator-mxnet/pull/13571#issuecomment-463841032 @ThomasDelteil Could you please help review/merge this PR? This is an automated

[GitHub] aaronmarkham commented on issue #13886: Fixes for wine detection tutorial

2019-02-14 Thread GitBox
aaronmarkham commented on issue #13886: Fixes for wine detection tutorial URL: https://github.com/apache/incubator-mxnet/pull/13886#issuecomment-463840898 I put the edits for MXNet installation on Raspberry Pi in this PR: #14172

[GitHub] lebeg commented on issue #6685: !!!GPU performance of Cmake built mxnet is worse than Make built one

2019-02-14 Thread GitBox
lebeg commented on issue #6685: !!!GPU performance of Cmake built mxnet is worse than Make built one URL: https://github.com/apache/incubator-mxnet/issues/6685#issuecomment-463840773 > Does openblas or MKL have impacts on GPU performance? You are right, probably not. Didn't read

[GitHub] ankkhedia commented on issue #13559: fix for opencv4

2019-02-14 Thread GitBox
ankkhedia commented on issue #13559: fix for opencv4 URL: https://github.com/apache/incubator-mxnet/pull/13559#issuecomment-463840629 @daleydeng Could you please take a look into the comments above? This is an automated

[GitHub] aaronmarkham opened a new pull request #14172: update raspberry pi install instructions

2019-02-14 Thread GitBox
aaronmarkham opened a new pull request #14172: update raspberry pi install instructions URL: https://github.com/apache/incubator-mxnet/pull/14172 ## Description ## The current install instructions for Raspberry Pi did not work for me. I kept at it until I got it working and now I've

[GitHub] ankkhedia commented on issue #13400: [MXNET-1229] use OpenBLAS, lapack & OpenCV from conan

2019-02-14 Thread GitBox
ankkhedia commented on issue #13400: [MXNET-1229] use OpenBLAS, lapack & OpenCV from conan URL: https://github.com/apache/incubator-mxnet/pull/13400#issuecomment-463840297 @szha ping for comments/review/merge This is an

[GitHub] ankkhedia commented on issue #13322: Change CUB submodule to track Nvidia CUB project.

2019-02-14 Thread GitBox
ankkhedia commented on issue #13322: Change CUB submodule to track Nvidia CUB project. URL: https://github.com/apache/incubator-mxnet/pull/13322#issuecomment-463838450 @KellenSunderland Could you please review/merge this PR after the latest changes?

[GitHub] ankkhedia commented on issue #13132: enabled link checker and doc test during building the doc

2019-02-14 Thread GitBox
ankkhedia commented on issue #13132: enabled link checker and doc test during building the doc URL: https://github.com/apache/incubator-mxnet/pull/13132#issuecomment-463837900 @mli Could you please look into comments by @aaronmarkham and try to fix the build failures?

[GitHub] ankkhedia commented on issue #12641: Add docker file which includes sample jupyter notebook (#12611)

2019-02-14 Thread GitBox
ankkhedia commented on issue #12641: Add docker file which includes sample jupyter notebook (#12611) URL: https://github.com/apache/incubator-mxnet/pull/12641#issuecomment-463837250 @gautamkmr Thanks for your contribution! Could you please look into the comments by @lupesko

[GitHub] szha commented on a change in pull request #11948: [MXNET-766] add unroll RNN for HybridBlock

2019-02-14 Thread GitBox
szha commented on a change in pull request #11948: [MXNET-766] add unroll RNN for HybridBlock URL: https://github.com/apache/incubator-mxnet/pull/11948#discussion_r257046723 ## File path: python/mxnet/gluon/contrib/rnn/rnn_cell.py ## @@ -315,3 +317,136 @@ def

[GitHub] eric-haibin-lin opened a new pull request #14171: multi-precision AdamW update op

2019-02-14 Thread GitBox
eric-haibin-lin opened a new pull request #14171: multi-precision AdamW update op URL: https://github.com/apache/incubator-mxnet/pull/14171 ## Description ## Tested in gluon-nlp. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR.

[GitHub] zheng-da opened a new pull request #11948: [MXNET-766] add unroll RNN for HybridBlock

2019-02-14 Thread GitBox
zheng-da opened a new pull request #11948: [MXNET-766] add unroll RNN for HybridBlock URL: https://github.com/apache/incubator-mxnet/pull/11948 ## Description ## Currently, Gluon RNNCell unroll can't be used in Gluon HybridBlock. This unroll function works with an RNN cell and can be

[GitHub] lebeg commented on issue #13574: Replaced rand_r with std:: random generation

2019-02-14 Thread GitBox
lebeg commented on issue #13574: Replaced rand_r with std:: random generation URL: https://github.com/apache/incubator-mxnet/pull/13574#issuecomment-463833601 @szha @TaoLv thanks, quoting here again for reference: > Well, the problem is not about the seed itself, but with usage of

[GitHub] ankkhedia commented on issue #10951: [MXNET-545] Fix broken cython build

2019-02-14 Thread GitBox
ankkhedia commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-463832665 @marcoabreu Could you please review/merge this PR? This is an automated

[GitHub] aaronmarkham opened a new pull request #14170: add preprocessed data and pretrained model info

2019-02-14 Thread GitBox
aaronmarkham opened a new pull request #14170: add preprocessed data and pretrained model info URL: https://github.com/apache/incubator-mxnet/pull/14170 ## Description ## This PR updates the instructions for the lipnet example.

[GitHub] ankkhedia commented on issue #12440: Add stable nrm2 for L2 normalization

2019-02-14 Thread GitBox
ankkhedia commented on issue #12440: Add stable nrm2 for L2 normalization URL: https://github.com/apache/incubator-mxnet/pull/12440#issuecomment-463833371 @TD Thanks for the contribution! Could you please take a look into final few comments by @ZhennanQin

[GitHub] ankkhedia commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator

2019-02-14 Thread GitBox
ankkhedia commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator URL: https://github.com/apache/incubator-mxnet/pull/13667#issuecomment-463831393 @apeforest Did you get a chance to work on this PR? #13627 depends on this fix.

  1   2   >