[GitHub] stsukrov commented on issue #13846: Unit tests are broken on OSX

2019-02-28 Thread GitBox
stsukrov commented on issue #13846: Unit tests are broken on OSX URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468576825 CLion uses CMake, so we cannot ignore it completely. I'm not even sure, that the default make even makes tests. Last time, I found

[incubator-mxnet] branch numpy updated (f9c436b -> 992c3c0)

2019-02-28 Thread reminisce
This is an automated email from the ASF dual-hosted git repository. reminisce pushed a change to branch numpy in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from f9c436b Fix req=null in SliceLikeBackward (#14209) add 862cbc6 softmax for fp16 with fp32

[GitHub] apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261502101 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261502101 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] reminisce closed issue #14266: Move TShape definition and necessary passes out of NNVM

2019-02-28 Thread GitBox
reminisce closed issue #14266: Move TShape definition and necessary passes out of NNVM URL: https://github.com/apache/incubator-mxnet/issues/14266 This is an automated message from the Apache Git Service. To respond to the

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-02-28 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new c8fd793 Bump the publish

[GitHub] wkcn commented on issue #14284: Allow gluon blocks to register lists of blocks as attributes

2019-02-28 Thread GitBox
wkcn commented on issue #14284: Allow gluon blocks to register lists of blocks as attributes URL: https://github.com/apache/incubator-mxnet/pull/14284#issuecomment-468563353 The PR is good. I do not know whether there is a conflict between this PR and HybridConcurrent. For

[GitHub] wkcn commented on issue #11635: Aborted python session when using nd.concat

2019-02-28 Thread GitBox
wkcn commented on issue #11635: Aborted python session when using nd.concat URL: https://github.com/apache/incubator-mxnet/issues/11635#issuecomment-468559877 Thanks for your report. Current MXNet does not support 0-size tensor, like mx.nd.empty((0, 1)). We will fix it.

[GitHub] anirudhacharya commented on issue #14190: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14190: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull URL: https://github.com/apache/incubator-mxnet/pull/14190#issuecomment-468553422 @Chancebair is there an issue to track the re-enabling of this test?

[GitHub] access2rohit edited a comment on issue #11635: Aborted python session when using nd.concat

2019-02-28 Thread GitBox
access2rohit edited a comment on issue #11635: Aborted python session when using nd.concat URL: https://github.com/apache/incubator-mxnet/issues/11635#issuecomment-468552555 I am able to repro the issue. Will raise a PR for the fix by tomorrow

[GitHub] access2rohit commented on issue #11635: Aborted python session when using nd.concat

2019-02-28 Thread GitBox
access2rohit commented on issue #11635: Aborted python session when using nd.concat URL: https://github.com/apache/incubator-mxnet/issues/11635#issuecomment-468552555 I am able to repro the issue. Will raise a PR by tomorrow

[GitHub] edfall closed issue #14293: SOFTMAX is slow

2019-02-28 Thread GitBox
edfall closed issue #14293: SOFTMAX is slow URL: https://github.com/apache/incubator-mxnet/issues/14293 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] edfall commented on issue #14293: SOFTMAX is slow

2019-02-28 Thread GitBox
edfall commented on issue #14293: SOFTMAX is slow URL: https://github.com/apache/incubator-mxnet/issues/14293#issuecomment-468549821 I tested, it is much faster. thank you! This is an automated message from the Apache Git

[GitHub] wkcn commented on issue #14242: Large array support for randint

2019-02-28 Thread GitBox
wkcn commented on issue #14242: Large array support for randint URL: https://github.com/apache/incubator-mxnet/pull/14242#issuecomment-468548554 Could you please retrigger the CI? Thanks! This is an automated message from the

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482565 ## File path: src/operator/quantization/quantized_fully_connected.cc ## @@

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482517 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_fully_connected.cc

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482177 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] wkcn commented on issue #14293: SOFTMAX is slow

2019-02-28 Thread GitBox
wkcn commented on issue #14293: SOFTMAX is slow URL: https://github.com/apache/incubator-mxnet/issues/14293#issuecomment-468546320 There are two softmax implementations in MXNet: softmax and SoftmaxActivation, the former is a naive implementation, but the latter is a cudnn one.

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482044 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261481852 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261481799 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h ## @@

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261481627 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h ## @@

[GitHub] TaoLv commented on issue #14202: [Doc] Start the tutorials for MKL-DNN backend

2019-02-28 Thread GitBox
TaoLv commented on issue #14202: [Doc] Start the tutorials for MKL-DNN backend URL: https://github.com/apache/incubator-mxnet/pull/14202#issuecomment-468543817 @aaronmarkham If yes, do you think we can do that in another PR? In this PR, I just try to move the document and make it visible

[GitHub] TaoLv commented on issue #14202: [Doc] Start the tutorials for MKL-DNN backend

2019-02-28 Thread GitBox
TaoLv commented on issue #14202: [Doc] Start the tutorials for MKL-DNN backend URL: https://github.com/apache/incubator-mxnet/pull/14202#issuecomment-468543355 @aaronmarkham Thank you for your kind suggestion. Currently, `pip install mxnet` doesn't have MKL-DNN enabled but `mxnet-mkl`

[GitHub] ZhennanQin commented on a change in pull request #14150: Fix entropy for uint8

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14150: Fix entropy for uint8 URL: https://github.com/apache/incubator-mxnet/pull/14150#discussion_r261477970 ## File path: tests/python/quantization/test_quantization.py ## @@ -673,8 +673,9 @@ def

[GitHub] ZhennanQin commented on issue #14123: Add int8 data loader

2019-02-28 Thread GitBox
ZhennanQin commented on issue #14123: Add int8 data loader URL: https://github.com/apache/incubator-mxnet/pull/14123#issuecomment-468539956 PR is updated to address all comments received. Please review again. Thanks. @anirudh2290 @zhreshold @reminisce

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261475674 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + + + + + +

[GitHub] mxnet-label-bot commented on issue #14293: SOFTMAX is slow

2019-02-28 Thread GitBox
mxnet-label-bot commented on issue #14293: SOFTMAX is slow URL: https://github.com/apache/incubator-mxnet/issues/14293#issuecomment-468537039 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet

[GitHub] edfall opened a new issue #14293: SOFTMAX is slow

2019-02-28 Thread GitBox
edfall opened a new issue #14293: SOFTMAX is slow URL: https://github.com/apache/incubator-mxnet/issues/14293 ## Description Trying to implement an attention model with mxnet, a lot of softmax operation is used. I find softmax operation is `too slow`, slower than a convolution

[GitHub] pengzhao-intel commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
pengzhao-intel commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261473796 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + +

[GitHub] yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261471920 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261471920 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261471550 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + + + + + +

[GitHub] ZhennanQin commented on issue #14123: Add int8 data loader

2019-02-28 Thread GitBox
ZhennanQin commented on issue #14123: Add int8 data loader URL: https://github.com/apache/incubator-mxnet/pull/14123#issuecomment-468524784 @anirudh2290 Thanks for having a look on this. I agree with your point that user experience is important. Then I will add operator support without

[GitHub] pengzhao-intel commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
pengzhao-intel commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261463572 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + +

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261463076 ## File path: src/operator/quantization/quantized_fully_connected.cc ##

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261462614 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_fully_connected.cc

[GitHub] anirudhacharya commented on issue #14274: added mkldnn dependency for plugin compile target

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14274: added mkldnn dependency for plugin compile target URL: https://github.com/apache/incubator-mxnet/pull/14274#issuecomment-468519551 @mxnet-label-bot add [pr-awaiting-review] This is

[GitHub] anirudhacharya edited a comment on issue #14277: Enhance PartitionGraph

2019-02-28 Thread GitBox
anirudhacharya edited a comment on issue #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#issuecomment-468519240 @mxnet-label-bot add [pr-awaiting-review] @ZhennanQin could you please rebase your PR and resolve the conflicts?

[GitHub] anirudhacharya commented on issue #14275: Register fake grad to subgraph and quantized operators

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14275: Register fake grad to subgraph and quantized operators URL: https://github.com/apache/incubator-mxnet/pull/14275#issuecomment-468519500 @mxnet-label-bot add [pr-awaiting-review] This

[GitHub] anirudhacharya commented on issue #14276: Skip inference only subgraph pass when gradient is needed.

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14276: Skip inference only subgraph pass when gradient is needed. URL: https://github.com/apache/incubator-mxnet/pull/14276#issuecomment-468519412 @mxnet-label-bot add [pr-awaiting-review]

[GitHub] anirudhacharya commented on issue #14278: Use cudnn for dropout by default

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14278: Use cudnn for dropout by default URL: https://github.com/apache/incubator-mxnet/pull/14278#issuecomment-468519222 @mxnet-label-bot add [pr-awaiting-review] This is an automated

[GitHub] anirudhacharya commented on issue #14277: Enhance PartitionGraph

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#issuecomment-468519240 @mxnet-label-bot add [pr-awaiting-review] This is an automated message from the

[GitHub] anirudhacharya commented on issue #14284: Allow gluon blocks to register lists of blocks as attributes

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14284: Allow gluon blocks to register lists of blocks as attributes URL: https://github.com/apache/incubator-mxnet/pull/14284#issuecomment-468519204 @mxnet-label-bot add [pr-awaiting-review]

[GitHub] anirudhacharya commented on issue #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#issuecomment-468519140 @mxnet-label-bot add [pr-awaiting-review] This is an

[GitHub] anirudhacharya commented on issue #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#issuecomment-468519110 @mxnet-label-bot add [pr-awaiting-review] This is an automated

[GitHub] anirudh2290 commented on issue #14123: Add int8 data loader

2019-02-28 Thread GitBox
anirudh2290 commented on issue #14123: Add int8 data loader URL: https://github.com/apache/incubator-mxnet/pull/14123#issuecomment-468518573 I guess there are good reasons for not allowing inplace operations for inputs. One reason could be that the data allocation for inputs is controlled

[GitHub] anirudh2290 commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
anirudh2290 commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261461869 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261461699 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261461488 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261461488 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] pengzhao-intel commented on issue #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
pengzhao-intel commented on issue #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#issuecomment-468516453 @reminisce @zheng-da @anirudh2290 could you help to take a review?

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261460230 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261459758 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h ## @@

[GitHub] ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-02-28 Thread GitBox
ZhennanQin commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261459375 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h ## @@

[incubator-mxnet] branch master updated (c319ae5 -> 992c3c0)

2019-02-28 Thread reminisce
This is an automated email from the ASF dual-hosted git repository. reminisce pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from c319ae5 MXNet Java bug fixes and experience improvement (#14213) add 992c3c0 [MXNET-1330] Bring

[GitHub] reminisce merged pull request #14270: [MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple

2019-02-28 Thread GitBox
reminisce merged pull request #14270: [MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple URL: https://github.com/apache/incubator-mxnet/pull/14270 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wkcn commented on a change in pull request #14278: Use cudnn for dropout by default

2019-02-28 Thread GitBox
wkcn commented on a change in pull request #14278: Use cudnn for dropout by default URL: https://github.com/apache/incubator-mxnet/pull/14278#discussion_r261444796 ## File path: tests/cpp/include/test_op.h ## @@ -72,7 +72,7 @@ struct GPUStreamScope { :

[GitHub] wkcn commented on a change in pull request #14278: Use cudnn for dropout by default

2019-02-28 Thread GitBox
wkcn commented on a change in pull request #14278: Use cudnn for dropout by default URL: https://github.com/apache/incubator-mxnet/pull/14278#discussion_r261444796 ## File path: tests/cpp/include/test_op.h ## @@ -72,7 +72,7 @@ struct GPUStreamScope { :

[GitHub] junrushao1994 opened a new issue #14292: [Flaky] test_operator_gpu.test_adamax

2019-02-28 Thread GitBox
junrushao1994 opened a new issue #14292: [Flaky] test_operator_gpu.test_adamax URL: https://github.com/apache/incubator-mxnet/issues/14292

[GitHub] mxnet-label-bot commented on issue #14292: [Flaky] test_operator_gpu.test_adamax

2019-02-28 Thread GitBox
mxnet-label-bot commented on issue #14292: [Flaky] test_operator_gpu.test_adamax URL: https://github.com/apache/incubator-mxnet/issues/14292#issuecomment-468497734 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the

[GitHub] wkcn commented on issue #14278: Use cudnn for dropout by default

2019-02-28 Thread GitBox
wkcn commented on issue #14278: Use cudnn for dropout by default URL: https://github.com/apache/incubator-mxnet/pull/14278#issuecomment-468494491 Thanks for your contribution! LGTM. Wait for the finish of CI. This is an

[GitHub] access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261441217 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def

[GitHub] yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261440007 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] junrushao1994 commented on a change in pull request #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils

2019-02-28 Thread GitBox
junrushao1994 commented on a change in pull request #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils URL: https://github.com/apache/incubator-mxnet/pull/14192#discussion_r261430888 ## File path: src/imperative/cached_op.cc ## @@ -262,6 +262,32 @@ std::vector

[GitHub] access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261430218 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def

[GitHub] access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261430218 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def

[GitHub] mxnet-label-bot commented on issue #14291: [Clojure] mxnet-scala cannot be loaded without legacy openssl

2019-02-28 Thread GitBox
mxnet-label-bot commented on issue #14291: [Clojure] mxnet-scala cannot be loaded without legacy openssl URL: https://github.com/apache/incubator-mxnet/issues/14291#issuecomment-468482804 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest

[GitHub] cbowdon opened a new issue #14291: [Clojure] mxnet-scala cannot be loaded without legacy openssl

2019-02-28 Thread GitBox
cbowdon opened a new issue #14291: [Clojure] mxnet-scala cannot be loaded without legacy openssl URL: https://github.com/apache/incubator-mxnet/issues/14291 ## Description I have a very similar (probably related) issue to #12822 when using the pre-built jar. Same error message as

[GitHub] access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
access2rohit commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261428445 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def

[GitHub] junrushao1994 opened a new issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams

2019-02-28 Thread GitBox
junrushao1994 opened a new issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams URL: https://github.com/apache/incubator-mxnet/issues/14289

[GitHub] mxnet-label-bot commented on issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams

2019-02-28 Thread GitBox
mxnet-label-bot commented on issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams URL: https://github.com/apache/incubator-mxnet/issues/14289#issuecomment-468480929 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some

[GitHub] apeforest edited a comment on issue #14253: [RFC] Introducing NumPy-compatible coding experience into MXNet

2019-02-28 Thread GitBox
apeforest edited a comment on issue #14253: [RFC] Introducing NumPy-compatible coding experience into MXNet URL: https://github.com/apache/incubator-mxnet/issues/14253#issuecomment-468479524 @reminisce I am fine with keeping those two namespaces till 2.0 for backward compatibility.

[GitHub] apeforest commented on issue #14253: [RFC] Introducing NumPy-compatible coding experience into MXNet

2019-02-28 Thread GitBox
apeforest commented on issue #14253: [RFC] Introducing NumPy-compatible coding experience into MXNet URL: https://github.com/apache/incubator-mxnet/issues/14253#issuecomment-468479524 @reminisce I am fine with keeping those two namespaces till 2.0 for backward compatibility. Starting

[GitHub] junrushao1994 commented on issue #14288: Flaky test: test_operator_gpu.test_dropout

2019-02-28 Thread GitBox
junrushao1994 commented on issue #14288: Flaky test: test_operator_gpu.test_dropout URL: https://github.com/apache/incubator-mxnet/issues/14288#issuecomment-468475371 See also

[GitHub] mxnet-label-bot commented on issue #14288: Flaky test: test_operator_gpu.test_dropout

2019-02-28 Thread GitBox
mxnet-label-bot commented on issue #14288: Flaky test: test_operator_gpu.test_dropout URL: https://github.com/apache/incubator-mxnet/issues/14288#issuecomment-468474933 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that

[GitHub] junrushao1994 opened a new issue #14288: Flaky test: test_operator_gpu.test_dropout

2019-02-28 Thread GitBox
junrushao1994 opened a new issue #14288: Flaky test: test_operator_gpu.test_dropout URL: https://github.com/apache/incubator-mxnet/issues/14288

[GitHub] ctcyang commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
ctcyang commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261421989 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + + + + + +

[GitHub] apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261420941 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] zheng-da commented on a change in pull request #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils

2019-02-28 Thread GitBox
zheng-da commented on a change in pull request #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils URL: https://github.com/apache/incubator-mxnet/pull/14192#discussion_r261420719 ## File path: src/imperative/cached_op.cc ## @@ -262,6 +262,32 @@ std::vector

[GitHub] mseth10 commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
mseth10 commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261419808 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] stu1130 commented on a change in pull request #14259: Add Gluon Transformer Crop

2019-02-28 Thread GitBox
stu1130 commented on a change in pull request #14259: Add Gluon Transformer Crop URL: https://github.com/apache/incubator-mxnet/pull/14259#discussion_r261419411 ## File path: python/mxnet/gluon/data/vision/transforms.py ## @@ -228,6 +228,54 @@ def forward(self, x):

[GitHub] yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261418060 ## File path: python/mxnet/test_utils.py ## @@ -1933,7 +1933,7 @@ def chi_square_check(generator,

[GitHub] access2rohit commented on a change in pull request #14259: Add Gluon Transformer Crop

2019-02-28 Thread GitBox
access2rohit commented on a change in pull request #14259: Add Gluon Transformer Crop URL: https://github.com/apache/incubator-mxnet/pull/14259#discussion_r261415307 ## File path: python/mxnet/gluon/data/vision/transforms.py ## @@ -228,6 +228,54 @@ def forward(self, x):

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261411926 ## File path: example/distributed_training-horovod/mxnet_imagenet_resnet50.py ## @@ -0,0 +1,456

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261412200 ## File path: example/distributed_training-horovod/mxnet_mnist.py ## @@ -0,0 +1,142 @@ +# Step

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261413090 ## File path: example/distributed_training-horovod/README.md ## @@ -0,0 +1,207 @@ + + + + + + +

[GitHub] yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
yuxihu commented on a change in pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#discussion_r261412084 ## File path: example/distributed_training-horovod/mxnet_imagenet_resnet50.py ## @@ -0,0 +1,456

[GitHub] anirudhacharya commented on issue #14262: Fix NaN value comparisons in relu, max and min ops

2019-02-28 Thread GitBox
anirudhacharya commented on issue #14262: Fix NaN value comparisons in relu, max and min ops URL: https://github.com/apache/incubator-mxnet/pull/14262#issuecomment-468464486 @szha yes I think the relu grad should also be handled in a special way, thanks for pointing it out.

[GitHub] access2rohit commented on issue #14287: FIX: falky test exponential generator

2019-02-28 Thread GitBox
access2rohit commented on issue #14287: FIX: falky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287#issuecomment-468463591 @anirudh2290 @eric-haibin-lin @apeforest Can you please review ?

[GitHub] access2rohit opened a new pull request #14287: FIX: falky test exponential generator

2019-02-28 Thread GitBox
access2rohit opened a new pull request #14287: FIX: falky test exponential generator URL: https://github.com/apache/incubator-mxnet/pull/14287 ## Description ## revert success_rate to 0.15(earlier value) since new value is much stricter and fails random number generator tests.

[GitHub] apeforest commented on issue #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
apeforest commented on issue #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286#issuecomment-468462707 @yuxihu @rahul003 @ctcyang Please help to review. This is an

[GitHub] apeforest opened a new pull request #14286: Add examples of running MXNet with Horovod

2019-02-28 Thread GitBox
apeforest opened a new pull request #14286: Add examples of running MXNet with Horovod URL: https://github.com/apache/incubator-mxnet/pull/14286 ## Description ## Added a mnist and an imagenet example to show how to run MXNet with Horovod. README page is also added. ### Changes

[GitHub] stephenrawls commented on issue #14264: nd.reshape truncate values

2019-02-28 Thread GitBox
stephenrawls commented on issue #14264: nd.reshape truncate values URL: https://github.com/apache/incubator-mxnet/issues/14264#issuecomment-468462262 I'm okay if we add a boolean flag to turn this feature on. I'm even okay if we move this feature to a different operator if you want 100%

[GitHub] access2rohit commented on issue #13846: Unit tests are broken on OSX

2019-02-28 Thread GitBox
access2rohit commented on issue #13846: Unit tests are broken on OSX URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468459759 @zachgk Thanks for the link. @stsukrov If you want to use CMAKE only you can try instructions here:

[GitHub] MaxBareiss commented on issue #14263: MXNet Master build for CUDA with DEBUG=1 failing

2019-02-28 Thread GitBox
MaxBareiss commented on issue #14263: MXNet Master build for CUDA with DEBUG=1 failing URL: https://github.com/apache/incubator-mxnet/issues/14263#issuecomment-468458677 I have the same issue on PPC64LE using master (c319ae57), built with CMake on Linux. I don't have this issue with

[GitHub] danithaca edited a comment on issue #13598: More fine-grained operator implementation dispatch & memory planning flow

2019-02-28 Thread GitBox
danithaca edited a comment on issue #13598: More fine-grained operator implementation dispatch & memory planning flow URL: https://github.com/apache/incubator-mxnet/issues/13598#issuecomment-468456105 We observed poor inference latency with MKL-DNN (see

[GitHub] danithaca edited a comment on issue #13598: More fine-grained operator implementation dispatch & memory planning flow

2019-02-28 Thread GitBox
danithaca edited a comment on issue #13598: More fine-grained operator implementation dispatch & memory planning flow URL: https://github.com/apache/incubator-mxnet/issues/13598#issuecomment-468456105 We observed poor inference latency with MKL-DNN (see

[GitHub] danithaca commented on issue #13598: More fine-grained operator implementation dispatch & memory planning flow

2019-02-28 Thread GitBox
danithaca commented on issue #13598: More fine-grained operator implementation dispatch & memory planning flow URL: https://github.com/apache/incubator-mxnet/issues/13598#issuecomment-468456105 We observed poor inference latency with MKL-DNN, and maybe this proposal will help address

[GitHub] junrushao1994 commented on issue #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils

2019-02-28 Thread GitBox
junrushao1994 commented on issue #14192: [MXNET-1324] Add NaiveRunGraph to imperative utils URL: https://github.com/apache/incubator-mxnet/pull/14192#issuecomment-468455458 @szha Hey I added a unit test for this PR :-) This

  1   2   >