[GitHub] [incubator-mxnet] yuxihu edited a comment on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu edited a comment on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481976023 > Please add a test which pushes an op using this C API, to ensure we don't have regressions in the future.

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481976023 > Please add a test which pushes an op using this C API, to ensure we don't have regressions in the future. Addressed

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274253672 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274253655 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
pengzhao-intel commented on issue #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#issuecomment-481953285 Please retrigger the CI This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #14604: [MKLDNN]Add quantized relu

2019-04-10 Thread GitBox
pengzhao-intel commented on issue #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#issuecomment-481953205 Please retrigger the CI This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242859 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum-inl.h ## @@ -0,0 +1,58 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240437 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240520 ## File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_property.cc ## @@ -21,7 +21,7 @@ #include

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242843 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240393 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242594 ## File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_property.cc ## @@ -21,7 +21,7 @@ #include

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240387 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242562 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242405 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274242540 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240369 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240351 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum-inl.h ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [incubator-mxnet] wkcn edited a comment on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU

2019-04-10 Thread GitBox
wkcn edited a comment on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU URL: https://github.com/apache/incubator-mxnet/issues/14664#issuecomment-481943077 Sorry that the version of CUDA in my machine is 10.1.105. It seems that there is no any related pre-build MXNet

[GitHub] [incubator-mxnet] wkcn edited a comment on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU

2019-04-10 Thread GitBox
wkcn edited a comment on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU URL: https://github.com/apache/incubator-mxnet/issues/14664#issuecomment-481943077 Sorry that the version of CUDA in my machine is 10.1.105. It seems that there is no any related pre-build MXNet

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240437 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240387 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240520 ## File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_property.cc ## @@ -21,7 +21,7 @@ #include

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240351 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum-inl.h ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240393 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-10 Thread GitBox
triplekings commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r274240369 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + *

[GitHub] [incubator-mxnet] wkcn commented on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU

2019-04-10 Thread GitBox
wkcn commented on issue #14664: mxnet-cu100mkl "illegal instruction" on CPU URL: https://github.com/apache/incubator-mxnet/issues/14664#issuecomment-481943077 Sorry that the version of CUDA in my machine is 10.1.105. It seems that there is no any related pre-build MXNet package.

[GitHub] [incubator-mxnet] momo1986 opened a new issue #14672: Is it possible for mxnet to save the best model and early stopping

2019-04-10 Thread GitBox
momo1986 opened a new issue #14672: Is it possible for mxnet to save the best model and early stopping URL: https://github.com/apache/incubator-mxnet/issues/14672 Hello, thanks for sharing the framework. I want to do some objection task based on the finetuned mxnet official SSD

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
pengzhao-intel commented on issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670#issuecomment-481940182 cc @TaoLv This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] KellenSunderland commented on issue #14539: Is there any way to save the parameter of the autotuning ?

2019-04-10 Thread GitBox
KellenSunderland commented on issue #14539: Is there any way to save the parameter of the autotuning ? URL: https://github.com/apache/incubator-mxnet/issues/14539#issuecomment-481932232 Yes we've got a solution we use internally but it's not fleshed out enough to open source. Could we

[GitHub] [incubator-mxnet] NeoZhangJianyu commented on issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
NeoZhangJianyu commented on issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670#issuecomment-481931269 @larroy I'm fixing this issue now. There are several problems for this issue: 1. $MKLROOT is set by MKL installation,

[GitHub] [incubator-mxnet] zachgk commented on issue #14671: [MXNET-1385] Fix scaladoc scalastyle violations in Infer package

2019-04-10 Thread GitBox
zachgk commented on issue #14671: [MXNET-1385] Fix scaladoc scalastyle violations in Infer package URL: https://github.com/apache/incubator-mxnet/pull/14671#issuecomment-481930479 @mxnet-label-bot add [Scala, pr-awaiting-review]

[GitHub] [incubator-mxnet] zachgk opened a new pull request #14671: [MXNET-1385] Fix scaladoc scalastyle violations in Infer package

2019-04-10 Thread GitBox
zachgk opened a new pull request #14671: [MXNET-1385] Fix scaladoc scalastyle violations in Infer package URL: https://github.com/apache/incubator-mxnet/pull/14671 ## Description ## Add all missing and fix broken scaladocs within the Scala Infer module. It runs without warnings through

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-04-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new b17e671 Bump the publish

[GitHub] [incubator-mxnet] larroy commented on issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
larroy commented on issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670#issuecomment-481927993 @mxnet-label-bot add [CMake, Build, MKL] This is an automated

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
pengzhao-intel commented on issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670#issuecomment-481927705 thank to report this issue @larroy @Neozhangjianyu @yinghu5 is working on the CMake for MKL

[GitHub] [incubator-mxnet] iblis17 commented on issue #12845: Julia v0.7/1.0 support and drop v0.6 support

2019-04-10 Thread GitBox
iblis17 commented on issue #12845: Julia v0.7/1.0 support and drop v0.6 support URL: https://github.com/apache/incubator-mxnet/pull/12845#issuecomment-481926791 @aaronmarkham I plan to deploy it in downside channel -- gh-page of MXNet.jl (https://github.com/dmlc/MXNet.jl) Since the

[GitHub] [incubator-mxnet] anirudhacharya commented on issue #14568: NAG Optimizer with multi-precision support

2019-04-10 Thread GitBox
anirudhacharya commented on issue #14568: NAG Optimizer with multi-precision support URL: https://github.com/apache/incubator-mxnet/pull/14568#issuecomment-481925196 @lupesko Nesterov Accelerated Gradient or NAG is an improvement over SGD with Momentum optimizer. As we know

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14535: [DOC] Updated install instructions for mac

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r274221049 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the

[GitHub] [incubator-mxnet] larroy commented on issue #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on issue #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#issuecomment-481917949 @piyushghai up to reviewers to approve or follow up on the changes / made additional requests. @apeforest @aaronmarkham

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274218795 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274218527 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274218227 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274218100 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274217846 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274217846 ## File path: docs/install/ubuntu_setup.md ## @@ -170,44 +191,72 @@ If building on CPU

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r274217631 ## File path: docs/install/ubuntu_setup.md ## @@ -137,12 +137,33 @@ It is recommended

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
mxnet-label-bot commented on issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670#issuecomment-481915583 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the

[GitHub] [incubator-mxnet] larroy opened a new issue #14670: Default build with CMake not using MKL

2019-04-10 Thread GitBox
larroy opened a new issue #14670: Default build with CMake not using MKL URL: https://github.com/apache/incubator-mxnet/issues/14670 With make MKL is installed automatically, but with CMake in linux not. ``` piotr@ip-172-31-30-72:0:~/mxnet (master)$ cp

[incubator-mxnet] branch master updated: Optimize transpose operator with MKL-DNN (#14545)

2019-04-10 Thread patriczhao
This is an automated email from the ASF dual-hosted git repository. patriczhao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 2c5d7f7 Optimize transpose

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #14545: Optimize transpose operator with MKL-DNN

2019-04-10 Thread GitBox
pengzhao-intel commented on issue #14545: Optimize transpose operator with MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/14545#issuecomment-481892654 very great improvement. Merging now. This is an automated

[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #14545: Optimize transpose operator with MKL-DNN

2019-04-10 Thread GitBox
pengzhao-intel merged pull request #14545: Optimize transpose operator with MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/14545 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] larroy closed pull request #13907: Fixes downloading of data in cpp-package/example/get_data.sh

2019-04-10 Thread GitBox
larroy closed pull request #13907: Fixes downloading of data in cpp-package/example/get_data.sh URL: https://github.com/apache/incubator-mxnet/pull/13907 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-mxnet] larroy commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh

2019-04-10 Thread GitBox
larroy commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh URL: https://github.com/apache/incubator-mxnet/pull/13907#issuecomment-481883315 the logic has been updated already This is an

[GitHub] [incubator-mxnet] larroy commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh

2019-04-10 Thread GitBox
larroy commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh URL: https://github.com/apache/incubator-mxnet/pull/13907#issuecomment-481882540 will have a look, thanks for the reviews. This

[incubator-mxnet] branch clojure-enhance-bounding-box deleted (was 5e18d8e)

2019-04-10 Thread cmeier
This is an automated email from the ASF dual-hosted git repository. cmeier pushed a change to branch clojure-enhance-bounding-box in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. was 5e18d8e refactor to be 3 top predictions instead of 5 to make the images less

[incubator-mxnet] branch clojure-enhance-bounding-box created (now 5e18d8e)

2019-04-10 Thread cmeier
This is an automated email from the ASF dual-hosted git repository. cmeier pushed a change to branch clojure-enhance-bounding-box in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 5e18d8e refactor to be 3 top predictions instead of 5 to make the images less

[GitHub] [incubator-mxnet] gigasquid commented on a change in pull request #14567: [Clojure] enhance draw bounding box

2019-04-10 Thread GitBox
gigasquid commented on a change in pull request #14567: [Clojure] enhance draw bounding box URL: https://github.com/apache/incubator-mxnet/pull/14567#discussion_r274176361 ## File path: contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj

[GitHub] [incubator-mxnet] gigasquid commented on a change in pull request #14567: [Clojure] enhance draw bounding box

2019-04-10 Thread GitBox
gigasquid commented on a change in pull request #14567: [Clojure] enhance draw bounding box URL: https://github.com/apache/incubator-mxnet/pull/14567#discussion_r274173991 ## File path: contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj

[GitHub] [incubator-mxnet] larroy commented on issue #14631: Fix build_ccache_wrappers:

2019-04-10 Thread GitBox
larroy commented on issue #14631: Fix build_ccache_wrappers: URL: https://github.com/apache/incubator-mxnet/pull/14631#issuecomment-481872636 @KellenSunderland you might want to chime in as well. This is an automated message

[GitHub] [incubator-mxnet] larroy commented on issue #14631: Fix build_ccache_wrappers:

2019-04-10 Thread GitBox
larroy commented on issue #14631: Fix build_ccache_wrappers: URL: https://github.com/apache/incubator-mxnet/pull/14631#issuecomment-481872564 @marcoabreu can you have another look please? CI is passing. This is an automated

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274166971 ## File path: src/c_api/c_api.cc ## @@ -1401,3 +1401,78 @@ int

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274166937 ## File path: include/mxnet/c_api.h ## @@ -2541,6 +2553,51 @@ MXNET_DLL int

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274166740 ## File path: include/mxnet/c_api.h ## @@ -2541,6 +2553,51 @@ MXNET_DLL int

[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #14656: [MXNET-1385] Improved Scala Init and Macros warning messages

2019-04-10 Thread GitBox
zachgk commented on a change in pull request #14656: [MXNET-1385] Improved Scala Init and Macros warning messages URL: https://github.com/apache/incubator-mxnet/pull/14656#discussion_r274157948 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/GeneratorBase.scala

[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #14656: [MXNET-1385] Improved Scala Init and Macros warning messages

2019-04-10 Thread GitBox
zachgk commented on a change in pull request #14656: [MXNET-1385] Improved Scala Init and Macros warning messages URL: https://github.com/apache/incubator-mxnet/pull/14656#discussion_r274157211 ## File path:

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274163461 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
larroy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274163045 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[GitHub] [incubator-mxnet] lanking520 edited a comment on issue #14666: [MXNET-1287] Fix test memory with ResourceScope

2019-04-10 Thread GitBox
lanking520 edited a comment on issue #14666: [MXNET-1287] Fix test memory with ResourceScope URL: https://github.com/apache/incubator-mxnet/pull/14666#issuecomment-481866896 Try to clean up this: `NDArrayCollector` introduced in 1.2, we can use ResourceScope to replace them now.

[GitHub] [incubator-mxnet] lanking520 commented on issue #14666: [MXNET-1287] Fix test memory with ResourceScope

2019-04-10 Thread GitBox
lanking520 commented on issue #14666: [MXNET-1287] Fix test memory with ResourceScope URL: https://github.com/apache/incubator-mxnet/pull/14666#issuecomment-481866896 Try to clean up this: `NDArrayCollector` introduced in 1.2, we can use ResourceScope to replace them now.

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274159837 ## File path: include/mxnet/c_api.h ## @@ -2541,6 +2553,51 @@ MXNET_DLL int

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274159345 ## File path: include/mxnet/c_api.h ## @@ -2541,6 +2553,51 @@ MXNET_DLL int

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
anirudh2290 commented on a change in pull request #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r274144895 ## File path: src/c_api/c_api.cc ## @@ -1401,3 +1401,78 @@ int

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274159284 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274159399 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274159518 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

2019-04-10 Thread GitBox
yuxihu commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r274158887 ## File path: src/imperative/imperative_utils.cc ## @@ -20,62 +20,61 @@

[incubator-mxnet] branch master updated: [MXNET-1287] Miscellaneous Scala warning fixes (#14658)

2019-04-10 Thread lanking
This is an automated email from the ASF dual-hosted git repository. lanking pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 8f0878c [MXNET-1287] Miscellaneous

[GitHub] [incubator-mxnet] lanking520 merged pull request #14658: [MXNET-1287] Miscellaneous Scala warning fixes

2019-04-10 Thread GitBox
lanking520 merged pull request #14658: [MXNET-1287] Miscellaneous Scala warning fixes URL: https://github.com/apache/incubator-mxnet/pull/14658 This is an automated message from the Apache Git Service. To respond to the

[incubator-mxnet] branch v1.4.x updated: Fix nightly build of 1.4.x (#14556)

2019-04-10 Thread thomasdelteil
This is an automated email from the ASF dual-hosted git repository. thomasdelteil pushed a commit to branch v1.4.x in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.4.x by this push: new 8b68640 Fix nightly build of

[GitHub] [incubator-mxnet] ThomasDelteil merged pull request #14556: Fix nightly build of 1.4.x

2019-04-10 Thread GitBox
ThomasDelteil merged pull request #14556: Fix nightly build of 1.4.x URL: https://github.com/apache/incubator-mxnet/pull/14556 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-04-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new bdcbad7 Bump the publish

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274143236 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114931 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274142661 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114705 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] vrakesh commented on issue #14650: How can I parse mxnet params file into plain text?

2019-04-10 Thread GitBox
vrakesh commented on issue #14650: How can I parse mxnet params file into plain text? URL: https://github.com/apache/incubator-mxnet/issues/14650#issuecomment-481847054 @mxnet-label-bot add [Pending requester Info] This is

[GitHub] [incubator-mxnet] vrakesh commented on issue #14663: Error with NDArray.Reshape

2019-04-10 Thread GitBox
vrakesh commented on issue #14663: Error with NDArray.Reshape URL: https://github.com/apache/incubator-mxnet/issues/14663#issuecomment-481846837 Hi @FAFACHR , thank you for posting the question to the community,requesting to share a reproducible script , so that we can look into what's

[GitHub] [incubator-mxnet] vrakesh edited a comment on issue #14660: After the interruption, there are many zombie processes that cannot be killed.

2019-04-10 Thread GitBox
vrakesh edited a comment on issue #14660: After the interruption, there are many zombie processes that cannot be killed. URL: https://github.com/apache/incubator-mxnet/issues/14660#issuecomment-481846115 @Hughen Thank you for sharing the issue, requesting to provide more details and

[GitHub] [incubator-mxnet] vrakesh commented on issue #14660: After the interruption, there are many zombie processes that cannot be killed.

2019-04-10 Thread GitBox
vrakesh commented on issue #14660: After the interruption, there are many zombie processes that cannot be killed. URL: https://github.com/apache/incubator-mxnet/issues/14660#issuecomment-481846115 @Hughen Thank you for sharing the issue, requesting to provide more details and train.py so

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481835319 @junrushao1994 Changed to C API. Please help review. This

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481835181 > I wasn't suggesting a custom op but a standard nnvm op like mxnet backend ops. This can then be invoked using

[GitHub] [incubator-mxnet] zachgk edited a comment on issue #13995: [MXNET-1287] Scala compiler warnings

2019-04-10 Thread GitBox
zachgk edited a comment on issue #13995: [MXNET-1287] Scala compiler warnings URL: https://github.com/apache/incubator-mxnet/pull/13995#issuecomment-481482255 I am closing this PR in favor of several smaller PRs: - #14658 - Miscellaneous Scala warning fixes - #14666 - Fix test

[GitHub] [incubator-mxnet] zachgk commented on issue #14669: [MXNET-1287] Fix scalastyle

2019-04-10 Thread GitBox
zachgk commented on issue #14669: [MXNET-1287] Fix scalastyle URL: https://github.com/apache/incubator-mxnet/pull/14669#issuecomment-481832478 @mxnet-label-bot add [Scala, pr-awaiting-review] This is an automated message from

[GitHub] [incubator-mxnet] zachgk opened a new pull request #14669: [MXNET-1287] Fix scalastyle

2019-04-10 Thread GitBox
zachgk opened a new pull request #14669: [MXNET-1287] Fix scalastyle URL: https://github.com/apache/incubator-mxnet/pull/14669 ## Description ## This PR fixes a number of scalastyle violations and has some other minor improvements to code quality. Contains a part of #13995.

[GitHub] [incubator-mxnet] anirudh2290 commented on issue #14397: Add exception handling support for waitall

2019-04-10 Thread GitBox
anirudh2290 commented on issue #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#issuecomment-481832109 checking this now. This is an automated message from the

[GitHub] [incubator-mxnet] zachgk opened a new pull request #14668: [MXNET-1287] Feat dep

2019-04-10 Thread GitBox
zachgk opened a new pull request #14668: [MXNET-1287] Feat dep URL: https://github.com/apache/incubator-mxnet/pull/14668 ## Description ## This PR fixes the feature/deprecation warnings and makes them display as part of the Maven run by default. Most of the fixes are related to the

[GitHub] [incubator-mxnet] zachgk commented on issue #14668: [MXNET-1287] Feat dep

2019-04-10 Thread GitBox
zachgk commented on issue #14668: [MXNET-1287] Feat dep URL: https://github.com/apache/incubator-mxnet/pull/14668#issuecomment-481831742 @mxnet-label-bot add [Scala, Maven, pr-awaiting-review] This is an automated message

[GitHub] [incubator-mxnet] zachgk commented on issue #14667: [MXNET-1287] Up scala comp

2019-04-10 Thread GitBox
zachgk commented on issue #14667: [MXNET-1287] Up scala comp URL: https://github.com/apache/incubator-mxnet/pull/14667#issuecomment-481830900 @mxnet-label-bot add [Scala, Maven, pr-awaiting-review] This is an automated

[GitHub] [incubator-mxnet] zachgk opened a new pull request #14667: [MXNET-1287] Up scala comp

2019-04-10 Thread GitBox
zachgk opened a new pull request #14667: [MXNET-1287] Up scala comp URL: https://github.com/apache/incubator-mxnet/pull/14667 ## Description ## This PR contains a number of improvements to the Maven configuration. Most notably, it switches to a set of dependencies all using Scala

  1   2   >