[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-16 Thread GitBox
TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324531557 ## File path: src/common/exec_utils.h ## @@ -59,15 +59,15 @@ inline bool SetupDefaultBlobsIn(const std

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-11 Thread GitBox
TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r323127064 ## File path: src/operator/nn/mkldnn/mkldnn_convolution-inl.h ## @@ -20,18 +20,18 @@ /*! * \file mkl

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-11 Thread GitBox
TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r323126680 ## File path: src/operator/nn/mkldnn/mkldnn_convolution-inl.h ## @@ -20,18 +20,18 @@ /*! * \file mkl

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-11 Thread GitBox
TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r323126328 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -530,13 +530,11 @@ bool MKLDNNStorageType(con