[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-07-03 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r299844023 ## File path: python/mxnet/numpy/multiarray.py ## @@ -778,13 +778,18 @@ def topk(self, *args, **kwargs): """

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-07-03 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r299839833 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -284,6 +284,66 @@ def argmax(a, axis=None, out=None): retur

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296152237 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -775,6 +775,47 @@ def hybrid_forward(self, F, x):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296152154 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -775,6 +775,47 @@ def hybrid_forward(self, F, x):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296151784 ## File path: python/mxnet/numpy/multiarray.py ## @@ -1716,7 +1748,6 @@ def expand_dims(a, axis): """ return

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296151893 ## File path: python/mxnet/symbol/numpy/_symbol.py ## @@ -355,13 +355,18 @@ def topk(self, *args, **kwargs):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296152065 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -775,6 +775,47 @@ def hybrid_forward(self, F, x):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-21 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296126980 ## File path: python/mxnet/symbol/numpy/_symbol.py ## @@ -1138,6 +1143,33 @@ def argmax(a, axis=None, out=None):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-20 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296085060 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -539,7 +566,6 @@ def expand_dims(a, axis): """ return

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-19 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r295600470 ## File path: src/operator/tensor/ordering_op-inl.h ## @@ -580,18 +580,37 @@ void ArgSort(const nnvm::NodeAttrs& attrs

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-19 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r295599839 ## File path: src/operator/tensor/ordering_op-inl.h ## @@ -580,18 +580,37 @@ void ArgSort(const nnvm::NodeAttrs& attrs

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-19 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r295599813 ## File path: src/operator/tensor/ordering_op-inl.h ## @@ -580,18 +580,37 @@ void ArgSort(const nnvm::NodeAttrs& attrs

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort

2019-06-19 Thread GitBox
haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r295599764 ## File path: src/operator/tensor/ordering_op-inl.h ## @@ -580,18 +580,37 @@ void ArgSort(const nnvm::NodeAttrs& attrs