liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-565776615
> If it’s in the official API, the argument name/order should be changed
before the code freeze period. Thus, in the code freeze perio
liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-565775848
> @leezu @liuzh91 Which bug does this PR solve? Is there an issue for that?
Validation network and loss function were introduced
liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-565775182
> Changing the name and order of arguments means it's impossible to write
library code that supports both 1.6 and development version
liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-564864220
@ptrendx @leezu @szha Thanks for the reply. I understand the risk of
changing parameter names may break existing api. But the paramete
liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-564835125
@ptrendx please tag this fix for r1.6.0
This is an automated message
