[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277096457 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -191,18 +287,23 @@ class

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094820 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094820 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277096380 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -112,71 +196,83 @@ def

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277096457 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -191,18 +287,23 @@ class

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277096082 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277095974 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094820 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094550 ## File path: python/mxnet/gluon/contrib/estimator/event_handler.py ## @@ -16,85 +16,169 @@ # under the

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094415 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -226,111 +230,72 @@ def fit(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094389 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -226,111 +230,72 @@ def fit(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277094415 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -226,111 +230,72 @@ def fit(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-19 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r277092803 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -148,63 +145,70 @@ def

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-18 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r276809625 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -57,87 +60,85 @@ def __init__(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-18 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r276809625 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -57,87 +60,85 @@ def __init__(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-18 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r276809625 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -57,87 +60,85 @@ def __init__(self,

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14685: [Fit API] improve event handlers

2019-04-18 Thread GitBox
roywei commented on a change in pull request #14685: [Fit API] improve event handlers URL: https://github.com/apache/incubator-mxnet/pull/14685#discussion_r276809625 ## File path: python/mxnet/gluon/contrib/estimator/estimator.py ## @@ -57,87 +60,85 @@ def __init__(self,