[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-22 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-577440334 Yes, agree we need a script and the exclude rules for rat-check need to be revisited. We should avoid bulk exclusion entire folder. Anything in

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-17 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575873507 Now we have either created a PR to fix the above issues or contacted the original author to help with files we can't directly change.

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-17 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575873009 Hi @skylook , could you update your copyright on the file listed as No. 7 above?

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-16 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575294965 > @roywei Regarding [3], [4], do you think we need list the copyrights/license in MXNet top LICENSE file or ask MKL-DNN itself to change? I

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574913499 > @roywei thanks. When removing the ASF header from incubator-mxnet/cmake/Modules/FindCUDAToolkit.cmake, how to pass the RAT license check?

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574909620 > > @hzfan @reminisce @haojin2 Looks like we need to remove the ASF header if this file is directly copied from numpy, and add it to whitelist

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574887879 @aaronmarkham any idea how to fix the font files in #2? Can we move it to s3 and download it when building the docs?

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574831171 @hzfan @reminisce @haojin2 Looks like we need to remove the ASF header if this file is directly copied from numpy, and add it to whitelist of

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574829986 @PatricZhao could you help with the "Copyright 2019 Intel Corporation” and #3 and #4 under mkldnn? Thanks