gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-401345657
Thanks @yzhliu for your review. If you have any other questions, please let
me know 😄
-
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-401195172
Thanks @lanking520 for the review :) - In regards to the CNN text
classification, the example at the default is running on a limited dataset (to
fit
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-400656804
@larroy The CI Clojure unit tests now pass 😸
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-11205/22/
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-400496607
@larroy I added the CI in this commit, if you'd like to review it
https://github.com/apache/incubator-mxnet/pull/11205/commits/ad9792493dd9c2a92f0495
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-400392518
Question for @kurman @larroy @nswamy - Someone has a PR out on the main repo
for improving the style with cljfmt
https://github.com/gigasquid/clojur
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-400029200
Thanks @kurman - I appreciate you going through it, I realize that it is a
_big_ PR. I'll wait until you are done to address the feedback 😄
---
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399681165
@didibus I think I missed a point you were making in your last comment about
snapshot versions in regards to the README documentation of the test ver
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399594324
@nswamy @larroy I switched the project.clj to use the linux cpu version to
make it ready for CI.
@didibus - good point. A discussion needs to
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399588943
@larroy I just looked at the Jenkins CI pipeline. I see there is a scala cpu
and gpu tests right now. For the current clojure package, the tests are
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399579788
@larroy and @yzhliu - Thanks. Please let me know if there is anything I can
do to help the review and get this merged. I've been trying to keep this
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397834692
Thanks for taking the time to review @larroy 😸 I'll get to work on
incorporating your feedback.
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840
@kovasb Thanks so much for taking the time to review and providing such
insightful feedback and questions.
As far as corner cases go, I feel p
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840
@kovasb Thanks so much for taking the time to review and providing such
insightful feedback and questions.
As far as corner cases go, I feel p
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840
@kovasb Thanks so much for taking the time to review and providing such
insightful feedback and questions.
As far as corner cases go, I feel p
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-395978081
@kurman - I rewrote the commits into 2 parts - one with the main package and
tests and another with the examples. Please let me know if I can do anyt
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-395909871
@kurman sure - I will rewrite the commits and and push tomorrow (wrapping up
today 😄 )
-
gigasquid commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-395873681
@nswamy This is ready for review/feedback
This is an automated message from the Apac
17 matches
Mail list logo
