lebeg commented on issue #9727: Refactored storage handling
URL: https://github.com/apache/incubator-mxnet/pull/9727#issuecomment-368829675
I'll close this PR in favour of future more small and discreet changes that
are worth making.
lebeg commented on issue #9727: Refactored storage handling
URL: https://github.com/apache/incubator-mxnet/pull/9727#issuecomment-364234218
There might be another not thread safe, but simplified approach. Instead of
a shared_ptr we could use a unique_ptr. That does not have a interlocking
lebeg commented on issue #9727: Refactored storage handling
URL: https://github.com/apache/incubator-mxnet/pull/9727#issuecomment-364232860
Thank you @cjolivier01 and @piiswrong for your questions. Please find my
answers below:
> How many reference count changes occur for a given
lebeg commented on issue #9727: Refactored storage handling
URL: https://github.com/apache/incubator-mxnet/pull/9727#issuecomment-363878445
> What's the benefit of using shared_ptr for storage?
The ownership of memory storage::Handles are pointing to with their dptr is
protected
