[GitHub] zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-24 Thread GitBox
zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183632594 ## File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc ## @@ -32,6 +32,1

[GitHub] zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-24 Thread GitBox
zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183632343 ## File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc ## @@ -67,31 +73,

[GitHub] zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

2018-04-24 Thread GitBox
zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183631914 ## File path: src/operator/nn/mkldnn/mkldnn_convolution.cc ## @@ -88,26 +91,23