kasjer commented on a change in pull request #2319:
URL: https://github.com/apache/mynewt-core/pull/2319#discussion_r443343610
##
File path: hw/mcu/stm/stm32_common/syscfg.yml
##
@@ -262,3 +262,7 @@ syscfg.defs:
ADC_2:
description: "ADC_2"
value: 0
+
+
kasjer commented on pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647315906
Quick check of number of UARTs/USARTs on ST page reveals that STMF423 and
STMF413 (that has BSP in Mynewt) have 10 of them. While I don't have problem
with this code PR, titl
andrzej-kaczmarek commented on issue #834:
URL: https://github.com/apache/mynewt-nimble/issues/834#issuecomment-647308350
@lance-proxy I've seen this assert a few times when running qualification
testcases but also was not able to catch it on a debugger. there was a bit of
refactoring done
lance-proxy edited a comment on issue #834:
URL: https://github.com/apache/mynewt-nimble/issues/834#issuecomment-647180574
@sjanc @andrzej-kaczmarek this looks like the same assertion that was
attempted to be fixed by this PR:
https://github.com/apache/mynewt-nimble/pull/748 . Any help in
utzig commented on a change in pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#discussion_r443284324
##
File path: hw/drivers/crypto/src/mbedtls_aes_alt.c
##
@@ -41,8 +42,8 @@ mbedtls_aes_free(mbedtls_aes_context *ctx)
}
int
Review comment:
utzig commented on pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-647223559
I am under the impression that `mbedtls_aes_setkey_enc` and
`mbedtls_aes_setkey_dec` do the same thing, so maybe the code could be moved
into a single function? Nice catch on
utzig commented on a change in pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#discussion_r443282385
##
File path: hw/drivers/crypto/src/mbedtls_aes_alt.c
##
@@ -53,15 +54,59 @@ mbedtls_aes_setkey_enc(mbedtls_aes_context *ctx, const
unsigned char *key,
utzig commented on a change in pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#discussion_r443282280
##
File path: hw/drivers/crypto/src/mbedtls_aes_alt.c
##
@@ -53,15 +54,59 @@ mbedtls_aes_setkey_enc(mbedtls_aes_context *ctx, const
unsigned char *key,
utzig commented on a change in pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321#discussion_r443281296
##
File path: hw/mcu/stm/stm32_common/src/hal_uart.c
##
@@ -63,6 +63,37 @@ uart_by_port(int port)
if (port == 2) {
return &uarts[index];
apache-mynewt-bot commented on pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647187937
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot removed a comment on pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647185135
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647185135
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/
jeremywood opened a new pull request #2321:
URL: https://github.com/apache/mynewt-core/pull/2321
Adds support for configuring UART3-UART7, increasing the maximum number of
configurable UARTs on STM32 from 3 to 8.
This is an
lance-proxy commented on issue #834:
URL: https://github.com/apache/mynewt-nimble/issues/834#issuecomment-647180745
(I have not yet been able to repro this on the bench with the debugger
attached but as soon as I hit it, I will upload the full gdb backtrace).
-
lance-proxy commented on issue #834:
URL: https://github.com/apache/mynewt-nimble/issues/834#issuecomment-647180574
@sjanc @andrzej-kaczmarek this looks like the same assertion that was
attempted to be fixed by this PR:
https://github.com/apache/mynewt-nimble/pull/748 . Any help in fixing
lance-proxy opened a new issue #834:
URL: https://github.com/apache/mynewt-nimble/issues/834
Seeing an assert under load in ble_ll_scan_aux_data_unref in `ble_ll_scan.c`
at line 1079: nimble/blob/master/nimble/controller/src/ble_ll_scan.c#L1079,
running latest `master`, commit:
https://gi
apache-mynewt-bot commented on pull request #2319:
URL: https://github.com/apache/mynewt-core/pull/2319#issuecomment-647175262
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot removed a comment on pull request #2319:
URL: https://github.com/apache/mynewt-core/pull/2319#issuecomment-647060644
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot removed a comment on pull request #2320:
URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647162796
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #2320:
URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647171829
## Style check summary
No suggestions at this time!
This is an automat
alvarop commented on pull request #2320:
URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647162891
I have a couple of boards without a 32MHz crystal (No BLE) and this was the
simplest way I could think of of making them work without changing too much.
Open to sugge
apache-mynewt-bot commented on pull request #2320:
URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647162796
## Style check summary
No suggestions at this time!
This is an automat
alvarop opened a new pull request #2320:
URL: https://github.com/apache/mynewt-core/pull/2320
This is needed to be able to run NRF52 devices without an external 32MHz
crystal.
BLE will not work, but everything else should.
The only restriction is that the LFCLK source cannot be LF
23 matches
Mail list logo
