[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #406: newt info: Query each repo in parallel

2020-06-22 Thread GitBox
ccollins476ad opened a new pull request #406: URL: https://github.com/apache/mynewt-newt/pull/406 This isn't a huge speedup, but it's something. Example: Before ``` [ccollins@ccollins:~/repos/juul-steam]$ time newt info Apache Newt 1.9.0-dev / unknown / unknown

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2319: Add tickles sleep for STM32F1 CPU

2020-06-22 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2319: URL: https://github.com/apache/mynewt-core/pull/2319#issuecomment-647175262 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2319: Add tickles sleep for STM32F1 CPU

2020-06-22 Thread GitBox
apache-mynewt-bot commented on pull request #2319: URL: https://github.com/apache/mynewt-core/pull/2319#issuecomment-647784778 ## Style check summary No suggestions at this time! This is an

[mynewt-newt] branch master updated: Execute .sh scripts with bash on windows

2020-06-22 Thread ccollins
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git The following commit(s) were added to refs/heads/master by this push: new 8330e7f Execute .sh scripts with bash

[GitHub] [mynewt-newt] ccollins476ad merged pull request #403: Execute .sh scripts with bash on windows

2020-06-22 Thread GitBox
ccollins476ad merged pull request #403: URL: https://github.com/apache/mynewt-newt/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-newt] jipanienko commented on pull request #403: Execute .sh scripts with bash on windows

2020-06-22 Thread GitBox
jipanienko commented on pull request #403: URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647756603 @kasjer @ccollins476ad tested alrigt This is an automated message from the Apache Git Service. To respond

[GitHub] [mynewt-newt] kasjer commented on pull request #403: Execute .sh scripts with bash on windows

2020-06-22 Thread GitBox
kasjer commented on pull request #403: URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647754953 > Thanks @jipanienko, it looks good! I don't have a Windows machine handy to test this on. I assume you tried this and it worked for you? I use it for pre_build scripts

[GitHub] [mynewt-mcumgr] ccollins476ad opened a new issue #88: image list command doesn't work for split images

2020-06-22 Thread GitBox
ccollins476ad opened a new issue #88: URL: https://github.com/apache/mynewt-mcumgr/issues/88 Mynewt has the concept of "split images (http://mynewt.apache.org/latest/os/modules/split/split.html). Unlike for normal images, the split image state is stored in user flash, not in MCUboot

[GitHub] [mynewt-newt] ccollins476ad commented on issue #242: MingW/Windows path issue causes newt load to fail

2020-06-22 Thread GitBox
ccollins476ad commented on issue #242: URL: https://github.com/apache/mynewt-newt/issues/242#issuecomment-647692513 Closing this, as I believe @sjanc's suggestion solves the issue. Please reopen if there is still a problem.

[GitHub] [mynewt-newt] ccollins476ad closed issue #242: MingW/Windows path issue causes newt load to fail

2020-06-22 Thread GitBox
ccollins476ad closed issue #242: URL: https://github.com/apache/mynewt-newt/issues/242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-newt] ccollins476ad commented on issue #267: pkg.cflags from a dependency might be required by dependent packages

2020-06-22 Thread GitBox
ccollins476ad commented on issue #267: URL: https://github.com/apache/mynewt-newt/issues/267#issuecomment-647691460 I think newt's handling of `pkg.cflags` isn't ideal. Here is what newt does: 1. ```// Populate the base set of compiler flags. Flags from the following

[GitHub] [mynewt-newt] ccollins476ad commented on issue #366: Customize command for running test binaries

2020-06-22 Thread GitBox
ccollins476ad commented on issue #366: URL: https://github.com/apache/mynewt-newt/issues/366#issuecomment-647680571 Thanks @simonratner, that is an interesting idea. I'm wondering if the test package is the best place for the custom command to be specified. Ideally, a unit test

[GitHub] [mynewt-newt] ccollins476ad commented on issue #390: Error during execution of build.sh

2020-06-22 Thread GitBox
ccollins476ad commented on issue #390: URL: https://github.com/apache/mynewt-newt/issues/390#issuecomment-647675945 Thanks @KKopyscinski and @sjanc. I have submitted this PR: https://github.com/apache/mynewt-newt/pull/405

[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #405: build.sh: Invoke sh as a login shell

2020-06-22 Thread GitBox
ccollins476ad opened a new pull request #405: URL: https://github.com/apache/mynewt-newt/pull/405 This fixes #390 build.sh depends on the `go` executable. This executable may not be in the user's path when /bin/sh is invoked as a non-login shell (a non-login shell does not execute

[GitHub] [mynewt-newt] ccollins476ad commented on pull request #403: Execute .sh scripts with bash on windows

2020-06-22 Thread GitBox
ccollins476ad commented on pull request #403: URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647658607 Thanks @jipanienko, it looks good! I don't have a Windows machine handy to test this on. I assume you tried this and it worked for you?

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2321: Add support for all UARTS on STM32

2020-06-22 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2321: URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647187937 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2321: Add support for all UARTS on STM32

2020-06-22 Thread GitBox
apache-mynewt-bot commented on pull request #2321: URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647651623 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] jeremywood commented on pull request #2321: Add support for all UARTS on STM32

2020-06-22 Thread GitBox
jeremywood commented on pull request #2321: URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647643294 @kasjer Good catch on the STMF4XX support for 10 UARTS. I've searched across all of the STM headers, and that does appear to be the highest port count.

[GitHub] [mynewt-core] jeremywood commented on a change in pull request #2321: Add support for all UARTS on STM32

2020-06-22 Thread GitBox
jeremywood commented on a change in pull request #2321: URL: https://github.com/apache/mynewt-core/pull/2321#discussion_r443695117 ## File path: hw/mcu/stm/stm32_common/src/hal_uart.c ## @@ -63,6 +63,37 @@ uart_by_port(int port) if (port == 2) { return [index];

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2320: Add syscfg option to select HFCLK source for NRF52 devices

2020-06-22 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2320: URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647171829 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2320: Add syscfg option to select HFCLK source for NRF52 devices

2020-06-22 Thread GitBox
apache-mynewt-bot commented on pull request #2320: URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647574482 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] alvarop commented on pull request #2320: Add syscfg option to select HFCLK source for NRF52 devices

2020-06-22 Thread GitBox
alvarop commented on pull request #2320: URL: https://github.com/apache/mynewt-core/pull/2320#issuecomment-647571675 Updated the description/title to match the latest changes. This is an automated message from the Apache

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2294: mbedtls_aes_alt: add setkey for decyption, validate input, fix data type and return type

2020-06-22 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2294: URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-646989025 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2294: mbedtls_aes_alt: add setkey for decyption, validate input, fix data type and return type

2020-06-22 Thread GitBox
apache-mynewt-bot commented on pull request #2294: URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-647564379 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2319: Add tickelss sleep for STM32F1 CPU. Ticless sleep can be used when LSE

2020-06-22 Thread GitBox
kasjer commented on a change in pull request #2319: URL: https://github.com/apache/mynewt-core/pull/2319#discussion_r443343610 ## File path: hw/mcu/stm/stm32_common/syscfg.yml ## @@ -262,3 +262,7 @@ syscfg.defs: ADC_2: description: "ADC_2" value: 0 + +

[GitHub] [mynewt-core] kasjer commented on pull request #2321: Add support for all UARTS on STM32

2020-06-22 Thread GitBox
kasjer commented on pull request #2321: URL: https://github.com/apache/mynewt-core/pull/2321#issuecomment-647315906 Quick check of number of UARTs/USARTs on ST page reveals that STMF423 and STMF413 (that has BSP in Mynewt) have 10 of them. While I don't have problem with this code PR,

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #834: Assert at ble_ll_scan_aux_data_unref

2020-06-22 Thread GitBox
andrzej-kaczmarek commented on issue #834: URL: https://github.com/apache/mynewt-nimble/issues/834#issuecomment-647308350 @lance-proxy I've seen this assert a few times when running qualification testcases but also was not able to catch it on a debugger. there was a bit of refactoring