[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-28 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332837084 @wes3 Ok, I submitted PRs for those repos. This is an aut

[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-27 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332448729 Done. Please take another look. This is an automated mes

[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-26 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332285796 Sounds good. I'll make the changes when I'm back in the office tomorrow.

[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-26 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332232087 @wes3 That sounds sensible. What about LORA_SPI_CS_PIN, should this be in any of the BSPs other than telee02?

[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-26 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332214902 @andrzej-kaczmarek There was one other usage of SPI_0_MASTER_SS_PIN: apps/spitest. It's a bit odd that it now references L

[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.

2017-09-26 Thread git
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332208840 @andrzej-kaczmarek That's correct. I was a bit uncertain about where this should be defined. You are right, it makes sens