pkarashchenko commented on code in PR #1665:
URL: https://github.com/apache/nuttx-apps/pull/1665#discussion_r1142952982
##
testing/ostest/wqueue.c:
##
@@ -0,0 +1,188 @@
+/
+ * apps/testing/ostest/wqueue.
pkarashchenko commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477356024
> > > > Ok. Let's move on with this change if the new PR is ready. I do not
want to block the process despite I do not have a good explanation why this
can't be done in a single PR.
pkarashchenko commented on code in PR #1672:
URL: https://github.com/apache/nuttx-apps/pull/1672#discussion_r1142950589
##
netutils/ftpc/ftpc_connect.c:
##
@@ -276,5 +276,6 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
errout_with_socket:
ftpc_sockclose(&session-
anchao opened a new pull request, #8862:
URL: https://github.com/apache/nuttx/pull/8862
## Summary
syscall/libc: add more syscall/libc symbols into csv file
## Impact
N/A
## Testing
ci-check
--
This is an automated message from the Apache Git Service.
To
xiaoxiang781216 commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477353899
> > > Ok. Let's move on with this change if the new PR is ready. I do not
want to block the process despite I do not have a good explanation why this
can't be done in a single PR.
pkarashchenko commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1142941791
##
include/nuttx/serial/uart_16550.h:
##
@@ -330,6 +330,9 @@ typedef uint64_t uart_addrwidth_t;
* Public Functions Definitions
*
pkarashchenko commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477352976
> > Ok. Let's move on with this change if the new PR is ready. I do not want
to block the process despite I do not have a good explanation why this can't be
done in a single PR.
>
xiaoxiang781216 commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477350269
> Ok. Let's move on with this change if the new PR is ready. I do not want
to block the process despite I do not have a good explanation why this can't be
done in a single PR.
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from f57814999a fix typo cyles -> cycles
add 52525796ab openamp: libmetal compile pass with arm64 arch
No new r
pkarashchenko merged PR #8859:
URL: https://github.com/apache/nuttx/pull/8859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
pkarashchenko commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477348524
Ok. Let's move on with this change if the new PR is ready. I do not want to
block the process despite I do not have a good explanation why this can't be
done in a single PR.
--
Thi
pkarashchenko commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1141808005
##
arch/arm64/src/fvp-v8r/fvp_lowputc.S:
##
@@ -50,24 +50,6 @@
* Public Functions
/
anchao opened a new pull request, #8861:
URL: https://github.com/apache/nuttx/pull/8861
## Summary
libc/settimeofday: correct prototype of settimeofday()
https://man.openbsd.org/OpenBSD-5.9/settimeofday.2
## Impact
N/A
## Testing
ci-check
--
Th
no1wudi opened a new pull request, #8860:
URL: https://github.com/apache/nuttx/pull/8860
## Summary
This reverts commit 64e611d71eb31c401c28c3b31fa48a4170588abd.
## Impact
uart-rpmsg
## Testing
sim:rpserver/sim:rpproxy
Notice: This patch must works with
https://
no1wudi opened a new pull request, #1673:
URL: https://github.com/apache/nuttx-apps/pull/1673
## Summary
Let remote machine handle special character except Ctrl-C, make cu's
behavior more close to linux/bsd system.
## Impact
cu
## Testing
sim:rpserver/sim:rpproxy
--
Thi
wengzhe opened a new pull request, #1672:
URL: https://github.com/apache/nuttx-apps/pull/1672
## Summary
The timer is for connect timeout, but is not cancelled on connect error,
then it may be triggered after ftpc quit and cause heap-use-after-free.
## Impact
ftpc won't trigger
wengzhe commented on code in PR #8610:
URL: https://github.com/apache/nuttx/pull/8610#discussion_r1142859285
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -66,288 +66,161 @@
#include
#include
#include
-#include
+#include
#include
#include "sim_internal.h"
-#if CONFIG
CV-Bowen opened a new pull request, #8859:
URL: https://github.com/apache/nuttx/pull/8859
## Summary
Error log:
```c
/home/wangbowen/project/community/nuttx_rpmsg_server/nuttx/include/metal/cpu.h:15:11:
fatal error: metal/processor/arm64/cpu.h: No such file or directory
15 |
qinwei2004 commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1477211242
@pkarashchenko ，My new patch must wait for this patch to be merged.
at new patch, I will call assembly code directly
--
This is an automated message from the Apache Git Servi
no1wudi commented on PR #1671:
URL: https://github.com/apache/nuttx-apps/pull/1671#issuecomment-1477198328
> what would be the implementation? :-)
Emm, the implementation is in WAMR side
https://github.com/bytecodealliance/wasm-micro-runtime/pull/2042 and already
done, just need a op
cederom commented on PR #1671:
URL: https://github.com/apache/nuttx-apps/pull/1671#issuecomment-1477196271
what would be the implementation? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
no1wudi opened a new pull request, #1671:
URL: https://github.com/apache/nuttx-apps/pull/1671
## Summary
New option to dump call stack
## Impact
WAMR only
## Testing
QEMU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
patacongo opened a new issue, #8858:
URL: https://github.com/apache/nuttx/issues/8858
adjtime() is implemented in sched/clock/clock_timekeeping. A quick review
reveals several problems:
1. Missing system call. The implemented of adjtime() is provided, but there
is no call gate impl
realprocrastinator opened a new issue, #8857:
URL: https://github.com/apache/nuttx/issues/8857
In `fd/vfs/fs_poll.c`, the semaphore object is allocated on the stack
meaning that its memory is valid until this function returns. However, there is
a `poll_default_cb()` which may also access th
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new a4763dfb Publishing web: b50f5ca4
pkarashchenko merged PR #8855:
URL: https://github.com/apache/nuttx/pull/8855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f57814999a fix typo cyles -> cycles
f57814
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 3a1893ba7 nxplayer: read file completely u
masayuki2009 merged PR #1652:
URL: https://github.com/apache/nuttx-apps/pull/1652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fab77cd322 drivers/pty: Echo input by default
f
masayuki2009 merged PR #8846:
URL: https://github.com/apache/nuttx/pull/8846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
TimJTi commented on code in PR #8789:
URL: https://github.com/apache/nuttx/pull/8789#discussion_r1142676546
##
include/nuttx/sensors/apds9922.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/sensors/apds9922
TimJTi commented on code in PR #8789:
URL: https://github.com/apache/nuttx/pull/8789#discussion_r1142675186
##
drivers/sensors/apds9922.c:
##
@@ -0,0 +1,2598 @@
+/
+ * drivers/sensors/apds9922.c
+ *
+ *
TimJTi commented on code in PR #8789:
URL: https://github.com/apache/nuttx/pull/8789#discussion_r1142674775
##
include/nuttx/sensors/apds9922.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/sensors/apds9922
TimJTi commented on code in PR #8789:
URL: https://github.com/apache/nuttx/pull/8789#discussion_r1142674294
##
.gitignore:
##
@@ -59,3 +59,4 @@ uImage
.dirlinks
.vscode
.DS_Store
+nuttx Default (copy).launch
Review Comment:
Nope - sometimes my git commits include this and
pkarashchenko commented on code in PR #8789:
URL: https://github.com/apache/nuttx/pull/8789#discussion_r1142670739
##
.gitignore:
##
@@ -59,3 +59,4 @@ uImage
.dirlinks
.vscode
.DS_Store
+nuttx Default (copy).launch
Review Comment:
I'm not sure if we should commit this
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d4e6d9ab77 xtensa/esp32: Update bootloader
pkarashchenko merged PR #8838:
URL: https://github.com/apache/nuttx/pull/8838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
pkarashchenko commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1476868098
Since this code is located in the header file we can go with this fix, but
maybe it is worth putting a comment in the code as init is actually not needed.
--
This is an automated me
pkarashchenko commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1476864829
In general GCC 12 gives many false positive warnings like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ldube commented on PR #8854:
URL: https://github.com/apache/nuttx/pull/8854#issuecomment-1476846532
@acassis, I would like to see the iPAQ running NuttX too. If I find an
excuse to do the port I will.
--
This is an automated message from the Apache Git Service.
To respond to the message,
TheCranston commented on issue #8839:
URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1476799693
Ok. much bisecting later I believe, if I'm doing this correctly, I have
the commit in question.
```
fa6ea23101bf9470253c2f60ca422027abdef537 is the first bad commit
MaEtUgR opened a new pull request, #8856:
URL: https://github.com/apache/nuttx/pull/8856
## Summary
arm-none-eabi-gcc 12.2.0 gives the following warning:
error: 'primask' is used uninitialized
We use Werror and the file is indirectly included in different
places. I suggest ini
christianrauch opened a new pull request, #8855:
URL: https://github.com/apache/nuttx/pull/8855
## Summary
Fix a typo.
## Impact
None.
## Testing
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
TheCranston commented on issue #8839:
URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1476679159
git bisect log.. not sure if this helps
```
$ git bisect log
git bisect start
# status: waiting for both good and bad commits
# good: [725bdfb0e8c704823669d20931fd
TheCranston commented on issue #8839:
URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1476668405
Looks like the issue is potentially here (If I did the git bisect thing
correctly)
```
561cbbca96a749e4d2e9ec2ea672f257dc5348aa is the first bad commit
commit 561cbbca9
acassis commented on PR #8854:
URL: https://github.com/apache/nuttx/pull/8854#issuecomment-1476662047
Hi @ldube thank you for finding and fixing this issue! I took a look at your
github and discovered your iPaq H3800 eCos port (not EcoSport hehehe). That was
inspiring, maybe it could be a g
ldube opened a new pull request, #8854:
URL: https://github.com/apache/nuttx/pull/8854
Choose a divider value that matches the description provided within the same
header file.
Include stddef.h to fix compiler errors because NULL is not defined. Make
logs print protocol, vid and pid cons
pkarashchenko commented on code in PR #8726:
URL: https://github.com/apache/nuttx/pull/8726#discussion_r1142239721
##
arch/arm/src/phy62xx/uart.h:
##
@@ -165,7 +165,12 @@ int hal_uart_set_tx_buf(UART_INDEX_e uart_index, uint8_t
*buf,
uint16_t size);
int hal_uart_get_tx_re
gustavonihei commented on issue #8853:
URL: https://github.com/apache/nuttx/issues/8853#issuecomment-1476374477
Also reproducible with `sim:lvgl_lcd` and `sim:lvgl_fb`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
pkarashchenko commented on code in PR #8610:
URL: https://github.com/apache/nuttx/pull/8610#discussion_r1142223643
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -66,288 +66,161 @@
#include
#include
#include
-#include
+#include
#include
#include "sim_internal.h"
-#if
pkarashchenko commented on code in PR #8783:
URL: https://github.com/apache/nuttx/pull/8783#discussion_r1142216503
##
arch/xtensa/src/esp32/esp32_spiflash.c:
##
@@ -460,6 +514,33 @@ static inline void IRAM_ATTR
leave_critical_section(state->flags);
}
+/
pkarashchenko commented on PR #8836:
URL: https://github.com/apache/nuttx/pull/8836#issuecomment-1476339863
@tmedicci I've tested many Xtensa configurations today (definitely not all
available). Could you please try this PR? The issues in `esp32-devkitc:audio`
and `:cxx` are fixed now
--
pkarashchenko opened a new issue, #8853:
URL: https://github.com/apache/nuttx/issues/8853
I tried to run
```
./tools/configure.sh esp32-wrover-kit:lvgl
make
make distclean
```
and got next output with `distclean`:
```
make distclean
find: ./lvgl/demos: No such file
slorquet commented on PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#issuecomment-1476320351
Thanks for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 947100c5b8 sim: Fix iic/spi bus open failed
add 13d823f307 spi_xx25xx: Repair the spi bus locking mechanism when
btashton merged PR #8852:
URL: https://github.com/apache/nuttx/pull/8852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
slorquet commented on PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#issuecomment-1476286307
it does not really matter. this is just frustration to see small fixes
included fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
pkarashchenko commented on PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#issuecomment-1476282232
> Why are test faster today? Last time it took two days.
I'm not sure what PR are you referring to. Sometimes CI is stopped due to
various failures like HTTP timeout during down
slorquet commented on PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#issuecomment-1476275559
Why are test faster today? Last time it took two days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 947100c5b8 sim: Fix iic/spi bus open faile
pkarashchenko merged PR #8850:
URL: https://github.com/apache/nuttx/pull/8850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 7560a5e80d9ec77b00fa04b9cb78402db88a2b9f
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 17103a6b3d89830abdc8629262744e44b7583d56
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit af4e1777229e6be72044520f4574b55b99d460f4
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit b2d24f76885873d06ed8e37fea27d85e1aef0643
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 6978a65293590f6c64d0213fcfdf9d0a754d1e4d
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit d3c3a6ebe08fe38c67083a6c92e97dd8cc102d72
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 98a161820218c038c938593007d249e8b394f284
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 4b401d95b11ee2dfb6d250945572f478e5926ede
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 27a17df69d00117ad4e8e89ae354a7c358e7cf06
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 6529e74326850ec657096a96c75e8f6c1c8439cf
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 804762c72d1fc5b27d6ae46f17345fc6fb009bf5
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 8bc93e07cef1e214687387d7a896d86663db7a9a
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 257719d65aabdf096e6ac7753e8da47c32221137
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit b2f1ab31c7635e908aca366a9fc1fd733de0e17f
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit e1357fa6c9876788c9ea10d38924c293643a6c4e
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 79b72c030227f6ad7b7b3d5ea3a4f257e8cec852
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 2c2577fc753675b24a6138d717e333c566a55728
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit a75dd4be405afd2584c06b0f6532745b5f7f57c9
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 5736d2adfde113d365329816ded238fda6af54d0
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 585d0e083b1be405d05d022a1a127083ed3e
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit cf0ee4354c091fd621d7c3ec00d568b472968622
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
from f3c104b99 Fix nxstyle warning
new 6978a6529 apps/netutils/codecs/Make.defs: fix nxstyle
new 5736d
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 19d6f4076734adcdf57501240fbb0780f245b2b1
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 5137e6f3db8510923503aa55646a7eb8a94e1e43
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
Author
pkarashchenko merged PR #1670:
URL: https://github.com/apache/nuttx-apps/pull/1670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@n
gustavonihei commented on code in PR #1649:
URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1142062330
##
industry/foc/float/foc_handler.c:
##
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
Review Comment:
Yes. I don't recall the exact warning
pussuw commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142052695
##
nshlib/nsh_alias.c:
##
@@ -0,0 +1,454 @@
+/
+ * apps/nshlib/nsh_alias.c
+ *
+ * License
pussuw commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142051723
##
nshlib/nsh.h:
##
@@ -715,6 +715,25 @@ struct nsh_parser_s
#endif
};
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alias_s
+{
+ FAR struct nsh_alias_s *next;/* Sing
pussuw commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142049374
##
nshlib/nsh_parse.c:
##
@@ -331,6 +372,57 @@ static void nsh_memlist_free(FAR struct nsh_memlist_s
*memlist)
}
#endif
+/***
slorquet commented on code in PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#discussion_r1142049166
##
drivers/eeprom/spi_xx25xx.c:
##
@@ -392,6 +393,7 @@ static void ee25xx_waitwritecomplete(struct ee25xx_dev_s
*priv)
/* Deselect the FLASH */
SPI_SELE
gustavonihei commented on code in PR #8783:
URL: https://github.com/apache/nuttx/pull/8783#discussion_r1142046038
##
arch/xtensa/src/esp32/esp32_spiflash.c:
##
@@ -1470,6 +1551,219 @@ static int IRAM_ATTR esp32_readdata_encrypted(
return OK;
}
+/***
gustavonihei commented on code in PR #8783:
URL: https://github.com/apache/nuttx/pull/8783#discussion_r1142045606
##
arch/xtensa/src/esp32/esp32_spiflash.c:
##
@@ -1470,6 +1551,219 @@ static int IRAM_ATTR esp32_readdata_encrypted(
return OK;
}
+/***
pkarashchenko commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142016064
##
nshlib/nsh_alias.c:
##
@@ -0,0 +1,454 @@
+/
+ * apps/nshlib/nsh_alias.c
+ *
+ *
pkarashchenko commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142014300
##
nshlib/nsh.h:
##
@@ -715,6 +715,25 @@ struct nsh_parser_s
#endif
};
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alias_s
+{
+ FAR struct nsh_alias_s *next;
pussuw commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1142010456
##
nshlib/nsh.h:
##
@@ -715,6 +715,25 @@ struct nsh_parser_s
#endif
};
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alias_s
+{
+ FAR struct nsh_alias_s *next;/* Sing
pkarashchenko commented on code in PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#discussion_r1142008319
##
drivers/eeprom/spi_xx25xx.c:
##
@@ -392,6 +393,7 @@ static void ee25xx_waitwritecomplete(struct ee25xx_dev_s
*priv)
/* Deselect the FLASH */
SPI
pkarashchenko commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1141999277
##
nshlib/nsh.h:
##
@@ -715,6 +715,25 @@ struct nsh_parser_s
#endif
};
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alias_s
+{
+ FAR struct nsh_alias_s *next;
slorquet opened a new pull request, #8852:
URL: https://github.com/apache/nuttx/pull/8852
## Summary
The spi_xx25xx EEPROM driver had a bug (probably from its inception in 2014)
where the waitwritecomplete() function was expected to be called within an SPI
bus exclusion lock, but it was
1 - 100 of 141 matches
Mail list logo
