[PR] bcm2711/i2c: Implement I2C support for all user-accessible interfaces [nuttx]

2025-09-12 Thread via GitHub
linguini1 opened a new pull request, #17012: URL: https://github.com/apache/nuttx/pull/17012 ## Summary Initial I2C implementation such that I2C sending and receiving now works well enough to use the BMP280 driver for a BMP280 device connected to any of I2C0-I2C6 on the default pins.

Re: [I] [FEATURE] Complete RPi 4B I2C driver [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on issue #16937: URL: https://github.com/apache/nuttx/issues/16937#issuecomment-3287306104 Confirmed I2C operation is correct for the BMP280 on I2C1 and I2C0 using the default pins. I don't expect to be able to use other alternates out of the box without knowing the spec

Re: [PR] [GSoC2025] Add Silicon Heaven protocol adaptation into NuttX and SHV examples [nuttx-apps]

2025-09-12 Thread via GitHub
zdebanos commented on PR #3170: URL: https://github.com/apache/nuttx-apps/pull/3170#issuecomment-3287359246 Thanks to Pavel Pisa, the `Makefile` system adjusts better to the build system used in the `shv-libs4c` library. As discussed in the heading, we have also successfully separated the `

Re: [I] [FEATURE] Complete RPi 4B I2C driver [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on issue #16937: URL: https://github.com/apache/nuttx/issues/16937#issuecomment-3287322126 I2C3 works with default pins: ```console nsh> i2c dev -b 3 00 77 NOTE: Some devices may not appear with this scan. You may also try a scan with the -z flag to discove

Re: [PR] arch/arm/stm32h5: ADC Driver Improvements (Watchdog and Channel Structure) [nuttx]

2025-09-12 Thread via GitHub
kywwilson11 commented on PR #17007: URL: https://github.com/apache/nuttx/pull/17007#issuecomment-3286762957 I ended up formatting per the below image. Used the procedure from the PR with some minor changes. Going to re-push in a minute. Following this PR, in a few days I will be addi

[PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine opened a new pull request, #17010: URL: https://github.com/apache/nuttx/pull/17010 ## Summary This is to support applications sercon and serdis also in CONFIG_BUILD_KERNEL. In memory protected build, there is no place in user side to store the device. But when using sy

Re: [I] [FEATURE] `CONFIG_BOARD_LOOPSPERMSEC` should not have a default value [nuttx]

2025-09-12 Thread via GitHub
acassis commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3286933899 @tinnedkarma I didn't test it, but I think different optimization levels also will change this value. So it is better to keep it as config specific. -- This is an automated message

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
acassis commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3286926271 > @acassis @jerpelea do you think this change would be considered a "breaking change"? No, it is not. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3286922030 @acassis @jerpelea do you think this change would be considered a "breaking change"? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
acassis commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3286913868 > MSVC failure appears unrelated. @simbit18 you are the MS guy, any idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344650211 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [I] [FEATURE] `CONFIG_BOARD_LOOPSPERMSEC` should not have a default value [nuttx]

2025-09-12 Thread via GitHub
tinnedkarma commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3286755901 I am a bit late to this discussion, so maybe I'll take my input as a side note. * `CONFIG_BOARD_LOOPSPERMSEC` is in the "System Type" menu (arch/Kconfig file), also the only "

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3286785774 MSVC failure appears unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] system/cdcacm: Support sercon and serdis in CONFIG_BUILD_KERNEL [nuttx-apps]

2025-09-12 Thread via GitHub
jlaitine opened a new pull request, #3179: URL: https://github.com/apache/nuttx-apps/pull/3179 ## Summary - Put sercon and serdis in separate source files, so that the main functions can be compiled in also in kernel build. - Don't store the ttyacm handle in the application, it

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
acassis commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3286478732 @linguini1 instead of suggesting searching for CONFIG_BOARD_LOOPSPERMSEC I suggest search for calib_udelay because there is not a page dedicated to CONFIG_BOARD_LOOPSPERMSEC and when sear

Re: [PR] arch/arm/stm32h5: ADC Driver Improvements (Watchdog and Channel Structure) [nuttx]

2025-09-12 Thread via GitHub
acassis commented on code in PR #17007: URL: https://github.com/apache/nuttx/pull/17007#discussion_r2345166623 ## Documentation/platforms/arm/stm32h5/boards/nucleo-h563zi/index.rst: ## @@ -140,6 +140,17 @@ This configuration configures ADC1_IN3 and ADC1_IN10, which can be acce

Re: [I] [FEATURE] `CONFIG_BOARD_LOOPSPERMSEC` should not have a default value [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3286419764 > Ah, so we are talking about "default" value, not the ones in the existing boards configurations.. that is when you create a new board this error will pop up right (except code is

Re: [I] [FEATURE] `CONFIG_BOARD_LOOPSPERMSEC` should not have a default value [nuttx]

2025-09-12 Thread via GitHub
cederom commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3286405749 Ah, so we are talking about "default" value, not the ones in the existing boards configurations.. that is when you create a new board this error will pop up right (except code is cop

Re: [PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
linguini1 commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3285871269 Looks like there are some defconfigs using the default value. Good to catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344659956 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344659956 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344650211 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344659956 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344659956 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

Re: [PR] cdcacm: When using system_cdcacm, store the handle in kernel [nuttx]

2025-09-12 Thread via GitHub
jlaitine commented on code in PR #17010: URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344650211 ## boards/boardctl.c: ## @@ -133,16 +133,25 @@ static inline int case BOARDIOC_USBDEV_CONNECT:/* Connect the CDC/ACM device */ #ifndef CONFIG_CDCACM_

[PR] arch/delays: Set invalid default value for BOARD_LOOPSPERMSEC [nuttx]

2025-09-12 Thread via GitHub
linguini1 opened a new pull request, #17011: URL: https://github.com/apache/nuttx/pull/17011 ## Summary To resolve #17004, this commit sets the default Kconfig value for `CONFIG_BOARD_LOOPSPERMSEC` as -1, which is invalid. It statically asserts at compile time that the value is great

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
simbit18 commented on code in PR #17008: URL: https://github.com/apache/nuttx/pull/17008#discussion_r2344252312 ## arch/xtensa/src/common/espressif/Kconfig: ## @@ -1288,49 +1319,182 @@ config ESPRESSIF_WIFI_ENABLE_SAE_H2E ---help--- Select this option to

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
simbit18 commented on code in PR #17008: URL: https://github.com/apache/nuttx/pull/17008#discussion_r2344248120 ## arch/xtensa/src/common/espressif/Kconfig: ## @@ -1288,49 +1319,182 @@ config ESPRESSIF_WIFI_ENABLE_SAE_H2E ---help--- Select this option to

Re: [PR] drivers/net/mdio: add mdio bus [nuttx]

2025-09-12 Thread via GitHub
xiaoxiang781216 commented on PR #16999: URL: https://github.com/apache/nuttx/pull/16999#issuecomment-3285065905 i will review the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
fdcavalcanti commented on PR #17008: URL: https://github.com/apache/nuttx/pull/17008#issuecomment-3284980965 @acassis I think a "check other occurrences" would have sufficed! :) But thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
acassis commented on PR #17008: URL: https://github.com/apache/nuttx/pull/17008#issuecomment-3284998572 > @acassis I think a "check other occurrences" would have sufficed! :) But thanks for the review. Agreed! Or just "s/if (ret)/if (ret < 0)/g" if you use a good editor :-D --

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
acassis commented on code in PR #17008: URL: https://github.com/apache/nuttx/pull/17008#discussion_r2344003589 ## arch/xtensa/src/common/espressif/esp_wifi_event_handler.c: ## @@ -0,0 +1,359 @@ +/ + * ar

Re: [PR] drivers/net/mdio: add mdio bus [nuttx]

2025-09-12 Thread via GitHub
acassis commented on PR #16999: URL: https://github.com/apache/nuttx/pull/16999#issuecomment-3284970521 ping @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] [FEATURE] `CONFIG_BOARD_LOOPSPERMSEC` should not have a default value [nuttx]

2025-09-12 Thread via GitHub
acassis commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3284927058 @linguini1 I agree that the initial value should be -1 and in build time we detect it and throw an error point to developer creating the new board to calibrate it following the instr

Re: [PR] arch/arm/stm32h5: ADC Driver Improvements (Watchdog and Channel Structure) [nuttx]

2025-09-12 Thread via GitHub
simbit18 commented on PR #17007: URL: https://github.com/apache/nuttx/pull/17007#issuecomment-3284237527 ``` Configuration/Tool: nucleo-h563zi/adc,CONFIG_ARM_TOOLCHAIN_CLANG 2025-09-11 20:12:53

Re: [PR] doc: Update the CONTRIBUTING.md to follow Conventional Commits [nuttx]

2025-09-12 Thread via GitHub
jerpelea commented on PR #16823: URL: https://github.com/apache/nuttx/pull/16823#issuecomment-3270550850 @acassis please modify the PR to include ! in both the commit and PR title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

(nuttx) branch master updated (ba5dd64b64c -> 778f3fa39c9)

2025-09-12 Thread simbit18
This is an automated email from the ASF dual-hosted git repository. simbit18 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ba5dd64b64c docs/rx65n-rsk2mb: Migrate README.txt to rst format add 778f3fa39c9 arch/tricore: allow user defined

Re: [PR] arch/xtensa: refactor Wi-Fi driver for ESP32|S2|S3 [nuttx]

2025-09-12 Thread via GitHub
simbit18 commented on code in PR #17008: URL: https://github.com/apache/nuttx/pull/17008#discussion_r2343356918 ## arch/xtensa/src/common/espressif/Kconfig: ## @@ -1288,49 +1319,182 @@ config ESPRESSIF_WIFI_ENABLE_SAE_H2E ---help--- Select this option to

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-12 Thread via GitHub
leducp commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3284043810 Good work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc