tmedicci commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2473872140
> Just to add some details: I forgot to mention that our internal CI enables
`CONFIG_DEBUG_ASSERTIONS`. This makes total difference to the test. I tried
with and without applying the
tmedicci commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2471387685
Just to add some details: I forgot to mention that our internal CI enables
`CONFIG_DEBUG_ASSERTIONS`. This makes total difference to the test. I tried
with and without applying the fo
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2470977412
> I tested with real hardware. Don't you have one at your disposal? I can
try on QEMU too later.
ok, will try on hardware later
--
This is an automated message from the
tmedicci commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2470865301
> @tmedicci `esp32s3-devkit:smp(QEMU)` ostest passed
>
> ```shell
> ./tools/configure.sh -l esp32s3-devkit:smp
> # Enable ESP32S3_MERGE_BINS
> # Enable ESP32S3_QEMU_IMAG
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2470624254
@tmedicci `esp32s3-devkit:smp(QEMU)` ostest passed
```bash
./tools/configure.sh -l esp32s3-devkit:smp
# Enable ESP32S3_MERGE_BINS
qemu-system-xtensa -nographic -ma
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2470439126
@tmedicci Still has errors with `esp32s3-devkit:smp`
1. nuttx.merged.bin: no such file - Enable `ESP32S3_MERGE_BINS` to gen
2. only 2, 4, 8, 16 MB flash images are support
masayuki2009 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2470140482
> But don`t know how to generate the "qemu_efuse.bin". @masayuki2009
@tmedicci Do you know where has the quickstart doc? thank you;-)
https://github.com/apache/nuttx/pul
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2469883376
> > Hi @JianyuWang0623 !
> > This PR broke `esp32s3-devkit:smp`'s `ostest` just like reported at
[apache/nuttx#14611
(comment)](https://github.com/apache/nuttx/pull/14611#iss
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2468769927
> Hi @JianyuWang0623 !
>
> This PR broke `esp32s3-devkit:smp`'s `ostest` just like reported at
[apache/nuttx#14611
(comment)](https://github.com/apache/nuttx/pull/14611#i
tmedicci commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2468682704
Perhaps @hujun260 may have a clue here too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tmedicci commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2468680453
Hi @JianyuWang0623 !
This PR broke `esp32s3-devkit:smp`'s `ostest` just like reported at
https://github.com/apache/nuttx/pull/14611#issuecomment-2457181253 (it is the
same beha
xiaoxiang781216 merged PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2466821367
> please rebase to the last master which fix the ci error.
1. Rebased to master;
2. "sh -c" related updated : restore from split args to concat args(copy
from the exist
xiaoxiang781216 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2466815940
please rebase to the last master which fix the ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1835725358
##
nshlib/nsh_parse.c:
##
@@ -2647,6 +2673,81 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
param.oflags_in
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1813195268
##
nshlib/nsh_parse.c:
##
@@ -2435,9 +2469,23 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
sched_note_beginex(NOTE_TAG
lupyuen commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2465012122
@acassis Could you please review the PR? I tested OK on Ubuntu. Thanks!
- https://github.com/apache/nuttx/pull/14705
--
This is an automated message from the Apache Git Service.
To
lupyuen commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464996978
Thanks @simbit18 I'm preparing the patch, switching to
https://cxx.uclibc.org. The busybox cert just expired today sigh.
--
This is an automated message from the Apache Git Service.
simbit18 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464973344
> @simbit18 Any idea why we're not using
https://cxx.uclibc.org/src/uClibc++-0.2.5.tar.xz? The SSL Cert here is OK,
unlike https://git.busybox.net/
@lupyuen I have no idea !
lupyuen commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464949731
@simbit18 Any idea why we're not using
https://cxx.uclibc.org/src/uClibc++-0.2.5.tar.xz? The SSL Cert here is OK,
unlike https://git.busybox.net/
--
This is an automated message fro
simbit18 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464944392
@lupyuen
https://github.com/apache/nuttx/blob/db31e569579c7ec9753d5fb69d07e8f997c7eae1/libs/libxx/uClibc%2B%2B/Make.defs#L27
--
This is an automated message from the Apache
lupyuen commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464932737
@JianyuWang0623 I have cloned your branch to my repo and [enabled all
builds](https://github.com/nuttxpr2/nuttx-apps/commit/47b59221f5fdd7ff014ad46fecc312041e855ef6).
Please check this
lupyuen commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464921737
Sorry @simbit18: Do you know where uClibc is hosted? How is it imported into
our build? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message
acassis commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464917169
@lupyuen please take a look, seems like uClibc web page certificate expired.
I think we need to move these files to our mirrot at github.com/nuttx
--
This is an automated message fro
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2464653270
Error of CI may be not related
```
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.se/docs/sslcerts.html
curl failed to
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2463796322
Link https://github.com/apache/nuttx-apps/pull/2831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2458899657
> ping :-) i have restarted CI for verification, is this PR ready for
review? :-)
Thank you, but this PR is not ready yet.
e.g. NSH will block if pipe buffer full fille
cederom commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2453017052
ping :-) i have restarted CI for verification, is this PR ready for review?
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2428272363
> @JianyuWang0623 please fix the conflict.
@xiaoxiang781216 done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xiaoxiang781216 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2428110152
@JianyuWang0623 please fix the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1808100438
##
nshlib/nsh_parse.c:
##
@@ -2658,12 +2658,12 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
int argc;
int
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1808088440
##
nshlib/nsh_parse.c:
##
@@ -2658,12 +2658,12 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
int argc;
int
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807896564
##
nshlib/nsh_fileapps.c:
##
@@ -107,39 +106,46 @@ int nsh_fileapp(FAR struct nsh_vtbl_s *vtbl, FAR const
char *cmd,
goto errout_with_actions;
}
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807896669
##
nshlib/nsh_parse.c:
##
@@ -1047,6 +1058,15 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline,
F
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807897165
##
nshlib/nsh_parse.c:
##
@@ -2623,12 +2654,15 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
};
int argc;
-
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807897094
##
nshlib/nsh_parse.c:
##
@@ -2466,7 +2487,7 @@ static int nsh_nice(FAR struct nsh_vtbl_s *vtbl, FAR char
**ppcmd,
#ifdef CONFIG_NSH_CMDPARMS
static int
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807897107
##
nshlib/nsh_parse.c:
##
@@ -2593,9 +2613,15 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
FAR char *argv[MAX_ARGV_ENTR
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2425132841
Reverted to the latest reviewed version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807292598
##
nshlib/nsh_parse.c:
##
@@ -2593,9 +2613,15 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
FAR char *argv[MAX_ARGV_ENT
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1805958188
##
include/builtin/builtin.h:
##
@@ -30,6 +30,7 @@
#include
#include
+#include "nshlib/nshlib.h"
Review Comment:
Done (and nshlib/nsh.h).
--
Thi
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1805927904
##
include/builtin/builtin.h:
##
@@ -30,6 +30,7 @@
#include
#include
+#include "nshlib/nshlib.h"
Review Comment:
#include
--
This is an automa
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1805912742
##
include/nshlib/nshlib.h:
##
@@ -65,6 +65,25 @@
# define SCHED_NSH SCHED_FIFO
#endif
+struct nsh_exec_param_s
Review Comment:
> but we can put it i
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1805705994
##
include/nshlib/nshlib.h:
##
@@ -65,6 +65,25 @@
# define SCHED_NSH SCHED_FIFO
#endif
+struct nsh_exec_param_s
Review Comment:
but we can put it in
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1804027152
##
nshlib/Kconfig:
##
@@ -231,6 +231,23 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+
acassis commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803491049
##
nshlib/Kconfig:
##
@@ -231,6 +231,23 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+ def
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803424091
##
nshlib/nsh_fileapps.c:
##
@@ -70,8 +70,7 @@
/
int nsh_fileapp(FAR struct n
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803423414
##
nshlib/nsh_fileapps.c:
##
@@ -107,39 +106,46 @@ int nsh_fileapp(FAR struct nsh_vtbl_s *vtbl, FAR const
char *cmd,
goto errout_with_actions;
}
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803423152
##
include/nshlib/nshlib.h:
##
@@ -65,6 +65,25 @@
# define SCHED_NSH SCHED_FIFO
#endif
+struct nsh_exec_param_s
Review Comment:
> why put into public
acassis commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803105059
##
nshlib/Kconfig:
##
@@ -231,6 +231,13 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+ def
xiaoxiang781216 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1803068523
##
nshlib/nsh_fileapps.c:
##
@@ -107,39 +106,46 @@ int nsh_fileapp(FAR struct nsh_vtbl_s *vtbl, FAR const
char *cmd,
goto errout_with_actions;
}
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1802225430
##
nshlib/Kconfig:
##
@@ -231,6 +231,13 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1802225430
##
nshlib/Kconfig:
##
@@ -231,6 +231,13 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1802225430
##
nshlib/Kconfig:
##
@@ -231,6 +231,13 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+
acassis commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801830433
##
nshlib/Kconfig:
##
@@ -231,6 +231,13 @@ config NSH_ALIAS_MAX_AMOUNT
endif # NSH_ALIAS
+config NSH_PIPELINE
+ bool "Enable pipeline support"
+ def
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801539589
##
nshlib/nsh_parse.c:
##
@@ -1060,9 +1080,9 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl,
FAR char *cmdline,
/* Create a unique file nam
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801561039
##
nshlib/nsh_parse.c:
##
@@ -1060,9 +1080,9 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl,
FAR char *cmdline,
/* Create a unique file nam
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801539589
##
nshlib/nsh_parse.c:
##
@@ -1060,9 +1080,9 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl,
FAR char *cmdline,
/* Create a unique file nam
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801533764
##
nshlib/nsh_parse.c:
##
@@ -2592,16 +2619,27 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
FAR char *argv[MAX_ARGV_ENT
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2414477011
The commit 11008cbc3021f15b304a7b4ad67b4bc379f28b4f is only for CI testing,
will be removed later.
--
This is an automated message from the Apache Git Service.
To respond to t
JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801459662
##
nshlib/nsh_parse.c:
##
@@ -279,6 +279,7 @@ static const char g_arg_separator[] = "`$";
static const char g_redirect_out1[] = ">";
static const char g
GUIDINGLI commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801239463
##
nshlib/nsh_parse.c:
##
@@ -279,6 +279,7 @@ static const char g_arg_separator[] = "`$";
static const char g_redirect_out1[] = ">";
static const char g_redi
JianyuWang0623 commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2413955035
Link https://github.com/apache/nuttx-apps/pull/2469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nuttxpr commented on PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#issuecomment-2413876099
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR partially meets the NuttX requirements.
JianyuWang0623 opened a new pull request, #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737
## Summary
Add pipeline support for nsh commandline through `pipe2()` and
`posix_spawn_file_actions_adddup2()`
1. Pack parameters of nsh_execute() as struct nsh_exec_param_s
- In
64 matches
Mail list logo
