Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2025-07-25 Thread via GitHub
yamt commented on code in PR #13173: URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230588726 ## crypto/cryptosoft.c: ## @@ -388,38 +391,41 @@ int swcr_authenc(FAR struct cryptop *crp) /* Supply MAC with AAD */ - aadlen = crda->crd_len; - /* Section 5 of R

Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2025-07-25 Thread via GitHub
ThePassionate commented on code in PR #13173: URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230445567 ## crypto/cryptosoft.c: ## @@ -388,38 +391,41 @@ int swcr_authenc(FAR struct cryptop *crp) /* Supply MAC with AAD */ - aadlen = crda->crd_len; - /* Secti

Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2025-07-25 Thread via GitHub
ThePassionate commented on code in PR #13173: URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230397782 ## crypto/cryptosoft.c: ## @@ -388,38 +391,41 @@ int swcr_authenc(FAR struct cryptop *crp) /* Supply MAC with AAD */ - aadlen = crda->crd_len; - /* Secti

Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2025-07-24 Thread via GitHub
yamt commented on code in PR #13173: URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230259211 ## include/crypto/cryptodev.h: ## @@ -215,6 +220,7 @@ struct cryptop caddr_t crp_mac; caddr_t crp_dst; caddr_t crp_iv; + caddr_t crp_aad; Review Comment: who

Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2024-08-27 Thread via GitHub
pkarashchenko merged PR #13173: URL: https://github.com/apache/nuttx/pull/13173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2024-08-25 Thread via GitHub
ThePassionate opened a new pull request, #13173: URL: https://github.com/apache/nuttx/pull/13173 ## Summary 1. add a new hash algorithm crc32 2. add a new cmac algorithm with aes ## Impact N/A ## Testing ci -- This is an automated message from the Apache Git Service.