[GitHub] [incubator-nuttx] anchao opened a new pull request #5696: arch/sim: add all symbols support

anchao opened a new pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696 ## Summary arch/sim: add all symbols support symtab/allsyms: output the symbol size if parameter is valid libs/vsprintf: fix the type issue ## Impact N/A ## Test

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821732739 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct IRA

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821741221 ## File path: include/nuttx/usb/usb.h ## @@ -336,7 +336,7 @@ struct usb_strdesc_s { uint8_t len; /* Descriptor length */

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5694: risc-v/mpfs: usb: fix an unused variable warning

xiaoxiang781216 merged pull request #5694: URL: https://github.com/apache/incubator-nuttx/pull/5694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

pkarashchenko commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821751061 ## File path: libs/libc/machine/risc-v/common/arch_setjmp.S ## @@ -18,38 +18,64 @@ # #

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1053: apps: update licenses to Apache

pkarashchenko merged pull request #1053: URL: https://github.com/apache/incubator-nuttx-apps/pull/1053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5696: arch/sim: add all symbols support

pkarashchenko commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821754389 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol =

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821782677 ## File path: fs/fat/Kconfig ## @@ -43,7 +43,7 @@ config FAT_LFN config FAT_MAXFNAME int "FAT maximum file name size" dep

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821787441 ## File path: fs/fat/Kconfig ## @@ -43,7 +43,7 @@ config FAT_LFN config FAT_MAXFNAME int "FAT maximum file name size" depen

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821787441 ## File path: fs/fat/Kconfig ## @@ -43,7 +43,7 @@ config FAT_LFN config FAT_MAXFNAME int "FAT maximum file name size" depen

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821788783 ## File path: drivers/wireless/gs2200m.c ## @@ -1639,7 +1639,7 @@ static enum pkt_type_e gs2200m_set_opmode(FAR struct gs2200m_dev_s *dev,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821790956 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821794585 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821795989 ## File path: fs/fat/Kconfig ## @@ -43,7 +43,7 @@ config FAT_LFN config FAT_MAXFNAME int "FAT maximum file name size" dep

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821796302 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct IRA

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821797016 ## File path: drivers/wireless/gs2200m.c ## @@ -1639,7 +1639,7 @@ static enum pkt_type_e gs2200m_set_opmode(FAR struct gs2200m_dev_s *dev

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

pkarashchenko commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821799054 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,24 @@ * Included Files *

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

pkarashchenko commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821751061 ## File path: libs/libc/machine/risc-v/common/arch_setjmp.S ## @@ -18,38 +18,64 @@ # #

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

pkarashchenko commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821806350 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,24 @@ * Included Files *

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821807641 ## File path: drivers/wireless/gs2200m.c ## @@ -1639,7 +1639,7 @@ static enum pkt_type_e gs2200m_set_opmode(FAR struct gs2200m_dev_s *dev,

[GitHub] [incubator-nuttx] davids5 commented on pull request #5523: dp83848c ethernet phy interrupt support

davids5 commented on pull request #5523: URL: https://github.com/apache/incubator-nuttx/pull/5523#issuecomment-1061932863 @lipan118 - Thank you - While looking at only the diff, I missed the #if. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821828213 ## File path: include/nuttx/usb/usb.h ## @@ -336,7 +336,7 @@ struct usb_strdesc_s { uint8_t len; /* Descriptor length */

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821831910 ## File path: drivers/wireless/gs2200m.c ## @@ -1639,7 +1639,7 @@ static enum pkt_type_e gs2200m_set_opmode(FAR struct gs2200m_dev_s *dev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821836753 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1061959283 This patch found a dozen of bugs before passing CI finally, so I think it's very useful. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821850712 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct IRA

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821851475 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct IRA

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5476: boards: Remove -fno-builtin

xiaoxiang781216 commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821855283 ## File path: arch/arm/src/c5471/c5471_irq.c ## @@ -59,7 +59,7 @@ volatile uint32_t *g_current_regs[1]; * because we know that correct I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

xiaoxiang781216 commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821858328 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,24 @@ * Included Files ***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

xiaoxiang781216 commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r821858328 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,24 @@ * Included Files ***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r821869783 ## File path: drivers/input/ajoystick.c ## @@ -380,14 +344,12 @@ static int ajoy_open(FAR struct file *filep) ajoy_enable(priv); +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r821870255 ## File path: drivers/input/ajoystick.c ## @@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char *buffer, /

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r821871849 ## File path: drivers/input/ajoystick.c ## @@ -467,22 +398,20 @@ static int ajoy_close(FAR struct file *filep) priv->au_open = opri

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821874741 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol = symtab

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821875340 ## File path: libs/libc/stdio/lib_libvsprintf.c ## @@ -488,6 +488,61 @@ static int vsprintf_internal(FAR struct lib_outstream_s *stream,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5696: arch/sim: add all symbols support

xiaoxiang781216 commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821743925 ## File path: libs/libc/sched/sched_dumpstack.c ## @@ -84,6 +88,25 @@ void sched_dumpstack(pid_t tid) } } #else + +

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5696: arch/sim: add all symbols support

pkarashchenko commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821903990 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol =

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5696: arch/sim: add all symbols support

pkarashchenko commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821904377 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol =

[GitHub] [incubator-nuttx] eenurkka commented on a change in pull request #5688: MPFS USB driver

eenurkka commented on a change in pull request #5688: URL: https://github.com/apache/incubator-nuttx/pull/5688#discussion_r821908498 ## File path: arch/risc-v/src/mpfs/mpfs_usb.c ## @@ -0,0 +1,3770 @@ +/***

[GitHub] [incubator-nuttx] eenurkka commented on a change in pull request #5688: MPFS USB driver

eenurkka commented on a change in pull request #5688: URL: https://github.com/apache/incubator-nuttx/pull/5688#discussion_r821915622 ## File path: arch/risc-v/src/mpfs/mpfs_usb.c ## @@ -0,0 +1,3770 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5688: MPFS USB driver

pkarashchenko commented on a change in pull request #5688: URL: https://github.com/apache/incubator-nuttx/pull/5688#discussion_r821921252 ## File path: arch/risc-v/src/mpfs/mpfs_usb.c ## @@ -0,0 +1,3770 @@ +/**

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r821964966 ## File path: arch/xtensa/src/esp32s3/esp32s3_psram.h ## @@ -0,0 +1,111 @@ +/***

[GitHub] [incubator-nuttx] acassis merged pull request #5690: libc/gettext: Support the plural format

acassis merged pull request #5690: URL: https://github.com/apache/incubator-nuttx/pull/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822043963 ## File path: arch/xtensa/src/esp32s3/rom/esp32s3_opi_flash.h ## @@ -0,0 +1,377 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822047393 ## File path: arch/xtensa/src/esp32s3/rom/esp32s3_opi_flash.h ## @@ -0,0 +1,377 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5476: boards: Remove -fno-builtin

pkarashchenko commented on a change in pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r822050832 ## File path: drivers/usbdev/pl2303.c ## @@ -830,6 +830,7 @@ static void usbclass_freereq(FAR struct usbdev_ep_s *ep, static int usbclass

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

pkarashchenko commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r822061271 ## File path: drivers/input/button_upper.c ## @@ -887,7 +801,6 @@ int btn_register(FAR const char *devname, return OK; errout_with_pri

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5696: arch/sim: add all symbols support

pkarashchenko commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822065333 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol =

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #4908: nucleo-h743zi: add board files to support mcuboot

pkarashchenko commented on pull request #4908: URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-1062203237 @tito97sp do you have any plans when you can update this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822068214 ## File path: arch/xtensa/src/esp32s3/esp32s3_psram.c ## @@ -0,0 +1,559 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822069347 ## File path: arch/xtensa/src/esp32s3/esp32s3_psram.c ## @@ -0,0 +1,546 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822071366 ## File path: arch/xtensa/src/esp32s3/esp32s3_spiram.h ## @@ -0,0 +1,209 @@ +/**

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822074781 ## File path: arch/xtensa/src/esp32s3/esp32s3_psram.c ## @@ -0,0 +1,559 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

pkarashchenko commented on a change in pull request #5686: URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r822075319 ## File path: arch/xtensa/src/esp32s3/esp32s3_psram.c ## @@ -0,0 +1,559 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5697: boards/arm/stm32[f7|l4]: fix SPI chip select GPIO access

pkarashchenko opened a new pull request #5697: URL: https://github.com/apache/incubator-nuttx/pull/5697 ## Summary Out of bound array access happen for some of STM32 based boards during SPI chip select operation. ## Impact SMT32 based boards that use SPI. ## Testing P

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei opened a new pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698 ## Summary This MR intends to add support for the Main System Watchdog Timers 0 and 1 of **ESP32-S2**. Support for RTC Watchdog Timer is currently in place, but not yet functiona

[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request #1054: style: unify path to files in comment section

pkarashchenko opened a new pull request #1054: URL: https://github.com/apache/incubator-nuttx-apps/pull/1054 ## Summary Unify path to files in comment section ## Impact None. Refactoring only ## Testing Pass CI -- This is an automated message from the Apache Git Ser

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1054: style: unify path to files in comment section

pkarashchenko commented on a change in pull request #1054: URL: https://github.com/apache/incubator-nuttx-apps/pull/1054#discussion_r822114813 ## File path: examples/fxos8700cq_test/Kconfig ## @@ -1,25 +1,4 @@ -##

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1054: style: unify path to files in comment section

pkarashchenko commented on a change in pull request #1054: URL: https://github.com/apache/incubator-nuttx-apps/pull/1054#discussion_r822115167 ## File path: netutils/netcat/Kconfig ## @@ -1,24 +1,4 @@ -###

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5699: ESP32-S3: Enable SMP support

gustavonihei opened a new pull request #5699: URL: https://github.com/apache/incubator-nuttx/pull/5699 ## Summary This PR intends to enable SMP support for the **ESP32-S3** chip. ## Impact Extended OS support for the **ESP32-S3** chip. Should have no impact if `CONFIG_SMP` is

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

pkarashchenko commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822121474 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt.c ## @@ -22,15 +22,824 @@ * Included Files ***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5699: ESP32-S3: Enable SMP support

pkarashchenko commented on a change in pull request #5699: URL: https://github.com/apache/incubator-nuttx/pull/5699#discussion_r822126524 ## File path: arch/xtensa/src/esp32s3/chip_macros.h ## @@ -41,28 +47,48 @@ * Public Data ***

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei commented on pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#issuecomment-1062293942 @pkarashchenko I've addressed the raised issues. Please, take another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei edited a comment on pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#issuecomment-1062293942 @pkarashchenko I've addressed the raised issues. Please, could you take another look? Thanks! -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

pkarashchenko commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822140262 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,741 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

pkarashchenko commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822162875 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,741 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822163244 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,741 @@ +/

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

pkarashchenko commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822163367 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,741 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822164122 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,741 @@ +/

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

pkarashchenko commented on a change in pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#discussion_r822165533 ## File path: arch/xtensa/src/esp32s2/esp32s2_wdt_lowerhalf.c ## @@ -0,0 +1,739 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

gustavonihei commented on pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698#issuecomment-1062394562 > LGTM! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] rtucker85 opened a new pull request #5700: arch/arm/src/sam34/sam_dmac.c: Fix compilation error

rtucker85 opened a new pull request #5700: URL: https://github.com/apache/incubator-nuttx/pull/5700 ## Summary Fix missing commas in array DMA state array initialiser ## Impact SAM3/4 DMA users ## Testing Compilation on the Arduino-Due target: -> defines `ARCH_CHIP

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5697: boards/arm/stm32[f7|l4]: fix SPI chip select GPIO access

acassis commented on a change in pull request #5697: URL: https://github.com/apache/incubator-nuttx/pull/5697#discussion_r822196777 ## File path: boards/arm/stm32/nucleo-f429zi/src/stm32_spi.c ## @@ -217,35 +248,41 @@ uint8_t stm32_spi1status(FAR struct spi_dev_s *dev, uint32_

[GitHub] [incubator-nuttx] acassis commented on pull request #5700: arch/arm/src/sam34/sam_dmac.c: Fix compilation error

acassis commented on pull request #5700: URL: https://github.com/apache/incubator-nuttx/pull/5700#issuecomment-1062439811 Thank you @rtucker85 ! Nice to see a contribution from Australia! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] rtucker85 commented on pull request #5700: arch/arm/src/sam34/sam_dmac.c: Fix compilation error

rtucker85 commented on pull request #5700: URL: https://github.com/apache/incubator-nuttx/pull/5700#issuecomment-1062442473 > Thank you @rtucker85 ! Nice to see a contribution from Australia! No problems. More to come in the future :) -- This is an automated message from the Apach

[GitHub] [incubator-nuttx] acassis merged pull request #5698: ESP32-S2: Add support for Main System Watchdog Timers

acassis merged pull request #5698: URL: https://github.com/apache/incubator-nuttx/pull/5698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

no1wudi commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r822212602 ## File path: libs/libc/machine/risc-v/common/arch_setjmp.S ## @@ -18,38 +18,64 @@ # ###

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

no1wudi commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r822213121 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,24 @@ * Included Files ***

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5700: arch/arm/src/sam34/sam_dmac.c: Fix compilation error

xiaoxiang781216 merged pull request #5700: URL: https://github.com/apache/incubator-nuttx/pull/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5696: arch/sim: add all symbols support

xiaoxiang781216 commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822235067 ## File path: tools/mkallsyms.sh ## @@ -21,7 +21,7 @@ export LC_ALL=C -usage="Usage: $0 " +usage="Usage: $0 " Review comment:

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1054: style: unify path to files in comment section

xiaoxiang781216 merged pull request #1054: URL: https://github.com/apache/incubator-nuttx-apps/pull/1054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822241007 ## File path: arch/sim/src/sim/up_head.c ## @@ -52,6 +53,43 @@ char **g_argv; static char g_logbuffer[4096]; #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

xiaoxiang781216 commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r822240815 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,25 @@ * Included Files ***

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5699: ESP32-S3: Enable SMP support

xiaoxiang781216 merged pull request #5699: URL: https://github.com/apache/incubator-nuttx/pull/5699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5695: arch/risc-v: Save/Load float register in setjmp

no1wudi commented on a change in pull request #5695: URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r822242818 ## File path: arch/risc-v/include/setjmp.h ## @@ -25,13 +25,25 @@ * Included Files ***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5689: segger/sysview: add syscall support

xiaoxiang781216 commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822242616 ## File path: drivers/segger/note_sysview.c ## @@ -310,6 +366,54 @@ void sched_note_irqhandler(int irq, FAR void *handler, bool enter) }

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822244823 ## File path: tools/mkallsyms.sh ## @@ -21,7 +21,7 @@ export LC_ALL=C -usage="Usage: $0 " +usage="Usage: $0 " Review comment: done

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5645: arch/arm: optimize context switch speed

no1wudi commented on a change in pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#discussion_r822252911 ## File path: arch/arm/src/common/arm_internal.h ## @@ -306,14 +307,10 @@ void arm_boot(void); /* Context switching */ -void arm_copyfullstat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5645: arch/arm: optimize context switch speed

xiaoxiang781216 commented on a change in pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#discussion_r822255141 ## File path: arch/arm/src/common/arm_internal.h ## @@ -306,14 +307,10 @@ void arm_boot(void); /* Context switching */ -void arm_copy

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5689: segger/sysview: add syscall support

anchao commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822258602 ## File path: drivers/segger/note_sysview.c ## @@ -197,6 +214,45 @@ static bool sysview_isenabled_irq(int irq, bool enter) } #endif +/*

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5689: segger/sysview: add syscall support

anchao commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822260473 ## File path: drivers/segger/note_sysview.c ## @@ -490,4 +594,50 @@ void sched_note_filter_irq(struct note_filter_irq_s *oldf, } #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5696: arch/sim: add all symbols support

xiaoxiang781216 commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822259851 ## File path: arch/sim/src/sim/up_head.c ## @@ -52,6 +53,46 @@ char **g_argv; static char g_logbuffer[4096]; #endif +#ifdef CONFIG_ALL

[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #5701: power:govorner: add govorner to per domain.

zhuyanlinzyl opened a new pull request #5701: URL: https://github.com/apache/incubator-nuttx/pull/5701 For mult domains scene,, activity and greety can be used at same time. Let user to select domain governor. Signed-off-by: zhuyanlin ## Summary ## Impact #

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5689: segger/sysview: add syscall support

anchao commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822264837 ## File path: drivers/segger/note_sysview.c ## @@ -310,6 +366,54 @@ void sched_note_irqhandler(int irq, FAR void *handler, bool enter) } #endif

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5689: segger/sysview: add syscall support

anchao commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822268252 ## File path: drivers/segger/note_sysview.c ## @@ -155,11 +159,24 @@ static bool sysview_isenabled(void) } #endif +#ifdef CONFIG_SCHED_INST

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822271107 ## File path: arch/sim/src/sim/up_head.c ## @@ -52,6 +53,46 @@ char **g_argv; static char g_logbuffer[4096]; #endif +#ifdef CONFIG_ALLSYMS +ext

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822271426 ## File path: tools/mkallsyms.sh ## @@ -21,7 +21,7 @@ export LC_ALL=C -usage="Usage: $0 " +usage="Usage: $0 " Review comment: Done

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5696: arch/sim: add all symbols support

anchao commented on a change in pull request #5696: URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822271519 ## File path: libs/libc/symtab/symtab_allsyms.c ## @@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value, symbol = symtab

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5689: segger/sysview: add syscall support

xiaoxiang781216 commented on a change in pull request #5689: URL: https://github.com/apache/incubator-nuttx/pull/5689#discussion_r822275106 ## File path: tools/ci/testlist/sim-02.dat ## @@ -8,3 +8,7 @@ # macOS doesn't have X11 -Darwin,sim:touchscreen + +# macOS doesn't supp

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r822280662 ## File path: drivers/input/button_upper.c ## @@ -887,7 +801,6 @@ int btn_register(FAR const char *devname, return OK; errout_with_p

<    6   7   8   9   10   11   12   13   14   15   >