[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook

xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388698278 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] yamt opened a new pull request #451: nxstyle: Output line numbers when complaining on block comments length

yamt opened a new pull request #451: nxstyle: Output line numbers when complaining on block comments length URL: https://github.com/apache/incubator-nuttx/pull/451 This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595505733 There are quite a few things here. Perhaps you can "Resolve conversation" when the changes are in place. Once all of the

[GitHub] [incubator-nuttx] btashton commented on issue #261: Initial checkin nuttx github action CI workflow

btashton commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595551685 @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is

[GitHub] [incubator-nuttx] yamt opened a new pull request #445: nxstyle: Don't parse a file if its type is unknown

yamt opened a new pull request #445: nxstyle: Don't parse a file if its type is unknown URL: https://github.com/apache/incubator-nuttx/pull/445 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605242 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -8,7 +8,7 @@ #

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595508795 @patacongo Thanks— I went through the changed files view and looked to make sure I took care of everything. I resolved all the

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388598106 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ajoystick.c ## @@ -0,0 +1,452 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596066 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ostest.c ## @@ -0,0 +1,114 @@

[GitHub] [incubator-nuttx] patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666475 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666947 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597096 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -157,6 +162,7 @@ static int

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597128 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -8,7 +8,7 @@ #

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597444 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597796 ## File path: boards/arm/sama5/sama5d2-xult/src/Makefile ## @@ -1,7 +1,7 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605409 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ajoystick.c ## @@ -0,0 +1,452 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388630698 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ethernet.c ## @@ -0,0 +1,343 @@

[GitHub] [incubator-nuttx] patacongo merged pull request #445: nxstyle: Don't parse a file if its type is unknown

patacongo merged pull request #445: nxstyle: Don't parse a file if its type is unknown URL: https://github.com/apache/incubator-nuttx/pull/445 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388680693 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] yamt opened a new pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr

yamt opened a new pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr URL: https://github.com/apache/incubator-nuttx/pull/446 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595502991 @patacongo Thanks for the improvements. I think I made all the suggested fixes, will you take a look and see if there's anything

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388631703 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596923 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -117,6 +117,7 @@ static int

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597017 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -141,6 +144,7 @@ static int

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596967 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -125,6 +126,7 @@ static int

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596011 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_hsmci.c ## @@ -0,0 +1,344 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595940 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_at25.c ## @@ -0,0 +1,143 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595974 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_can.c ## @@ -0,0 +1,115 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595871 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -133,6 +135,7 @@ static int

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596015 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -141,6 +144,7 @@ static int

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596094 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -149,6 +153,7 @@ static int

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596036 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_nandflash.c ## @@ -0,0 +1,234 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595906 ## File path: boards/arm/sama5/sama5d2-xult/include/board_498mhz.h ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595144 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -80,6 +81,7 @@ #define

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596891 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -80,6 +81,7 @@ #define

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595455 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -117,6 +117,7 @@ static int

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595626 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -125,6 +126,7 @@ static int

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596219 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -157,6 +162,7 @@ static int

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606192 ## File path: boards/arm/sama5/sama5d2-xult/src/Makefile ## @@ -1,7 +1,7 @@

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606207 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388672456 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #454: nuttx/arch.h: Several nxstyle fixes

xiaoxiang781216 merged pull request #454: nuttx/arch.h: Several nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/454 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] Ouss4 merged pull request #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes

Ouss4 merged pull request #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes URL: https://github.com/apache/incubator-nuttx/pull/449 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #450: arch: xtensa: Call the waiti instruction in up_idle()

xiaoxiang781216 merged pull request #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] jerpelea merged pull request #455: libs: risc-v: Fix typo in comment

jerpelea merged pull request #455: libs: risc-v: Fix typo in comment URL: https://github.com/apache/incubator-nuttx/pull/455 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] jerpelea merged pull request #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

jerpelea merged pull request #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #447: ESP32 module support

masayuki2009 commented on issue #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#issuecomment-595694691 Hi, @yamt, Regarding relocation, could you tell us where we can find the Tensilica ISA document?

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #447: ESP32 module support

masayuki2009 commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388815201 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #447: ESP32 module support

masayuki2009 commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388814561 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #455: libs: risc-v: Fix typo in comment

masayuki2009 opened a new pull request #455: libs: risc-v: Fix typo in comment URL: https://github.com/apache/incubator-nuttx/pull/455 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] Ouss4 commented on issue #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes

Ouss4 commented on issue #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes URL: https://github.com/apache/incubator-nuttx/pull/449#issuecomment-595685620 @adamfeuer Thanks. I made a small modification in header's file names to change "./arch/" to just "arch/", this

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #447: ESP32 module support

yamt commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388828807 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #447: ESP32 module support

yamt commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388829122 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] yamt commented on issue #447: ESP32 module support

yamt commented on issue #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#issuecomment-595707449 @masayuki2009 i'm looking at

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #456: CXD56: move isx012 driver to board specific drivers

jerpelea opened a new pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456 workaround for issue 438 https://github.com/apache/incubator-nuttx/issues/438

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #447: ESP32 module support

yamt commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388825966 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #447: ESP32 module support

yamt commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388825966 ## File path: libs/libc/machine/xtensa/arch_elf.c ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] midokura-silvia commented on a change in pull request #447: ESP32 module support

midokura-silvia commented on a change in pull request #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r388845473 ## File path: include/elf.h ## @@ -71,6 +71,7 @@ #define EM_CRIS76 /* Axis Communications 32-bit

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #447: ESP32 module support

masayuki2009 commented on issue #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#issuecomment-595711399 @yamt Thanks for the information. This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] patacongo opened a new issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.

patacongo opened a new issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442 Because of modularity concerns, this logic must be removed from tools/Makefile.unix: 483 ifeq

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388394750 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)

[GitHub] [incubator-nuttx] patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.

patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595310567 I wonder if we don't need to hook in Makefile.unix/win to run: $(TOPDIR)/tools/arch/Makefile

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388396712 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388398371 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)

[GitHub] [incubator-nuttx] anpaza opened a new pull request #459: stm32h7: support SDRAM via FMC peripherial

anpaza opened a new pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459 Fixed everything said in my previous merge attempt. nxstyle passes on new code. Only FMC-related changes.

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388980135 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] anpaza opened a new pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.

anpaza opened a new pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460 Added a DEBUGASSERT and a runtime check so that mm_region will not overwrite critical heap data if user incorrectly defines MM_REGIONS.

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.

patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460#discussion_r388982165 ## File path: mm/mm_heap/mm_initialize.c ## @@ -75,6 +75,13 @@ void mm_addregion(FAR

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.

patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460#discussion_r388982165 ## File path: mm/mm_heap/mm_initialize.c ## @@ -75,6 +75,13 @@ void mm_addregion(FAR

[GitHub] [incubator-nuttx] patacongo merged pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.

patacongo merged pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial

patacongo commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388991575 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a)

[GitHub] [incubator-nuttx] anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial

anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388998837 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a)

[GitHub] [incubator-nuttx] anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial

anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595844421 They are used in stm32_fmc.c (modreg32). I think it is easier to read this: modreg32 (BOARD_FMC_CLK,

[GitHub] [incubator-nuttx] anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial

anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388998837 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a)

[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial

patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846998 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom collapses large

[GitHub] [incubator-nuttx] patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial

patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846947 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom

[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial

patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846947 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom collapses large

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers

patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r388896250 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@

[GitHub] [incubator-nuttx] patacongo commented on issue #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…

patacongo commented on issue #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid… URL: https://github.com/apache/incubator-nuttx/pull/453#issuecomment-595766041 Both false negatives and false positives must be avoided. When I change nxstyle, I verify by:

[GitHub] [incubator-nuttx] patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files

patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595779404 NOTE: Please review, verify, and merge if possible. I am not really set up to do verifcation on Spresense at

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388919568 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers

patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r388896250 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers

patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r388895574 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@

[GitHub] [incubator-nuttx] patacongo merged pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…

patacongo merged pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid… URL: https://github.com/apache/incubator-nuttx/pull/453 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] patacongo merged pull request #451: nxstyle: Output line numbers when complaining on block comments length

patacongo merged pull request #451: nxstyle: Output line numbers when complaining on block comments length URL: https://github.com/apache/incubator-nuttx/pull/451 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #457: Build System: Resolve CPU-specific logic in common build files

patacongo edited a comment on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595779404 NOTE: Please review, verify, and merge if possible. I am not really set up to do verifcation on

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers

patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r388895574 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@

[GitHub] [incubator-nuttx] patacongo opened a new pull request #457: Build System: Resolve CPU-specific logic in common build files

patacongo opened a new pull request #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457 * tools/Config.mk - Add empty definition POSTBUILD * tools/Makefile.unix/win - Replace CXD56xx specific logic with $(call

[GitHub] [incubator-nuttx] patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.

patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595780658 PR #457 provide a resolution for this issue. Pleave review and, hopefully, merge.

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files

davids5 commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#discussion_r388925198 ## File path: boards/arm/cxd56xx/spresense/scripts/Make.defs ## @@ -35,6 +35,7

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial

patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388939275 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -39,40 +39,387 @@ #include +#if

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial

patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388940282 ## File path: mm/mm_heap/mm_initialize.c ## @@ -75,6 +75,13 @@ void mm_addregion(FAR struct

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial

patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388939870 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -39,40 +39,387 @@ #include +#if

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial

patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388939275 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -39,40 +39,387 @@ #include +#if

[GitHub] [incubator-nuttx] davids5 commented on issue #458: stm32h7: support SDRAM via FMC peripherial

davids5 commented on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595797194 @anpaza - Thank you. These all have great merit. But the coupling is problematic. In looking at this it should be 3 PRs for the 3

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial

patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595800665 @davids5 This change MUST BE DECLINED. It makes extensive modification to mm/mm_initialize.c tools/Makefile.unix,

[GitHub] [incubator-nuttx] patacongo merged pull request #456: CXD56: move isx012 driver to board specific drivers

patacongo merged pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388970119 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] jerpelea commented on issue #457: Build System: Resolve CPU-specific logic in common build files

jerpelea commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595785563 after typo fix +1 This is an automated message

<    1   2   3   4   5   6   7   8   9   10   >