[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5312: Support inbuilt transform functions

codecov-io edited a comment on pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312#issuecomment-620391827 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5312?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on pull request #5312: Support inbuilt transform functions

codecov-io commented on pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312#issuecomment-620391827 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5312?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on issue #5313: Add date time transform functions

npawar commented on issue #5313: URL: https://github.com/apache/incubator-pinot/issues/5313#issuecomment-620387489 @reallocf does this look like something you can help out with? This is an automated message from the Apache

[GitHub] [incubator-pinot] npawar commented on pull request #5312: Support inbuilt transform functions

npawar commented on pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312#issuecomment-620387162 @yupeng9 FYI, you can use this to add functions related to geo spatial for https://github.com/apache/incubator-pinot/issues/5280

[GitHub] [incubator-pinot] npawar commented on issue #5313: Add date time transform functions

npawar commented on issue #5313: URL: https://github.com/apache/incubator-pinot/issues/5313#issuecomment-620386700 One thing to keep in mind when designing: In the case of Simple Date Format, we don't want to create an instance of SDF formatter for every row.

[GitHub] [incubator-pinot] npawar commented on issue #5313: Add date time transform functions

npawar commented on issue #5313: URL: https://github.com/apache/incubator-pinot/issues/5313#issuecomment-620385642 https://github.com/apache/incubator-pinot/issues/2756 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] npawar commented on pull request #5312: Support inbuilt transform functions

npawar commented on pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312#issuecomment-620385604 https://github.com/apache/incubator-pinot/issues/2756 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] npawar opened a new issue #5313: Add date time transform functions

npawar opened a new issue #5313: URL: https://github.com/apache/incubator-pinot/issues/5313 This is a followup to: https://github.com/apache/incubator-pinot/pull/5312 We need to exhaustively add a lot of time transformation functions. This is part of the broader task:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5312: Support inbuilt transform functions

kishoreg commented on a change in pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312#discussion_r416280788 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/function/DateTimeFunctions.java ## @@ -0,0 +1,37 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] npawar opened a new pull request #5312: Support inbuilt transform functions

npawar opened a new pull request #5312: URL: https://github.com/apache/incubator-pinot/pull/5312 Wiring the FunctionExpressionEvaluator with the ExpressionEvaluatorFactory to be able to execute inbuilt transform functions. Added 2 simple time transformation examples. Immediate

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

Jackie-Jiang commented on a change in pull request #5309: URL: https://github.com/apache/incubator-pinot/pull/5309#discussion_r416225407 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/MultiplePinotSegmentRecordReader.java ## @@ -64,7 +63,7 @@ public

[incubator-pinot] branch master updated: Prune stop words for text index (#5297)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new cb62dfc Prune stop words for text

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

snleee commented on a change in pull request #5309: URL: https://github.com/apache/incubator-pinot/pull/5309#discussion_r416215226 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/MultiplePinotSegmentRecordReader.java ## @@ -64,7 +63,7 @@ public

[incubator-pinot] branch master updated: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core (#5310)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b9e8d96 Move ExpressionEvaluators

[GitHub] [incubator-pinot] npawar commented on pull request #5310: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core

npawar commented on pull request #5310: URL: https://github.com/apache/incubator-pinot/pull/5310#issuecomment-620284903 > LGTM. This one has conflict with #5309. Let's figure out which one to merge first As discussed offline, I'll merge this first. Thanks!

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

npawar commented on a change in pull request #5309: URL: https://github.com/apache/incubator-pinot/pull/5309#discussion_r416208000 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-base/src/main/java/org/apache/pinot/plugin/stream/kafka/KafkaJSONMessageDecoder.java

[GitHub] [incubator-pinot] codecov-io commented on pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

codecov-io commented on pull request #5309: URL: https://github.com/apache/incubator-pinot/pull/5309#issuecomment-620275758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5297: Prune stop words for text index

kishoreg commented on a change in pull request #5297: URL: https://github.com/apache/incubator-pinot/pull/5297#discussion_r416191401 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/text/LuceneTextIndexCreator.java ## @@ -50,6 +58,15 @@

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5311: Move UpsertConfig under package org.apache.pinot.spi.config.table

Jackie-Jiang opened a new pull request #5311: URL: https://github.com/apache/incubator-pinot/pull/5311 Also moved some test classes to the correct package This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] npawar opened a new pull request #5310: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core

npawar opened a new pull request #5310: URL: https://github.com/apache/incubator-pinot/pull/5310 Moving the ExpressionEvaluators to pinot-core, so that it can be alongside the FunctionExpressionEvaluators related code. Also moved SchemaFieldExtractorUtils to pinot-core, and renamed it

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

Jackie-Jiang opened a new pull request #5309: URL: https://github.com/apache/incubator-pinot/pull/5309 RecordReader and StreamMessageDecoder is the entry point for batch and streaming data ingestion. They are expected to be implemented and plugged to provide customized format support.

[incubator-pinot] branch te_elr_migration updated (aefc44a -> 06aba31)

This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch te_elr_migration in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from aefc44a minor fix (#5300) add 06aba31 deploy parent pom (#5308) No new revisions were

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5308: [TE] fix by deploying parent pom

vincentchenjl opened a new pull request #5308: URL: https://github.com/apache/incubator-pinot/pull/5308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] s-pace commented on pull request #5302: feat(website): add DocSearch as recommended by docusaurus

s-pace commented on pull request #5302: URL: https://github.com/apache/incubator-pinot/pull/5302#issuecomment-620169832 Feel free to apply if you want to get access to the searches with no result https://docsearch.algolia.com/apply/

[GitHub] [incubator-pinot] s-pace commented on pull request #5302: feat(website): add DocSearch as recommended by docusaurus

s-pace commented on pull request #5302: URL: https://github.com/apache/incubator-pinot/pull/5302#issuecomment-620169430 You do not need the appID since we are handling the crawl for you :) This is an automated message from

[incubator-pinot] branch master updated: Pull the source fields Set out of the RecordReader/Decoder (#5303)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new bfddb7a Pull the source fields Set

[incubator-pinot] branch master updated: Fixing missing error message from pinot-admin command (#5305)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3d9d206 Fixing missing error message

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416026238 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/SchemaFieldExtractorUtils.java ## @@ -19,17 +19,15 @@ package

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416025871 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java ## @@ -167,8 +168,10 @@

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416025146 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java ## @@ -33,14 +34,17 @@ @InterfaceStability.Stable

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416022829 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConsumerFactory.java ## @@ -52,7 +53,7 @@ void init(StreamConfig

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5305: Fixing missing error message from pinot-admin command

fx19880617 commented on a change in pull request #5305: URL: https://github.com/apache/incubator-pinot/pull/5305#discussion_r416019435 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -123,7 +123,7 @@

[incubator-pinot] branch fixing_pinot_admin_add_table_exist_issue updated (9064d43 -> f2c9cd8)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_pinot_admin_add_table_exist_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9064d43 Update AddTableCommand.java add f2c9cd8 Update

[incubator-pinot] branch fixing_pinot_admin_add_table_exist_issue updated (1b834ea -> 9064d43)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_pinot_admin_add_table_exist_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1b834ea Update PinotTableRestletResource.java add 9064d43 Update

[incubator-pinot] branch fixing_pinot_admin_add_table_exist_issue updated (2005fca -> 1b834ea)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_pinot_admin_add_table_exist_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2005fca Fixing the missed error message from Pinot Server when using

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5305: Fixing missing error message from pinot-admin command

fx19880617 commented on a change in pull request #5305: URL: https://github.com/apache/incubator-pinot/pull/5305#discussion_r416015211 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -123,7 +123,7 @@

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416004575 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java ## @@ -33,14 +34,17 @@ @InterfaceStability.Stable

[GitHub] [incubator-pinot] npawar commented on pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

npawar commented on pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#issuecomment-620120432 > Keep the old interface and have a default impl to call the old interface without null? While this would be great for not breaking backward compatibility, I

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5305: Fixing missing error message from pinot-admin command

jackjlli commented on a change in pull request #5305: URL: https://github.com/apache/incubator-pinot/pull/5305#discussion_r415994726 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -123,7 +123,7 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5303: Pull the source fields Set out of the RecordReader/Decoder

mcvsubbu commented on a change in pull request #5303: URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r415986564 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDecoderProvider.java ## @@ -35,13 +36,13 @@ * @param schema *

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5293: Adding support for Protobuf input format

KKcorps commented on a change in pull request #5293: URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r415936910 ## File path: pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReader.java