haibow commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422594460
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -0,0 +1,13 @@
+## Upgrade Notes
+Does this PR prevent a zero down-time upgrade? (Assume upgrad
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 9246d7e Update package.json to resolve sharp version to fix the local
build issue. (#5215)
add 44b0a
codecov-io commented on pull request #5357:
URL: https://github.com/apache/incubator-pinot/pull/5357#issuecomment-626278291
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5357?src=pr&el=h1)
Report
> Merging
[#5357](https://codecov.io/gh/apache/incubator-pinot/pull/5357?s
jackjlli opened a new pull request #5357:
URL: https://github.com/apache/incubator-pinot/pull/5357
We encounter the following exception when running any command for
`PerfBenchmarkRunner`:
```
Exception in thread "main" java.lang.NoSuchMethodError:
org.glassfish.grizzly.http.server.Se
mcvsubbu commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422568460
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -0,0 +1,13 @@
+## Upgrade Notes
+Does this PR prevent a zero down-time upgrade? (Assume upgr
mcvsubbu commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422568206
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -0,0 +1,13 @@
+## Upgrade Notes
Review comment:
I had the before, but the problem is
reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422564834
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/function/DateTimeFunctionEvaluatorTest.java
##
@@ -52,12 +54,14 @@ public void
siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422563677
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##
@@ -0,0 +1,471 @@
+/**
+
siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422563310
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##
@@ -0,0 +1,471 @@
+/**
+
siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422562613
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##
@@ -0,0 +1,471 @@
+/**
+
siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422562477
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##
@@ -0,0 +1,471 @@
+/**
+
siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422561957
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##
@@ -0,0 +1,471 @@
+/**
+
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from af5a901 Optimize RealtimeDictionaryBasedRangePredicateEvaluator by
not scanning the dictionary when cardi
reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422550932
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/function/DefaultFunctionEvaluator.java
##
@@ -50,11 +50,16 @@
public Defa
reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422551022
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/function/DateTimeFunctions.java
##
@@ -40,4 +47,14 @@ static Long toEpochHours
reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422550841
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/function/DateTimeFunctions.java
##
@@ -27,6 +32,8 @@
*/
public class DateTi
kishoreg commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422304502
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -0,0 +1,13 @@
+## Upgrade Notes
+Does this PR prevent a zero down-time upgrade? (Assume upgr
reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422548708
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/function/DefaultFunctionEvaluatorTest.java
##
@@ -54,49 +54,73 @@ public void
kishoreg commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r422547267
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java
##
@@ -27,6 +27,7 @@
public class IndexingConfig
kishoreg commented on pull request #5307:
URL: https://github.com/apache/incubator-pinot/pull/5307#issuecomment-626232744
@xxsacxx lets resolve conflicts?
This is an automated message from the Apache Git Service.
To respond t
damianoporta opened a new issue #5356:
URL: https://github.com/apache/incubator-pinot/issues/5356
Hello, in different aggregators like the following:
-
https://github.com/apache/incubator-pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AvgAggre
KKcorps commented on a change in pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r422464033
##
File path:
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReaderConfig.java
KKcorps commented on pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#issuecomment-626121988
@kishoreg Yes, it is complete from my end
This is an automated message from the Apache Git Service.
To r
23 matches
Mail list logo
