abhioncbr commented on code in PR #13165:
URL: https://github.com/apache/pinot/pull/13165#discussion_r1605659733
##
helm/pinot/values.yaml:
##
@@ -92,6 +96,21 @@ controller:
endpoint: "/health"
livenessEnabled: false
readinessEnabled: false
+startupEnabled: fa
abhioncbr commented on code in PR #13165:
URL: https://github.com/apache/pinot/pull/13165#discussion_r1605659018
##
helm/pinot/templates/minion-stateless/deployment.yaml:
##
@@ -79,20 +79,37 @@ spec:
{{- end }}
{{- if .Values.minionStateless.probes.livenessEnabled }}
xiangfu0 commented on code in PR #13165:
URL: https://github.com/apache/pinot/pull/13165#discussion_r1605657981
##
helm/pinot/templates/minion-stateless/deployment.yaml:
##
@@ -79,20 +79,37 @@ spec:
{{- end }}
{{- if .Values.minionStateless.probes.livenessEnabled }}
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d4aa66cfc0 Introduce retries while creating stre
xiangfu0 merged PR #13036:
URL: https://github.com/apache/pinot/pull/13036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
codecov-commenter commented on PR #13177:
URL: https://github.com/apache/pinot/pull/13177#issuecomment-2118482537
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13177?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from b5c00da235 Add ability for minion nodes to download segments from
servers during task execution (#12960)
add b8
chenboat merged PR #13005:
URL: https://github.com/apache/pinot/pull/13005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
ankitsultana commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605604062
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java:
##
@@ -101,4 +109,33 @@ pr
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ceb9c1acf1 Made the error message around dimension table size clearer
(#13163)
add b5c00da235 Add ability f
ankitsultana closed issue #12458: Allow peerDownload config for minion-tasks
URL: https://github.com/apache/pinot/issues/12458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
ankitsultana merged PR #12960:
URL: https://github.com/apache/pinot/pull/12960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
soumitra-st opened a new pull request, #13177:
URL: https://github.com/apache/pinot/pull/13177
Added transport filter to keep track of number of gRPC connections, and
added metrics to keep track of total execution times of successful and failed
queries.
`dependencies`
--
T
piby180 commented on PR #13165:
URL: https://github.com/apache/pinot/pull/13165#issuecomment-2118415852
@abhioncbr That's all I need. Thanks. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abhioncbr commented on code in PR #12440:
URL: https://github.com/apache/pinot/pull/12440#discussion_r1605567663
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/SegmentMetadataPropertyReader.java:
##
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
abhioncbr commented on code in PR #12440:
URL: https://github.com/apache/pinot/pull/12440#discussion_r1605567663
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/SegmentMetadataPropertyReader.java:
##
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605566937
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java:
##
@@ -101,4 +106,29 @
ankitsultana commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605564836
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java:
##
@@ -101,4 +106,29 @@ pr
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605562938
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java:
##
@@ -101,4 +106,29 @
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605561893
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtilsTest.java:
##
@@ -0,0 +1,108 @
ankitsultana commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605559297
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtilsTest.java:
##
@@ -0,0 +1,108 @@
+/
abhioncbr commented on PR #13165:
URL: https://github.com/apache/pinot/pull/13165#issuecomment-2118390995
> @abhioncbr Thanks for taking time to work on this PR @xiangfu0 thanks for
the review.
>
> However, the changes are still not enough for us. For us, the server pods
takes longer
codecov-commenter commented on PR #13176:
URL: https://github.com/apache/pinot/pull/13176#issuecomment-2118383001
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13176?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605543125
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateT
jadami10 commented on code in PR #11907:
URL: https://github.com/apache/pinot/pull/11907#discussion_r1605541235
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java:
##
@@ -103,6 +103,7 @@ public GenericRow transfor
xiangfu0 opened a new pull request, #13176:
URL: https://github.com/apache/pinot/pull/13176
Support `funnelMaxStep` function to calculate max funnel steps for a giving
sliding window.
The syntax is:
```
FunnelMaxStep(timestampExpression, windowSize, ARRAY[stepExpression, ..])
``
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605499112
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateT
ankitsultana commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605441845
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateTasks
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605423772
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateT
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605423772
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateT
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1605420533
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
codecov-commenter commented on PR #13175:
URL: https://github.com/apache/pinot/pull/13175#issuecomment-2118187753
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13175?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
klsince commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1605390671
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
@Non
aditya0811 opened a new pull request, #13175:
URL: https://github.com/apache/pinot/pull/13175
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
ankitsultana commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1605379781
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##
@@ -131,4 +140,44 @@ public void generateTasks
jadami10 commented on PR #11673:
URL: https://github.com/apache/pinot/pull/11673#issuecomment-2118004652
@gortiz , just double checking. `This PR changes json_extract in order to
return the Java value null when the input is the Java value null.` is type and
it's only `json_format` that's ch
tibrewalpratik17 commented on PR #12960:
URL: https://github.com/apache/pinot/pull/12960#issuecomment-2117954256
Thanks @ankitsultana for the review! Addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
codecov-commenter commented on PR #13174:
URL: https://github.com/apache/pinot/pull/13174#issuecomment-2117867021
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13174?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ceb9c1acf1 Made the error message around dim
KKcorps merged PR #13163:
URL: https://github.com/apache/pinot/pull/13163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605149248
##
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json:
##
@@ -259,5 +259,49 @@
"expectedException": ".*No match found for function signa
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605147361
##
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json:
##
@@ -259,5 +259,49 @@
"expectedException": ".*No match found for function signa
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605142049
##
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json:
##
@@ -259,5 +259,49 @@
"expectedException": ".*No match found for function signa
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605142049
##
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json:
##
@@ -259,5 +259,49 @@
"expectedException": ".*No match found for function signa
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605141246
##
pinot-query-planner/src/test/resources/log4j2.xml:
##
@@ -0,0 +1,45 @@
+
+
+
+
+
+%d{/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t]
%m%n
+
+
+
+
+
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605139346
##
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##
@@ -81,6 +83,7 @@
* It provide the higher level entry interface to convert a SQL
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605139017
##
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##
@@ -81,6 +83,7 @@
* It provide the higher level entry interface to convert a SQL
gortiz commented on code in PR #13174:
URL: https://github.com/apache/pinot/pull/13174#discussion_r1605137104
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotFilterExpandSearchRule.java:
##
@@ -28,6 +28,18 @@
import org.apache.calcite.tools.RelBuild
gortiz opened a new pull request, #13174:
URL: https://github.com/apache/pinot/pull/13174
Queries like:
```sql
WITH CTE_B AS (
SELECT 1 AS __ts FROM a GROUP BY __ts
)
SELECT 1
FROM CTE_B
WHERE __ts >= 1 AND __ts < 2
```
Fail when they are executed. The reas
piby180 commented on PR #13165:
URL: https://github.com/apache/pinot/pull/13165#issuecomment-2117494643
@abhioncbr Thanks for taking time to work on this PR
@xiangfu0 thanks for the review.
However, the changes are still not enough for us. For us, the server pods
takes longer tim
tibrewalpratik17 commented on code in PR #12960:
URL: https://github.com/apache/pinot/pull/12960#discussion_r1604868126
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##
@@ -89,6 +89,8 @@ public class PinotTaskManager exten
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.53
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 14529065f1 Bump aws.sdk.version from 2.25.44 to 2.25.53
The revisions that were
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.54
in repository https://gitbox.apache.org/repos/asf/pinot.git
at b4c17ddfd4 Bump aws.sdk.version from 2.25.44 to 2.25.54
No new revisions were ad
dependabot[bot] closed pull request #13167: Bump aws.sdk.version from 2.25.44
to 2.25.53
URL: https://github.com/apache/pinot/pull/13167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #13167:
URL: https://github.com/apache/pinot/pull/13167#issuecomment-2117397011
Superseded by #13173.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #13173:
URL: https://github.com/apache/pinot/pull/13173
Bumps `aws.sdk.version` from 2.25.44 to 2.25.54.
Updates `software.amazon.awssdk:bom` from 2.25.44 to 2.25.54
Updates `software.amazon.awssdk:apache-client` from 2.25.44 to 2.25.54
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.azure-azure-storage-file-datalake-12.19.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 828d577b84 Bump com.azure:azure-storage-file-datalake from
dependabot[bot] opened a new pull request, #13172:
URL: https://github.com/apache/pinot/pull/13172
Bumps
[com.azure:azure-storage-file-datalake](https://github.com/Azure/azure-sdk-for-java)
from 12.18.4 to 12.19.0.
Release notes
Sourced from https://github.com/Azure/azure-sdk-for-
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1604457365
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1604457365
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1604457365
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1604457365
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentPartitionMetadata.java:
##
@@ -48,6 +53,21 @@ public SegmentPartitionMetadata(
62 matches
Mail list logo
