[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887253393 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -349,7 +354,7 @@ public void testPo

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887251035 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/Constants.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (AS

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887162173 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PartitionSelector.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to the A

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887197719 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java: ## @@ -120,6 +120,6 @@ public static InstanceAssignmentConfig

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887197719 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java: ## @@ -120,6 +120,6 @@ public static InstanceAssignmentConfig

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887172863 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/InstanceAssignmentConfig.java: ## @@ -28,29 +28,37 @@ public class InstanceAssignmentCon

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887171360 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/InstanceAssignmentConfig.java: ## @@ -28,29 +28,37 @@ public class InstanceAssignmentCon

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887163556 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PartitionSelector.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to the A

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r887162173 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PartitionSelector.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to the A

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

siddharthteotia commented on code in PR #8434: URL: https://github.com/apache/pinot/pull/8434#discussion_r881080878 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PartitionSelectorFactory.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed t