[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018627552 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledSingleValueQueriesTest.java: ## @@ -700,6 +711,142 @@ public void testSelectQueries() { }

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018627432 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java: ## @@ -512,7 +512,7 @@ public void setOnHeapDictionaryC

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018627320 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +187,48 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018627157 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -1903,19 +1908,76 @@ public void testForwar

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018627043 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018626960 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018605458 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** Review Comment: As discussed

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018586814 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +187,48 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018555380 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018550943 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -112,20 +122,50 @@ public void updateIndices(Seg

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018550060 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018015250 ## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ## @@ -0,0 +1,525 @@ +/** Review Comment: Yes, there a

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015953213 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -62,34 +62,42 @@ import static org.apache.pino

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015953032 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +190,45 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015952770 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -477,7 +669,13 @@ public void testRewriteRaw

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015939773 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +190,45 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015906038 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +190,45 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015906038 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -147,11 +190,45 @@ Map computeOperation(Segment

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015902321 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -62,34 +62,42 @@ import static org.apache.pino

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015901074 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -103,20 +104,27 @@ public void process()

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015894806 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -120,12 +128,47 @@ public void updateIndices(Seg

[GitHub] [pinot] somandal commented on a diff in pull request #9740: Add support to disable the forward index for existing columns

somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015887403 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -120,12 +128,47 @@ public void updateIndices(Seg