jadami10 commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1578669371
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##
@@ -64,24 +62,34 @@ default long getFirstStreamRecordIngestionTimeMs() {
}
/**
-
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1578650162
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##
@@ -64,24 +62,34 @@ default long getFirstStreamRecordIngestionTimeMs() {
}
/**
jadami10 commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1573344924
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##
@@ -64,24 +62,34 @@ default long getFirstStreamRecordIngestionTimeMs() {
}
/**
-
satishd commented on PR #12697:
URL: https://github.com/apache/pinot/pull/12697#issuecomment-2063564411
Thanks @Jackie-Jiang for cleaning up and fixing these interfaces. It helps
address issues like #https://github.com/apache/pinot/pull/12602
--
This is an automated message from the
Jackie-Jiang merged PR #12697:
URL: https://github.com/apache/pinot/pull/12697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1552474204
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,114 +53,66 @@
*/
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1552473668
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,114 +53,66 @@
*/
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1552472334
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java:
##
@@ -45,21 +45,21 @@
swaminathanmanish commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1552408238
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java:
##
@@ -45,21
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1550689745
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -591,67 +600,52 @@ private boolean
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1550684755
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaMessageBatch.java:
##
@@ -71,52 +61,22 @@ public
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1550681223
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConsumer.java:
##
@@ -47,53 +50,60
swaminathanmanish commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1550612147
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConsumer.java:
##
@@ -47,53
Jackie-Jiang commented on PR #12697:
URL: https://github.com/apache/pinot/pull/12697#issuecomment-2033090446
I've reverted the change of removing separate executor for Kinesis and
Pulsar to make this PR only focus on the interface change
--
This is an automated message from the Apache
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1538617780
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,220 +46,112 @@
*/
Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1538616409
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,220 +46,112 @@
*/
KKcorps commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1538609651
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,220 +46,112 @@
*/
public
KKcorps commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1538609473
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -52,220 +46,112 @@
*/
public
codecov-commenter commented on PR #12697:
URL: https://github.com/apache/pinot/pull/12697#issuecomment-2014711364
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12697?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
Jackie-Jiang opened a new pull request, #12697:
URL: https://github.com/apache/pinot/pull/12697
Deprecate:
- `PartitionLevelConsumer`: Use `PartitionGroupConsumer` instead
- In `MessageBatch`:
- `getMessageAtIndex()`: Use `getStreamMessage()` instead
-
20 matches
Mail list logo
