gortiz closed pull request #12808: Improves in unsafe memory
URL: https://github.com/apache/pinot/pull/12808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Jackie-Jiang commented on code in PR #12808:
URL: https://github.com/apache/pinot/pull/12808#discussion_r1559871148
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/DirectMemory.java:
##
@@ -56,8 +56,12 @@ public void flush() {
@Override
gortiz commented on PR #12808:
URL: https://github.com/apache/pinot/pull/12808#issuecomment-2046628265
> I feel we can remove the method level `synchronize` and declare the field
as `volatile` ?
I think that would be safe as well, although the reasoning may be a bit more
complex.
gortiz commented on code in PR #12808:
URL: https://github.com/apache/pinot/pull/12808#discussion_r1558916116
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/DirectMemory.java:
##
@@ -56,8 +56,12 @@ public void flush() {
@Override
public
Jackie-Jiang commented on code in PR #12808:
URL: https://github.com/apache/pinot/pull/12808#discussion_r1558289310
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/DirectMemory.java:
##
@@ -56,8 +56,12 @@ public void flush() {
@Override
siddharthteotia commented on PR #12808:
URL: https://github.com/apache/pinot/pull/12808#issuecomment-2044060741
I feel we can remove the method level `synchronize` and declare the field as
`volatile` ?
--
This is an automated message from the Apache Git Service.
To respond to the
codecov-commenter commented on PR #12808:
URL: https://github.com/apache/pinot/pull/12808#issuecomment-2042030907
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12808?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
gortiz opened a new pull request, #12808:
URL: https://github.com/apache/pinot/pull/12808
This PR continues what has been done in #12794.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
