Re: [PR] pluggable partial upsert merger [pinot]

2024-04-05 Thread via GitHub
Jackie-Jiang merged PR #11983: URL: https://github.com/apache/pinot/pull/11983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1552936971 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -61,11 +62,12 @@ public void init(TableConf

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1552669242 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -61,11 +62,12 @@ public void init(TableConfig

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1552327323 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -32,76 +31,79 @@ /** * Handler for partial-upser

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1551701865 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -61,11 +62,12 @@ public void init(TableConf

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1551631254 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertMergerFactory.java: ## @@ -18,39 +18,50 @@ */ package org.apach

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-04 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1551615323 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -32,76 +31,79 @@ /** * Handler for partial-upser

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-03 Thread via GitHub
Jackie-Jiang commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1550949947 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -32,76 +31,79 @@ /** * Handler for partial-upsert.

Re: [PR] pluggable partial upsert merger [pinot]

2024-04-01 Thread via GitHub
rohityadav1993 commented on PR #11983: URL: https://github.com/apache/pinot/pull/11983#issuecomment-2030364352 @Jackie-Jiang @deemoliu , please review the updated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] pluggable partial upsert merger [pinot]

2024-03-18 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1528985173 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -918,32 +918,43 @@ static void validatePartialUpsertStrate

Re: [PR] pluggable partial upsert merger [pinot]

2024-03-14 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1524914532 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -18,89 +18,82 @@ */ package org.apache.pinot.segme

Re: [PR] pluggable partial upsert merger [pinot]

2024-03-11 Thread via GitHub
Jackie-Jiang commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1520578347 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -51,6 +51,9 @@ public enum Strategy { @JsonPropertyDescription("default up

Re: [PR] pluggable partial upsert merger [pinot]

2024-03-09 Thread via GitHub
rohityadav1993 commented on PR #11983: URL: https://github.com/apache/pinot/pull/11983#issuecomment-1986978948 The integration test failure is in delete table flow which is unrelated to the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] pluggable partial upsert merger [pinot]

2024-03-07 Thread via GitHub
rohityadav1993 commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1517352187 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -307,7 +309,7 @@ protected Gen

Re: [PR] pluggable partial upsert merger [pinot]

2023-11-30 Thread via GitHub
Jackie-Jiang commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1411467937 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -34,72 +33,85 @@ * Handler for partial-upsert. */

Re: [PR] pluggable partial upsert merger [pinot]

2023-11-22 Thread via GitHub
deemoliu commented on code in PR #11983: URL: https://github.com/apache/pinot/pull/11983#discussion_r1401365070 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -106,8 +106,8 @@ public void init(TableConfig tab

Re: [PR] pluggable partial upsert merger [pinot]

2023-11-21 Thread via GitHub
rohityadav1993 commented on PR #11983: URL: https://github.com/apache/pinot/pull/11983#issuecomment-1822200867 > Please add some description to the PR, including what support is added, how to configure it etc. @Jackie-Jiang, please review, added the necessary details. -- This is an