Jackie-Jiang merged PR #13040:
URL: https://github.com/apache/pinot/pull/13040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jackie-Jiang commented on PR #13040:
URL: https://github.com/apache/pinot/pull/13040#issuecomment-2088984901
> LGTM, but there are multiple tests failing, so I guess we would need to
fix something else
Find the reason. Currently we only set query option when it is not empty,
but the
Jackie-Jiang commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1586682821
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,24 +84,22 @@ public BrokerResponse
gortiz commented on PR #13040:
URL: https://github.com/apache/pinot/pull/13040#issuecomment-2088064750
LGTM, but there are multiple tests failing, so I guess we would need to fix
something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gortiz commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1585949962
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,24 +84,22 @@ public BrokerResponse
codecov-commenter commented on PR #13040:
URL: https://github.com/apache/pinot/pull/13040#issuecomment-2087894076
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13040?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
Jackie-Jiang commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1585793958
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,24 +84,22 @@ public BrokerResponse
Jackie-Jiang opened a new pull request, #13040:
URL: https://github.com/apache/pinot/pull/13040
- Cleanup the deprecated debug options, and old PQL related query options
- Fix the double query parsing in multi-stage engine
- Fix the inconsistent behavior when query parsing fails: do
