[GitHub] [pulsar] codelipenghui commented on a change in pull request #3830: Fix read batching message by pulsar reader

codelipenghui commented on a change in pull request #3830: Fix read batching message by pulsar reader URL: https://github.com/apache/pulsar/pull/3830#discussion_r266190359 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -143

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473502631 run Integration Tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473502619 run cpp tests This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar] congbobo184 removed a comment on issue #3752: revise the schema default type not null

congbobo184 removed a comment on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473501497 run java8 tests This is an automated message from the Apache Git Ser

[GitHub] [pulsar] congbobo184 removed a comment on issue #3752: revise the schema default type not null

congbobo184 removed a comment on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473300193 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473501497 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] srkukarni merged pull request #3827: Expand add env functionality to add variables if not present

srkukarni merged pull request #3827: Expand add env functionality to add variables if not present URL: https://github.com/apache/pulsar/pull/3827 This is an automated message from the Apache Git Service. To respond to the me

[pulsar] branch master updated: Expand add env functionality to add variables if not present (#3827)

This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new da2bb66 Expand add env functionality to add

[GitHub] [pulsar] srkukarni commented on issue #3827: Expand add env functionality to add variables if not present

srkukarni commented on issue #3827: Expand add env functionality to add variables if not present URL: https://github.com/apache/pulsar/pull/3827#issuecomment-473495130 run integration tests This is an automated message from t

[pulsar] branch master updated: Use correct number of messages in batch for publish rate stats during replication (#3834)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ce13251 Use correct number of messages in batch

[GitHub] [pulsar] merlimat merged pull request #3834: Use correct number of messages in batch for publish rate stats during replication

merlimat merged pull request #3834: Use correct number of messages in batch for publish rate stats during replication URL: https://github.com/apache/pulsar/pull/3834 This is an automated message from the Apache Git Service.

[GitHub] [pulsar] tcbuzor commented on issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded

tcbuzor commented on issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded URL: https://github.com/apache/pulsar/issues/3832#issuecomment-473468295 I got the same exception with the url option. B/W, I already added the follo

[GitHub] [pulsar] rdhabalia commented on a change in pull request #3786: [pulsar-function] fix deadlock in pulsar-source

rdhabalia commented on a change in pull request #3786: [pulsar-function] fix deadlock in pulsar-source URL: https://github.com/apache/pulsar/pull/3786#discussion_r266169774 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java #

[GitHub] [pulsar] merlimat opened a new pull request #3834: Use correct number of messages in batch for publish rate stats during replication

merlimat opened a new pull request #3834: Use correct number of messages in batch for publish rate stats during replication URL: https://github.com/apache/pulsar/pull/3834 ### Motivation When replicator is repackaging the messages for replication, it's always passing 1 for messages

[pulsar] branch master updated: Fix topic name logic for partitioned topics (#3693)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new fdaa9e3 Fix topic name logic for partitioned

[GitHub] [pulsar] jerrypeng merged pull request #3693: Fix topic name logic for partitioned topics

jerrypeng merged pull request #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] merlimat commented on a change in pull request #3830: Fix read batching message by pulsar reader

merlimat commented on a change in pull request #3830: Fix read batching message by pulsar reader URL: https://github.com/apache/pulsar/pull/3830#discussion_r266159040 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1431,6 +

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473453206 @ivankelly you are correct service accounts are not needed to mount secrets in pods. I have remove the service account related code

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266157897 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/ClearTextFunctionToken

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266155384 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/ClearTextFunctionToken

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266153604 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/ClearTextFunctionToken

[GitHub] [pulsar] rdhabalia removed a comment on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet

rdhabalia removed a comment on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet URL: https://github.com/apache/pulsar/pull/3818#issuecomment-473435018 rerun integration tests rerun java8 tests This is an

[GitHub] [pulsar] rdhabalia commented on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet

rdhabalia commented on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet URL: https://github.com/apache/pulsar/pull/3818#issuecomment-473435018 rerun integration tests rerun java8 tests This is an automate

[GitHub] [pulsar] rdhabalia commented on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet

rdhabalia commented on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet URL: https://github.com/apache/pulsar/pull/3818#issuecomment-473409151 retest this please This is an automated message from the Apache

[GitHub] [pulsar] rdhabalia removed a comment on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet

rdhabalia removed a comment on issue #3818: [pulsar-common] add open Concurrent LongPair RangeSet URL: https://github.com/apache/pulsar/pull/3818#issuecomment-473409151 retest this please This is an automated message from the

[GitHub] [pulsar] geyrix57 opened a new issue #3833: Error offloading:

geyrix57 opened a new issue #3833: Error offloading: URL: https://github.com/apache/pulsar/issues/3833 I'm getting this error when trying to manually offload a topic to s3 bucket. Broker config managedLedgerOffloadDriver=aws-s3 s3ManagedLedgerOffloadRegion=us-west-2 s3Ma

[GitHub] [pulsar] ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions

ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473397683 @jerrypeng > I don't believe that is the correct design choice because now the runtime is making assumptions on what the data in F

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266102584 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.j

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266099274 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeFa

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473393406 @ivankelly responding to your comments > First of all, service accounts are not needed, you can attached the secret directly to

[GitHub] [pulsar] merlimat commented on issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded

merlimat commented on issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded URL: https://github.com/apache/pulsar/issues/3832#issuecomment-473391618 @tcbuzor this looks like a mismatch between client and server on whether TL

[GitHub] [pulsar] tcbuzor opened a new issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded

tcbuzor opened a new issue #3832: io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 5242880: 369295620 - discarded URL: https://github.com/apache/pulsar/issues/3832 **Describe the bug** I installed Apache pulsar 2.3.0 and set up TLS by following the steps descr

[GitHub] [pulsar] srkukarni commented on issue #3827: Expand add env functionality to add variables if not present

srkukarni commented on issue #3827: Expand add env functionality to add variables if not present URL: https://github.com/apache/pulsar/pull/3827#issuecomment-473375339 run integration tests This is an automated message from t

[GitHub] [pulsar] srkukarni commented on issue #3827: Expand add env functionality to add variables if not present

srkukarni commented on issue #3827: Expand add env functionality to add variables if not present URL: https://github.com/apache/pulsar/pull/3827#issuecomment-473353067 run integration tests This is an automated message from t

[GitHub] [pulsar] ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266050433 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/ClearTextFunctionToken

[GitHub] [pulsar] ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266040261 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.j

[GitHub] [pulsar] ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266050013 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthData.java

[GitHub] [pulsar] ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266038911 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeFa

[GitHub] [pulsar] ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions

ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473344350 @jerrypeng So mapping out the interactions here, yields the following sequence diagram. ![image](https://user-images.github

[GitHub] [pulsar] ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

ivankelly commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r266037227 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/KubernetesFunctionAuth

[GitHub] [pulsar] sijie commented on issue #3830: Fix read batching message by pulsar reader

sijie commented on issue #3830: Fix read batching message by pulsar reader URL: https://github.com/apache/pulsar/pull/3830#issuecomment-473329689 run java8 tests run integration tests This is an automated message from the A

[GitHub] [pulsar] sijie commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector

sijie commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector URL: https://github.com/apache/pulsar/pull/3825#discussion_r266027748 ## File path: pulsar-io/debezium/mysql/src/main/java/org/apache/pulsar/io/debezium/mysql/DebeziumMys

[GitHub] [pulsar] sijie commented on issue #3829: [Issue 3806] Fix NPE while call PartitionedProducerImpl.getStats()

sijie commented on issue #3829: [Issue 3806] Fix NPE while call PartitionedProducerImpl.getStats() URL: https://github.com/apache/pulsar/pull/3829#issuecomment-473326758 > I got stuck about the unit test, can you give me some advice? Thanks! you can just add a new test file `Partiti

[GitHub] [pulsar] ambition119 commented on issue #3831: [schema] support timestamp/date schema

ambition119 commented on issue #3831: [schema] support timestamp/date schema URL: https://github.com/apache/pulsar/issues/3831#issuecomment-473320786 is java.sql.Date/Time/Time/Timestamp? This is an automated message from the

[GitHub] [pulsar] ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions

ivankelly commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473315125 @jerrypeng So, in the sequence you have, the service account bit is entirely unnecessary. Rather than specifying a service account for

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473300193 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473251615 run Integration Tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] congbobo184 removed a comment on issue #3752: revise the schema default type not null

congbobo184 removed a comment on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473251549 run cpp tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] congbobo184 commented on issue #3752: revise the schema default type not null

congbobo184 commented on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473251549 run cpp tests This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar] congbobo184 removed a comment on issue #3752: revise the schema default type not null

congbobo184 removed a comment on issue #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#issuecomment-473251615 run Integration Tests This is an automated message from the Apache G

[GitHub] [pulsar] sijie opened a new issue #3831: [schema] support timestamp/date schema

sijie opened a new issue #3831: [schema] support timestamp/date schema URL: https://github.com/apache/pulsar/issues/3831 **Is your feature request related to a problem? Please describe.** `timestamp` or `date` is a typical type supported in other data systems. we need to support `tim

[GitHub] [pulsar] codelipenghui opened a new pull request #3830: Fix read batching message by pulsar reader

codelipenghui opened a new pull request #3830: Fix read batching message by pulsar reader URL: https://github.com/apache/pulsar/pull/3830 ### Motivation ```java ``` ### Modifications *Describe the modifications you've done.* ### Verifying this change -

[GitHub] [pulsar] jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector

jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector URL: https://github.com/apache/pulsar/pull/3825#discussion_r265909742 ## File path: pulsar-io/debezium/core/pom.xml ## @@ -0,0 +1,110 @@ + +http://maven.apache

[GitHub] [pulsar] sijie commented on issue #3807: Ledger Offload error when use S3 type

sijie commented on issue #3807: Ledger Offload error when use S3 type URL: https://github.com/apache/pulsar/issues/3807#issuecomment-473211686 @jiazhai are you working on this bug? This is an automated message from the Apache

[GitHub] [pulsar] murong00 commented on issue #3829: [Issue 3806] Fix NPE while call PartitionedProducerImpl.getStats()

murong00 commented on issue #3829: [Issue 3806] Fix NPE while call PartitionedProducerImpl.getStats() URL: https://github.com/apache/pulsar/pull/3829#issuecomment-473210167 @sijie @jiazhai Not so sure about this issue, by the way, also found in `ConsumerStatsRecorderImpl`, I got stuck abou

[GitHub] [pulsar] jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector

jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector URL: https://github.com/apache/pulsar/pull/3825#discussion_r265895743 ## File path: pulsar-io/debezium/mysql/src/main/java/org/apache/pulsar/io/debezium/mysql/DebeziumM

[pulsar] branch asf-site updated: Updated site at revision fff02e2

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new f77740f Updated site at revision fff02e2 f7

[GitHub] [pulsar] jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector

jiazhai commented on a change in pull request #3825: hide kafka-connecter details for easy use debezium connector URL: https://github.com/apache/pulsar/pull/3825#discussion_r265888276 ## File path: pulsar-io/debezium/mysql/src/main/resources/debezium-mysql-source-config.yaml #

[GitHub] [pulsar] jerrypeng commented on issue #3828: Pulsar SQL is not able to read the latest message

jerrypeng commented on issue #3828: Pulsar SQL is not able to read the latest message URL: https://github.com/apache/pulsar/issues/3828#issuecomment-473179814 @sijie I totally agree we should add something like this. I was just presenting some previous thoughts we have had on this problem