[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100708 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100825 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100532 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] sijie commented on issue #4062: Delayed message delivery implementation

2019-04-16 Thread GitBox
sijie commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-483959807 nvm. I saw the email in the email thread now. This is an automated message from the

[GitHub] [pulsar] sijie commented on issue #4062: Delayed message delivery implementation

2019-04-16 Thread GitBox
sijie commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-483959091 @merlimat : how is this different from #3155? Also I think there was a long thread discussion about delayed message implementation. there we

[GitHub] [pulsar] ambition119 opened a new pull request #4063: [pulsar-common] MaxMessageSize to user configuration

2019-04-16 Thread GitBox
ambition119 opened a new pull request #4063: [pulsar-common] MaxMessageSize to user configuration URL: https://github.com/apache/pulsar/pull/4063 ### Motivation Fixes #4054 ### Modifications PulsarDecoder use common.conf set MaxMessageSize value ### Verifying th

[GitHub] [pulsar] chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483922911 @merlimat go supports version tag in go get. https://github.com/golang/go/wiki/Module

[GitHub] [pulsar] jerrypeng commented on issue #4058: improve data-generator source performance

2019-04-16 Thread GitBox
jerrypeng commented on issue #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058#issuecomment-483912078 rerun java8 tests This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483911919 I think the problem is you’re trying to fetch a specific tad with go get which I’m not su

[pulsar] branch master updated: ack records in datagenerator print sink (#4052)

2019-04-16 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 090d11a ack records in datagenerator print s

[GitHub] [pulsar] jerrypeng merged pull request #4052: ack records in datagenerator print sink

2019-04-16 Thread GitBox
jerrypeng merged pull request #4052: ack records in datagenerator print sink URL: https://github.com/apache/pulsar/pull/4052 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [pulsar] merlimat opened a new pull request #4062: Delayed message delivery implementation

2019-04-16 Thread GitBox
merlimat opened a new pull request #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062 ### Motivation Allow the option to mark messages for delayed delivery. Notes: * If delayed delivery is disabled, messages are always delivered

[GitHub] [pulsar] chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483885705 @merlimat You mean I need to checkout it manually. It is not supports go module? -

[GitHub] [pulsar] ConcurrencyPractitioner commented on issue #3217: Auto scaling up and down number of partitions

2019-04-16 Thread GitBox
ConcurrencyPractitioner commented on issue #3217: Auto scaling up and down number of partitions URL: https://github.com/apache/pulsar/issues/3217#issuecomment-483883348 Oh, just for ease of access. A PIP was created for this issue and here is the design doc: https://docs.google.com/do

[GitHub] [pulsar] merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483881704 The tag is there though.. https://github.com/apache/pulsar/tree/v2.3.1/pulsar-client-go

[pulsar] branch master updated: Upgrade athenz libraries (#4056)

2019-04-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 12a5001 Upgrade athenz libraries (#4056) 12a500

[GitHub] [pulsar] merlimat merged pull request #4056: [client] Upgrade athenz libraries

2019-04-16 Thread GitBox
merlimat merged pull request #4056: [client] Upgrade athenz libraries URL: https://github.com/apache/pulsar/pull/4056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pulsar] chrislearn edited a comment on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
chrislearn edited a comment on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483879612 @merlimat I use latest libpulsar C++ library, 2.3.1 I use go module to instal

[GitHub] [pulsar] chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
chrislearn commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483879612 I use latest libpulsar C++ library, 2.3.1 I use go module to install go client, but w

[GitHub] [pulsar] jerrypeng opened a new pull request #4061: Fix update cli source sink

2019-04-16 Thread GitBox
jerrypeng opened a new pull request #4061: Fix update cli source sink URL: https://github.com/apache/pulsar/pull/4061 ### Motivation When updating sources and sink using the CLI, if a parallelism is not specified, the parallelism is set to 1 which will override the existing parallelism.

[GitHub] [pulsar] jerrypeng closed pull request #4060: Fix source sink cli update

2019-04-16 Thread GitBox
jerrypeng closed pull request #4060: Fix source sink cli update URL: https://github.com/apache/pulsar/pull/4060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] jerrypeng opened a new pull request #4060: Fix source sink cli update

2019-04-16 Thread GitBox
jerrypeng opened a new pull request #4060: Fix source sink cli update URL: https://github.com/apache/pulsar/pull/4060 ### Motivation When updating sources and sink using the CLI, if a parallelism is not specified, the parallelism is set to 1 which will override the existing parallel

[GitHub] [pulsar] jerrypeng commented on issue #4058: improve data-generator source performance

2019-04-16 Thread GitBox
jerrypeng commented on issue #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058#issuecomment-483875668 rerun java8 tests rerun integration tests This is an automated message fro

[GitHub] [pulsar] lovelle commented on a change in pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-16 Thread GitBox
lovelle commented on a change in pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059#discussion_r276017683 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integratio

[GitHub] [pulsar] jerrypeng commented on issue #4052: ack records in datagenerator print sink

2019-04-16 Thread GitBox
jerrypeng commented on issue #4052: ack records in datagenerator print sink URL: https://github.com/apache/pulsar/pull/4052#issuecomment-483864710 rerun java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] merlimat opened a new pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-16 Thread GitBox
merlimat opened a new pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059 ### Motivation Similar to what done in #3869 for PulsarAdmin, this is fixing HTTP redirects when are internally fo

[GitHub] [pulsar] jerrypeng opened a new pull request #4058: improve data-generator source performance

2019-04-16 Thread GitBox
jerrypeng opened a new pull request #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058 ### Motivation Only initialize factory once in the beginning This is an automated mes

[GitHub] [pulsar] jerrypeng commented on issue #4052: ack records in datagenerator print sink

2019-04-16 Thread GitBox
jerrypeng commented on issue #4052: ack records in datagenerator print sink URL: https://github.com/apache/pulsar/pull/4052#issuecomment-483803734 rerun java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] lovelle commented on a change in pull request #4031: Feature - support seek() on Reader

2019-04-16 Thread GitBox
lovelle commented on a change in pull request #4031: Feature - support seek() on Reader URL: https://github.com/apache/pulsar/pull/4031#discussion_r275918605 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java #

[GitHub] [pulsar] lovelle commented on a change in pull request #4031: Feature - support seek() on Reader

2019-04-16 Thread GitBox
lovelle commented on a change in pull request #4031: Feature - support seek() on Reader URL: https://github.com/apache/pulsar/pull/4031#discussion_r275918605 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java #

[GitHub] [pulsar] merlimat commented on issue #3877: Read timeout when listing topics

2019-04-16 Thread GitBox
merlimat commented on issue #3877: Read timeout when listing topics URL: https://github.com/apache/pulsar/issues/3877#issuecomment-483759579 This issue was fixed in 2.3.1. Can you try with that? This is an automated message f

[GitHub] [pulsar] devinbost edited a comment on issue #3877: Read timeout when listing topics

2019-04-16 Thread GitBox
devinbost edited a comment on issue #3877: Read timeout when listing topics URL: https://github.com/apache/pulsar/issues/3877#issuecomment-483756613 I just experienced this as well on 2.3.0. I was using the Java Admin API. (However, my timeout was triggered by calling `deleteFunction` and

[GitHub] [pulsar] devinbost commented on issue #3877: Read timeout when listing topics

2019-04-16 Thread GitBox
devinbost commented on issue #3877: Read timeout when listing topics URL: https://github.com/apache/pulsar/issues/3877#issuecomment-483756613 I just experienced this as well on 2.3.0. I was using the Java Admin API. This is a

[GitHub] [pulsar] merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
merlimat commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-483738612 @chrislearn Which tag are you pulling of the Go code? and which version of `libpulsar` C+

[GitHub] [pulsar] massakam commented on issue #4056: [client] Upgrade athenz libraries

2019-04-16 Thread GitBox
massakam commented on issue #4056: [client] Upgrade athenz libraries URL: https://github.com/apache/pulsar/pull/4056#issuecomment-483700927 rerun integration tests This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] one70six opened a new issue #4057: Security Vulnerabilities - Black Duck Scan - Pulsar v.2.3.1

2019-04-16 Thread GitBox
one70six opened a new issue #4057: Security Vulnerabilities - Black Duck Scan - Pulsar v.2.3.1 URL: https://github.com/apache/pulsar/issues/4057 ## Issue Black Duck, a product by Synopsys that scans for open source security threats, uncovered a few issues with dependencies for the Pulsa

[GitHub] [pulsar] nyluke commented on issue #4051: server checksum error when using pulsar-log4j2-appender

2019-04-16 Thread GitBox
nyluke commented on issue #4051: server checksum error when using pulsar-log4j2-appender URL: https://github.com/apache/pulsar/issues/4051#issuecomment-483692058 ``` [ForkJoinPool.commonPool-worker-4] INFO org.apache.pulsar.broker.service.ServerCnx - [/127.0.0.1:40776] Created new pro

[GitHub] [pulsar] ambition119 commented on issue #4054: Exposing `MaxMessageSize` to user configuration

2019-04-16 Thread GitBox
ambition119 commented on issue #4054: Exposing `MaxMessageSize` to user configuration URL: https://github.com/apache/pulsar/issues/4054#issuecomment-483682262 I'm interested in trying to solve this issue, tks This is an autom

[GitHub] [pulsar] massakam opened a new pull request #4056: [client] Upgrade athenz libraries

2019-04-16 Thread GitBox
massakam opened a new pull request #4056: [client] Upgrade athenz libraries URL: https://github.com/apache/pulsar/pull/4056 ### Motivation The version of Athenz libraries that Pulsar is using now is 1.7.17, which is a little old. Athenz v1.7.17 has a dependency on a library with secu

[GitHub] [pulsar] zymap commented on issue #4018: Support multi-host for pulsar-admin

2019-04-16 Thread GitBox
zymap commented on issue #4018: Support multi-host for pulsar-admin URL: https://github.com/apache/pulsar/pull/4018#issuecomment-483594192 I'm met some encode error. fixing.. This is an automated message from the Apache Git Se

[pulsar] branch master updated: [go function]support log topic for go function (#4008)

2019-04-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ccf4581 [go function]support log topic for go fu

[GitHub] [pulsar] sijie merged pull request #4008: [go function]support log topic for go function

2019-04-16 Thread GitBox
sijie merged pull request #4008: [go function]support log topic for go function URL: https://github.com/apache/pulsar/pull/4008 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] sijie commented on issue #4031: Feature - support seek() on Reader

2019-04-16 Thread GitBox
sijie commented on issue #4031: Feature - support seek() on Reader URL: https://github.com/apache/pulsar/pull/4031#issuecomment-483564479 run java8 tests This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] sijie commented on issue #3983: [Issue#3976] [component/client] Adding config for ReaderImpl

2019-04-16 Thread GitBox
sijie commented on issue #3983: [Issue#3976] [component/client] Adding config for ReaderImpl URL: https://github.com/apache/pulsar/pull/3983#issuecomment-483563561 @ConcurrencyPractitioner sure. doing it. This is an automated

[GitHub] [pulsar] sijie closed issue #4047: Need to catch up docs for functions/sink/source in Admin CLI

2019-04-16 Thread GitBox
sijie closed issue #4047: Need to catch up docs for functions/sink/source in Admin CLI URL: https://github.com/apache/pulsar/issues/4047 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] sijie merged pull request #4048: [Issue 4047] Catch up docs for functions/sink/source in Admin CLI

2019-04-16 Thread GitBox
sijie merged pull request #4048: [Issue 4047] Catch up docs for functions/sink/source in Admin CLI URL: https://github.com/apache/pulsar/pull/4048 This is an automated message from the Apache Git Service. To respond to the m

[pulsar] branch master updated: [Issue 4047] Catch up docs for functions/sink/source in Admin CLI (#4048)

2019-04-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d72079d [Issue 4047] Catch up docs for functions

[GitHub] [pulsar] murong00 commented on a change in pull request #4046: [pulsar-io] [doc] Add docs for Redis sink

2019-04-16 Thread GitBox
murong00 commented on a change in pull request #4046: [pulsar-io] [doc] Add docs for Redis sink URL: https://github.com/apache/pulsar/pull/4046#discussion_r275662766 ## File path: site2/website/versioned_docs/version-2.3.1/io-redis.md ## @@ -0,0 +1,28 @@ +--- +id: version-

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275660260 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] chrislearn opened a new issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-04-16 Thread GitBox
chrislearn opened a new issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055 **Describe the bug** When I upgrade my app to use the latest pulsar 2.3.1, compile report this error: /