jerrypeng commented on issue #6787:
URL: https://github.com/apache/pulsar/pull/6787#issuecomment-617586912
@sijie @merlimat thanks for the review PTAL.
This is an automated message from the Apache Git Service.
To respond to t
jerrypeng commented on a change in pull request #6787:
URL: https://github.com/apache/pulsar/pull/6787#discussion_r412710336
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java
##
@@ -124,6 +130,8 @@ public void removeCurso
BewareMyPower commented on issue #6732:
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-617576990
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 98b818b Ensure that all dangling consumers are cleaned up during
failures (#6778)
add 9dc648a Fix localrunner
phemmer commented on issue #5138:
URL: https://github.com/apache/pulsar/issues/5138#issuecomment-617540979
I've created a wrapper around `pulsar-function-go/pf` which provides state
support. It's pretty minimal at the moment, and needs more work (concurrency
safety & documentation), but it
equanz commented on issue #227:
URL: https://github.com/apache/pulsar-client-go/pull/227#issuecomment-617518998
@wolfstudy @merlimat
Could you review this please?
In this PR, fixed `parseParams()`, and `Provider.Init()` to run.
---
merlimat opened a new pull request #6792:
URL: https://github.com/apache/pulsar/pull/6792
### Motivation
The `PulsarMockLedgerHandle.asyncAddEntry()` is retaining the bytebuf before
starting the operation. This makes it "ref-count neutral", though the real BK
client implementation i
merlimat opened a new pull request #6791:
URL: https://github.com/apache/pulsar/pull/6791
### Motivation
The current implementation of KeyShared subscriptions uses a mechanism to
divide they hash space across the available consumers. This is based on
dividing the currently assigned
zxbfeng commented on issue #1571:
URL: https://github.com/apache/pulsar/issues/1571#issuecomment-617503423
> A broker owner of a topic partition is always failing trying to read a
ledger because ledger doesn't exist in bookkeeper (we checked using `bookkeeper
shell ledger`).
>
> Bro
zxbfeng commented on issue #1571:
URL: https://github.com/apache/pulsar/issues/1571#issuecomment-617502972
> @bardock Skipping messages from that ledger should solve the issue.
>
> In particular you can get the internal stats for the topic:
>
> ```
> bin/pulsar admin persist
merlimat commented on issue #6647:
URL: https://github.com/apache/pulsar/pull/6647#issuecomment-617497271
Hi @codelipenghui. I'm failing to see a practical difference in the code
here compared to the previous implementation.
I think the only difference is when the `%` is done, but t
zplinuxlover commented on issue #6783:
URL: https://github.com/apache/pulsar/pull/6783#issuecomment-617495498
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
zplinuxlover commented on issue #6783:
URL: https://github.com/apache/pulsar/pull/6783#issuecomment-617495396
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
merlimat commented on a change in pull request #6778:
URL: https://github.com/apache/pulsar/pull/6778#discussion_r412599838
##
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##
@@ -99,11 +99,12 @@ public void open(Map co
merlimat commented on issue #6787:
URL: https://github.com/apache/pulsar/pull/6787#issuecomment-617489906
> Does this result in any data loss or unexpected behaviors when using the
reader API?
The reader, per definition, doesn't cause the data to be retained. In this
case, in the mo
This is an automated email from the ASF dual-hosted git repository.
sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 98b818b Ensure that all dangling consumers a
hangc0276 commented on issue #6705:
URL: https://github.com/apache/pulsar/pull/6705#issuecomment-617474793
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, ple
sijie commented on issue #6788:
URL: https://github.com/apache/pulsar/pull/6788#issuecomment-617473644
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6777:
URL: https://github.com/apache/pulsar/pull/6777#issuecomment-617473576
@zymap when you removed mysql from jdbc connector, do you need to fix the
integration test?
This is an automated message
sijie commented on issue #5241:
URL: https://github.com/apache/pulsar/issues/5241#issuecomment-617473254
This is solved by #6760
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 967c7ca Fix NPE issue in testcase
`org.apache.pulsar.broker.service.ServerCnxTest` (#6781)
add 3b48df1 [pulsar
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 188d896 [Issue 5935] Support multi pulsar clusters to use the same bk
cluster (#5985)
add 967c7ca Fix NPE issu
phemmer opened a new issue #6790:
URL: https://github.com/apache/pulsar/issues/6790
**Describe the bug**
When creating a go function with an input topic name that is non-normalized
(e.g. `public/default/input`), the function panics due to different topic names
being used.
**To Re
cdbartholomew commented on issue #6789:
URL: https://github.com/apache/pulsar/issues/6789#issuecomment-617468740
You can either configure authentication in your Prometheus scrape job or
disable authentication on the proxy metrics endpoint. To disable, you should be
able to set the followin
bschofield opened a new issue #6789:
URL: https://github.com/apache/pulsar/issues/6789
I am running a Pulsar deployment with TLS and Authentication on enabled on
the proxy only, and neither TLS nor Authentication enabled inside the private
cluster.
When Prometheus attempts to scrape
sijie opened a new pull request #6788:
URL: https://github.com/apache/pulsar/pull/6788
*Motivation*
Exceptions `Broker-znode owned by different zk-session` is commonly seen
when a broker
starts up in Kubernetes environment. That's because the previous znode is
not expired.
vzhikserg commented on issue #6770:
URL: https://github.com/apache/pulsar/pull/6770#issuecomment-617407056
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, ple
cbornet commented on issue #6720:
URL: https://github.com/apache/pulsar/pull/6720#issuecomment-617403363
The change is already in this PR. I did it in the [2nd
commit](https://github.com/apache/pulsar/pull/6720/commits/3a16679e8526da58214f66c16754fee1367eac2f).
---
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from fb930b7 Make the FunctionRunTimeManager methods used by rest-api
syncrhonized since the assignment tailer also is up
sijie commented on issue #6524:
URL: https://github.com/apache/pulsar/pull/6524#issuecomment-617391603
@codelipenghui @jiazhai can you review this pull request again?
This is an automated message from the Apache Git Service.
sijie commented on a change in pull request #6539:
URL: https://github.com/apache/pulsar/pull/6539#discussion_r398324960
##
File path: pulsar-function-go/examples/publishFunc/publish_func.go
##
@@ -0,0 +1,37 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
sijie commented on issue #6331:
URL: https://github.com/apache/pulsar/pull/6331#issuecomment-617391035
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6679:
URL: https://github.com/apache/pulsar/pull/6679#issuecomment-617390187
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6659:
URL: https://github.com/apache/pulsar/pull/6659#issuecomment-617389975
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6648:
URL: https://github.com/apache/pulsar/pull/6648#issuecomment-617389683
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6566:
URL: https://github.com/apache/pulsar/pull/6566#issuecomment-617389072
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6428:
URL: https://github.com/apache/pulsar/pull/6428#issuecomment-617388456
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
merlimat commented on a change in pull request #6787:
URL: https://github.com/apache/pulsar/pull/6787#discussion_r412458532
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java
##
@@ -124,6 +130,8 @@ public void removeCursor
sijie commented on issue #6730:
URL: https://github.com/apache/pulsar/pull/6730#issuecomment-617387726
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6719:
URL: https://github.com/apache/pulsar/pull/6719#issuecomment-617387316
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6516:
URL: https://github.com/apache/pulsar/pull/6516#issuecomment-617387105
@codelipenghui can you review this pull request again?
This is an automated message from the Apache Git Service.
To respon
sijie commented on a change in pull request #6750:
URL: https://github.com/apache/pulsar/pull/6750#discussion_r412456000
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##
@@ -861,7 +861,8 @@ public PulsarAdmin getClusterPulsarAdmi
sijie commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r412454454
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##
@@ -155,6 +158,9 @@
jerrypeng opened a new pull request #6787:
URL: https://github.com/apache/pulsar/pull/6787
### Motivation
When using Readers API, backlog quotas are still enforced on these ephemeral
readers.
### Modifications
If a cursor is non-durable then we don't add it to the min-h
sijie commented on issue #6760:
URL: https://github.com/apache/pulsar/pull/6760#issuecomment-617381386
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6764:
URL: https://github.com/apache/pulsar/pull/6764#issuecomment-617380745
@codelipenghui can you review this again?
This is an automated message from the Apache Git Service.
To respond to the mess
sijie commented on issue #6763:
URL: https://github.com/apache/pulsar/pull/6763#issuecomment-617380384
@jiazhai can you review it again?
This is an automated message from the Apache Git Service.
To respond to the message, ple
sijie commented on issue #6766:
URL: https://github.com/apache/pulsar/pull/6766#issuecomment-617379981
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6767:
URL: https://github.com/apache/pulsar/pull/6767#issuecomment-617379263
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6769:
URL: https://github.com/apache/pulsar/pull/6769#issuecomment-617378666
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6770:
URL: https://github.com/apache/pulsar/pull/6770#issuecomment-617377972
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6772:
URL: https://github.com/apache/pulsar/pull/6772#issuecomment-617377676
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6777:
URL: https://github.com/apache/pulsar/pull/6777#issuecomment-617374295
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6776:
URL: https://github.com/apache/pulsar/pull/6776#issuecomment-617373473
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6781:
URL: https://github.com/apache/pulsar/pull/6781#issuecomment-617372291
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6783:
URL: https://github.com/apache/pulsar/pull/6783#issuecomment-617371569
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6779:
URL: https://github.com/apache/pulsar/pull/6779#issuecomment-617370751
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message, please
sijie commented on issue #6782:
URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617365809
@shiv4289 - did you remember which Authentication is not serializable in
#4283?
This is an automated message from the Apa
rdhabalia commented on issue #6782:
URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617360903
> If we want to switch it back to non-transient, we have to fix that
implementation to make it serializable.
Can you point me that Auth which is not serializable?
This is an automated email from the ASF dual-hosted git repository.
sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new fb930b7 Make the FunctionRunTimeManager meth
sijie commented on issue #6782:
URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617341552
@rdhabalia I think Flink builder does the same approach before which takes
the Authentication object. But I think there is one implementation of
Authentication interface is not serializab
rdhabalia commented on issue #6782:
URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617325609
There are few issues here:
1. User can set `Authentication` with [3 different
ways](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client
phemmer commented on issue #6768:
URL: https://github.com/apache/pulsar/issues/6768#issuecomment-617319578
@codelipenghui specifying a namespace has no effect. Namespace is optional
in avro.
The code you reference uses neither `enum` nor an embedded `fields`, which
are the types documen
srkukarni opened a new pull request #6786:
URL: https://github.com/apache/pulsar/pull/6786
Make the FunctionRunTimeManager methods used by rest-api syncrhonized since
the assignment tailer also is updating it. This fixes the flakiness in
PulsarFunctionE2ESecurityTest
*(If th
bschofield edited a comment on issue #6785:
URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617285319
I rescind the last paragraph. I thought that `pulsar.MessageID`s were being
reused, but that was in fact a separate bug in my code :sob:.
FWIW, while I was debugging,
bschofield edited a comment on issue #6785:
URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617285319
I rescind the last paragraph I thought that `pulsar.MessageID`s were being
reused, but that was in fact a separate bug in my code :sob:.
FWIW, I did manage to work aro
bschofield edited a comment on issue #6785:
URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617285319
I rescind the last paragraph I thought that `pulsar.MessageID`s were being
reused, but that was in fact a separate bug in my code :sob:.
FWIW, I did manage to work aro
sijie commented on issue #5459:
URL: https://github.com/apache/pulsar/issues/5459#issuecomment-617286517
Close this issue because we have started publishing python client 10.15
since 2.4.2 release.
This is an automated messa
bschofield commented on issue #6785:
URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617285319
I rescind the last paragraph -- that was a bug in my code :sob:. So this bug
still exists, but it is (probably) less critical.
tuteng commented on issue #6774:
URL: https://github.com/apache/pulsar/pull/6774#issuecomment-617219051
@codelipenghui Thanks for your comment, I have fixed, PTAL
This is an automated message from the Apache Git Service.
To r
hozn commented on issue #5459:
URL: https://github.com/apache/pulsar/issues/5459#issuecomment-617208107
@sijie -- good point; I upgraded protobuf and this fixed the problem for me!
```
==> Upgrading protobuf 3.7.1 -> 3.11.4
```
bschofield opened a new issue #6785:
URL: https://github.com/apache/pulsar/issues/6785
As noted in [this
comment](https://github.com/apache/pulsar/issues/3177#issuecomment-471866729),
go code like this can cause a panic:
```golang
id := msg.ID().Serialize()
idParsed := pulsar.
zxbfeng opened a new issue #232:
URL: https://github.com/apache/pulsar-client-go/issues/232
pulsar version:2.4.2
The pulsar system version is 2.4.2, The producer sends Messages to pulsar
successfully, but the consumers can't consume it. Consumers are servers which
have been started a lo
zplinuxlover commented on issue #6783:
URL: https://github.com/apache/pulsar/pull/6783#issuecomment-617099585
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
zplinuxlover commented on issue #6783:
URL: https://github.com/apache/pulsar/pull/6783#issuecomment-617099375
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
otmanel31 commented on issue #6599:
URL: https://github.com/apache/pulsar/issues/6599#issuecomment-617087638
hi, yes the namespace is created as describe in official documentation.
this issue was resolved for me by setting/upgrading number of core of my
virtual machine.
---
This is an automated email from the ASF dual-hosted git repository.
guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git
The following commit(s) were added to refs/heads/master by this push:
new 424788d Serve frontend directly from
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 0338d17 Publish chart index to gh-pag
codelipenghui opened a new pull request #6784:
URL: https://github.com/apache/pulsar/pull/6784
### Motivation
Add topic compaction test for the empty message.
### Modifications
Added unit test.
### Does this pull request potentially affect one of the following par
sijie commented on issue #6782:
URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617055757
@rdhabalia this will break other usages. because not all authentication
implementation are serializable. the change in #4284 is to use
ClientConfigurationData to reconstruct the Authentic
zplinuxlover opened a new pull request #6783:
URL: https://github.com/apache/pulsar/pull/6783
Describe the bug
The messageReceiveTimeoutMs value in the PulsarConsumerSource class is
hardcoded to 100ms and cannot be altered through configuration at present.
To Reproduce
This is
rdhabalia opened a new pull request #6782:
URL: https://github.com/apache/pulsar/pull/6782
### Motivation
In #4284, made
[Authentication](https://github.com/apache/pulsar/blob/master/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Authentication.java#L33)
a transient under
zplinuxlover opened a new pull request #6781:
URL: https://github.com/apache/pulsar/pull/6781
when i run the testcase `org.apache.pulsar.broker.service.ServerCnxTest` code
three will be NPE exception, change the code,
add `policies.clusterDispatchRate = Maps.newHashMap();`
the test
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to annotated tag v2.5.0
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git.
*** WARNING: tag v2.5.0 was modified! ***
from 47f05b7 (commit)
to 5ce3ea0 (tag)
tagging 47f05b
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
commit 7f616763ee6020ad50022f79316c0520b6757ffb
Author: Sijie Guo
AuthorDate: Tue Apr 21 00:52:15 2020 -0700
C
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git.
at 7f61676 Create a gh-pages branch with a chart index yaml for
placeholder
This branch includes the foll
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 47f05b7 Add github action to check li
sijie commented on issue #6720:
URL: https://github.com/apache/pulsar/pull/6720#issuecomment-617000174
> I'll do the change for Consumer. It will also make Topic,
NonPersistentTopic, and PersistentTopic depend of ServerCnx instead of
PulsarServerCnx so that's better.
It is a bit har
88 matches
Mail list logo
