[GitHub] [pulsar] rdhabalia commented on a change in pull request #7910: [pulsar-broker] add configuration to set number of channels per bookie

2020-08-27 Thread GitBox
rdhabalia commented on a change in pull request #7910: URL: https://github.com/apache/pulsar/pull/7910#discussion_r478848714 ## File path: conf/broker.conf ## @@ -624,6 +624,9 @@ bookkeeperClientTimeoutInSeconds=30 # Using a value of 0, is disabling the speculative reads book

[GitHub] [pulsar] kezhenxu94 commented on pull request #7880: [Issue 7873][chore]: remove unused field

2020-08-27 Thread GitBox
kezhenxu94 commented on pull request #7880: URL: https://github.com/apache/pulsar/pull/7880#issuecomment-682331478 closing as no update This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] kezhenxu94 closed pull request #7880: [Issue 7873][chore]: remove unused field

2020-08-27 Thread GitBox
kezhenxu94 closed pull request #7880: URL: https://github.com/apache/pulsar/pull/7880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] kezhenxu94 closed pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

2020-08-27 Thread GitBox
kezhenxu94 closed pull request #7877: URL: https://github.com/apache/pulsar/pull/7877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] kezhenxu94 commented on pull request #7877: [Issue 7749][chore] Use maven wrapper to lock maven version

2020-08-27 Thread GitBox
kezhenxu94 commented on pull request #7877: URL: https://github.com/apache/pulsar/pull/7877#issuecomment-682331356 closing as no response This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] kezhenxu94 commented on pull request #7880: [Issue 7873][chore]: remove unused field

2020-08-27 Thread GitBox
kezhenxu94 commented on pull request #7880: URL: https://github.com/apache/pulsar/pull/7880#issuecomment-682331074 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] kezhenxu94 removed a comment on pull request #7880: [Issue 7873][chore]: remove unused field

2020-08-27 Thread GitBox
kezhenxu94 removed a comment on pull request #7880: URL: https://github.com/apache/pulsar/pull/7880#issuecomment-682331074 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to

[pulsar] branch master updated: Add hostname to consumer/producer properties in Pulsar Functions (#7897)

2020-08-27 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9471ac7 Add hostname to consumer/producer pr

[GitHub] [pulsar] jerrypeng merged pull request #7897: Add hostname to consumer/producer properties in Pulsar Functions

2020-08-27 Thread GitBox
jerrypeng merged pull request #7897: URL: https://github.com/apache/pulsar/pull/7897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] sunxiaoguang commented on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
sunxiaoguang commented on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-682325065 > The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : > > 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pul

[GitHub] [pulsar-client-go] wuYin removed a comment on pull request #359: Support retry letter topic

2020-08-27 Thread GitBox
wuYin removed a comment on pull request #359: URL: https://github.com/apache/pulsar-client-go/pull/359#issuecomment-682318139 run integration tests This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-client-go] wuYin commented on pull request #359: Support retry letter topic

2020-08-27 Thread GitBox
wuYin commented on pull request #359: URL: https://github.com/apache/pulsar-client-go/pull/359#issuecomment-682318139 run integration tests This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zhanghaou commented on pull request #7914: [ISSUE 7758] Support set Max Producer on topic level.

2020-08-27 Thread GitBox
zhanghaou commented on pull request #7914: URL: https://github.com/apache/pulsar/pull/7914#issuecomment-682314600 link [https://github.com/apache/pulsar/pull/7839](https://github.com/apache/pulsar/pull/7839) PTAL @zhaijack @codelipenghui

[GitHub] [pulsar] Huanli-Meng commented on pull request #7834: [Doc]--Update BookKeeper config

2020-08-27 Thread GitBox
Huanli-Meng commented on pull request #7834: URL: https://github.com/apache/pulsar/pull/7834#issuecomment-682302825 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] MarvinCai opened a new pull request #7917: Update document for how to pick active consumer for failover subscription.

2020-08-27 Thread GitBox
MarvinCai opened a new pull request #7917: URL: https://github.com/apache/pulsar/pull/7917 Update document to specify how active consumer is picked for partitioned and non-partitoned topic for failover subscription mode. The change was push in 2.4.2 but document has not been updated.

[GitHub] [pulsar] jiazhai commented on pull request #7916: [Website] Using github action to trigger build website

2020-08-27 Thread GitBox
jiazhai commented on pull request #7916: URL: https://github.com/apache/pulsar/pull/7916#issuecomment-682298662 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] gaoran10 commented on pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
gaoran10 commented on pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#issuecomment-682262883 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[pulsar] branch master updated (23dc5c7 -> 8c91197)

2020-08-27 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 23dc5c7 [broker] Fix deadlock when adding consumer (#7841) add 8c91197 convertFromConfig should support an

[GitHub] [pulsar] jerrypeng merged pull request #7890: convertFromConfig should support an overloading of cluster Name

2020-08-27 Thread GitBox
jerrypeng merged pull request #7890: URL: https://github.com/apache/pulsar/pull/7890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] sijie commented on issue #7895: Report compacted topic ledger info when calling get internal stats

2020-08-27 Thread GitBox
sijie commented on issue #7895: URL: https://github.com/apache/pulsar/issues/7895#issuecomment-682082566 Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] sijie commented on pull request #7908: Add pulsar version info metric

2020-08-27 Thread GitBox
sijie commented on pull request #7908: URL: https://github.com/apache/pulsar/pull/7908#issuecomment-682063040 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] gaoran10 commented on pull request #7194: Upgrade Presto version to 332

2020-08-27 Thread GitBox
gaoran10 commented on pull request #7194: URL: https://github.com/apache/pulsar/pull/7194#issuecomment-682061124 @dionjansen Hi, please take a look at this PR #7898, the problem you met was fixed. This is an automated messag

[GitHub] [pulsar] gaoran10 commented on a change in pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
gaoran10 commented on a change in pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#discussion_r478549595 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -2857,5 +2857,14 @@ private int applyMaxSizeCa

[GitHub] [pulsar] gaoran10 commented on pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
gaoran10 commented on pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#issuecomment-682058263 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] sijie commented on a change in pull request #7910: [pulsar-broker] add configuration to set number of channels per bookie

2020-08-27 Thread GitBox
sijie commented on a change in pull request #7910: URL: https://github.com/apache/pulsar/pull/7910#discussion_r478548802 ## File path: conf/broker.conf ## @@ -624,6 +624,9 @@ bookkeeperClientTimeoutInSeconds=30 # Using a value of 0, is disabling the speculative reads bookkeep

[GitHub] [pulsar] sijie commented on issue #7911: Unable to produce to specific topic in /public/default after upgrading to 2.6.1

2020-08-27 Thread GitBox
sijie commented on issue #7911: URL: https://github.com/apache/pulsar/issues/7911#issuecomment-682056696 @devinbost for such cases, a heap dump is appreciated to investigate the problem. Can you take a heap dump on the broker? --

[GitHub] [pulsar] sijie commented on a change in pull request #7843: Add More producer knobs

2020-08-27 Thread GitBox
sijie commented on a change in pull request #7843: URL: https://github.com/apache/pulsar/pull/7843#discussion_r478543501 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/ProducerConfig.java ## @@ -36,4 +36,8 @@ private Integer maxPendingMessage

[GitHub] [pulsar] fracasula commented on issue #7682: Stuck consumer: terminate called after throwing an instance of 'std::bad_alloc'

2020-08-27 Thread GitBox
fracasula commented on issue #7682: URL: https://github.com/apache/pulsar/issues/7682#issuecomment-682052891 Sorry, I was somehow dropping the `message` attribute from the logs coming from your Golang library (i.e. when converting them to the Stackdriver format). These should hopefully mak

[pulsar] branch master updated (0b7f034 -> 23dc5c7)

2020-08-27 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0b7f034 Split message ranges by ledger ID and store them in individualDeletedMessages (#7861) add 23dc5c7 [bro

[GitHub] [pulsar] sijie merged pull request #7841: [broker] Fix deadlock when adding consumer

2020-08-27 Thread GitBox
sijie merged pull request #7841: URL: https://github.com/apache/pulsar/pull/7841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie closed issue #7554: Messages that have already been acked are redelivered when upgrading Pulsar version

2020-08-27 Thread GitBox
sijie closed issue #7554: URL: https://github.com/apache/pulsar/issues/7554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[pulsar] branch master updated: Split message ranges by ledger ID and store them in individualDeletedMessages (#7861)

2020-08-27 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0b7f034 Split message ranges by ledger ID and st

[GitHub] [pulsar] sijie merged pull request #7861: [Issue 7554][broker] Split message ranges by ledger ID and store them in individualDeletedMessages

2020-08-27 Thread GitBox
sijie merged pull request #7861: URL: https://github.com/apache/pulsar/pull/7861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on pull request #7874: add java8 date and time type to pulsar's primitive schemas

2020-08-27 Thread GitBox
sijie commented on pull request #7874: URL: https://github.com/apache/pulsar/pull/7874#issuecomment-682051029 @codelipenghui can you review this again? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] fracasula commented on issue #7682: Stuck consumer: terminate called after throwing an instance of 'std::bad_alloc'

2020-08-27 Thread GitBox
fracasula commented on issue #7682: URL: https://github.com/apache/pulsar/issues/7682#issuecomment-681989390 We're getting also these from your Pulsar lib: ``` { msgID: { partition: -1 ledgerId: 389 entryId: 6196 } name: "cloud-pulsar-tester-se-c2-f5lgn" topic: "persistent://publ

[GitHub] [pulsar] jiazhai commented on pull request #7891: Allow ability to specify sub position in functions

2020-08-27 Thread GitBox
jiazhai commented on pull request #7891: URL: https://github.com/apache/pulsar/pull/7891#issuecomment-681958201 @wolfstudy Would you please help add a test for this? This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] gaoran10 commented on a change in pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
gaoran10 commented on a change in pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#discussion_r478382478 ## File path: .github/workflows/ci-unit-broker-broker-gp1.yaml ## @@ -65,13 +65,13 @@ jobs: if: steps.docs.outputs.changed_only == 'no'

[GitHub] [pulsar] gaoran10 commented on a change in pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
gaoran10 commented on a change in pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#discussion_r478382478 ## File path: .github/workflows/ci-unit-broker-broker-gp1.yaml ## @@ -65,13 +65,13 @@ jobs: if: steps.docs.outputs.changed_only == 'no'

[GitHub] [pulsar] aloyszhang removed a comment on pull request #7901: [Bookkeeper] make bookkeeper throttle Configurable

2020-08-27 Thread GitBox
aloyszhang removed a comment on pull request #7901: URL: https://github.com/apache/pulsar/pull/7901#issuecomment-680717518 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] jiazhai commented on pull request #7874: add java8 date and time type to pulsar's primitive schemas

2020-08-27 Thread GitBox
jiazhai commented on pull request #7874: URL: https://github.com/apache/pulsar/pull/7874#issuecomment-681912859 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] lhotari commented on issue #6603: Brokers fail when updating bookkeeper

2020-08-27 Thread GitBox
lhotari commented on issue #6603: URL: https://github.com/apache/pulsar/issues/6603#issuecomment-681903159 An additional change besides adjusting terminationGracePeriod in helm chart is required. I have created a PR https://github.com/apache/pulsar-helm-chart/pull/59 . That was inspired by

[GitHub] [pulsar] fracasula edited a comment on issue #7682: Stuck consumer: terminate called after throwing an instance of 'std::bad_alloc'

2020-08-27 Thread GitBox
fracasula edited a comment on issue #7682: URL: https://github.com/apache/pulsar/issues/7682#issuecomment-681831805 @codelipenghui @gaoran10 We created a clone of the whole production environment with the offloaded buckets too and, even with 2.6.1, we're perfectly able to replicate. In fac

[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable

2020-08-27 Thread GitBox
aloyszhang commented on pull request #7848: URL: https://github.com/apache/pulsar/pull/7848#issuecomment-681882284 @codelipenghui > the publish time and the seek time may be assigned by the different client, right? Yes, the publish time and the seek time can be assigned by differ

[GitHub] [pulsar] jianyun8023 commented on pull request #7874: add java8 date and time type to pulsar's primitive schemas

2020-08-27 Thread GitBox
jianyun8023 commented on pull request #7874: URL: https://github.com/apache/pulsar/pull/7874#issuecomment-681870434 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable

2020-08-27 Thread GitBox
codelipenghui commented on pull request #7848: URL: https://github.com/apache/pulsar/pull/7848#issuecomment-681847373 @aloyszhang > Thanks for your reply. I think use message id is a alternative way. But I don't think clock time is an issue, since both the publish time and seek t

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] fracasula commented on issue #7682: Stuck consumer: terminate called after throwing an instance of 'std::bad_alloc'

2020-08-27 Thread GitBox
fracasula commented on issue #7682: URL: https://github.com/apache/pulsar/issues/7682#issuecomment-681831805 @codelipenghui @gaoran10 We created a clone of whole production environment with the offloaded bucket too and even with 2.6.1 we're perfectly able to replicate, in fact the consumer

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail edited a comment on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail edited a comment on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same as [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-

[GitHub] [pulsar] hnail commented on issue #4747: [pulsar-sql] Support arrays and maps

2020-08-27 Thread GitBox
hnail commented on issue #4747: URL: https://github.com/apache/pulsar/issues/4747#issuecomment-681822007 The reason is same is [issues-7652](https://github.com/apache/pulsar/issues/7652) : 1. [PulsarMetadata.getColumns()](https://github.com/apache/pulsar/blob/master/pulsar-sql/pre

[GitHub] [pulsar] massakam commented on pull request #7841: [broker] Fix deadlock when adding consumer

2020-08-27 Thread GitBox
massakam commented on pull request #7841: URL: https://github.com/apache/pulsar/pull/7841#issuecomment-681816657 PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7833: [Transaction] Consume transaction message logic optimized

2020-08-27 Thread GitBox
codelipenghui commented on a change in pull request #7833: URL: https://github.com/apache/pulsar/pull/7833#discussion_r478232637 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -2857,5 +2857,14 @@ private int applyMaxS

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #7904: Add docs of package Pulsar Functions

2020-08-27 Thread GitBox
Jennifer88huang commented on a change in pull request #7904: URL: https://github.com/apache/pulsar/pull/7904#discussion_r478218036 ## File path: site2/docs/functions-package.md ## @@ -0,0 +1,524 @@ +--- +id: functions-package +title: Package Pulsar Functions +sidebar_label: "Ho

[GitHub] [pulsar] wolfstudy commented on pull request #7891: Allow ability to specify sub position in functions

2020-08-27 Thread GitBox
wolfstudy commented on pull request #7891: URL: https://github.com/apache/pulsar/pull/7891#issuecomment-681681395 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa