[GitHub] [pulsar] eolivelli commented on a change in pull request #8197: fix pulsar service close exception

2020-10-04 Thread GitBox
eolivelli commented on a change in pull request #8197: URL: https://github.com/apache/pulsar/pull/8197#discussion_r499218577 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -215,7 +215,9 @@ public void channelInactive(ChannelHand

[GitHub] [pulsar] eolivelli commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
eolivelli commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499220083 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookupT

[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates

2020-10-04 Thread GitBox
315157973 commented on pull request #8198: URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703223599 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on a change in pull request #8197: fix pulsar service close exception

2020-10-04 Thread GitBox
hangc0276 commented on a change in pull request #8197: URL: https://github.com/apache/pulsar/pull/8197#discussion_r499221710 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -215,7 +215,9 @@ public void channelInactive(ChannelHand

[GitHub] [pulsar] codelipenghui commented on pull request #8181: fix peek message not supported for partitioned topic with topicname

2020-10-04 Thread GitBox
codelipenghui commented on pull request #8181: URL: https://github.com/apache/pulsar/pull/8181#issuecomment-703225431 Close this PR first, @hangc0276 you can reopen it if needed. This is an automated message from the Apache G

[GitHub] [pulsar] codelipenghui closed pull request #8181: fix peek message not supported for partitioned topic with topicname

2020-10-04 Thread GitBox
codelipenghui closed pull request #8181: URL: https://github.com/apache/pulsar/pull/8181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] jiazhai commented on pull request #8198: Remove duplicate updates

2020-10-04 Thread GitBox
jiazhai commented on pull request #8198: URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703227178 @315157973 looks like this is not a dup. it tries to select between ns value and current passedin `Policies`. @gaoran10 Would you please help double check this change? -

[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates

2020-10-04 Thread GitBox
315157973 commented on pull request #8198: URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703227459 > @315157973 looks like this is not a dup. it tries to select between ns value and current passedin `Policies`. > @gaoran10 Would you please help double check this change?

[GitHub] [pulsar] codelipenghui merged pull request #8185: [python-client] expose batchingType interface

2020-10-04 Thread GitBox
codelipenghui merged pull request #8185: URL: https://github.com/apache/pulsar/pull/8185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[pulsar] branch master updated (d70d821 -> 321be27)

2020-10-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d70d821 fix examples/spark compile failed under jdk10 (#8194) add 321be27 [python-client] expose batchingType

[GitHub] [pulsar] codelipenghui closed issue #8135: [python-client] Support key based batching

2020-10-04 Thread GitBox
codelipenghui closed issue #8135: URL: https://github.com/apache/pulsar/issues/8135 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message

2020-10-04 Thread GitBox
codelipenghui commented on pull request #8173: URL: https://github.com/apache/pulsar/pull/8173#issuecomment-703228607 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] 315157973 commented on issue #5759: Inactive non-persistent subscriptions not purged

2020-10-04 Thread GitBox
315157973 commented on issue #5759: URL: https://github.com/apache/pulsar/issues/5759#issuecomment-703229179 I will work on it This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499232022 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499232154 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] aloyszhang commented on pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#issuecomment-703236615 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499232022 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] hangc0276 opened a new pull request #8199: change getBacklogQuota exception log level from error to warn

2020-10-04 Thread GitBox
hangc0276 opened a new pull request #8199: URL: https://github.com/apache/pulsar/pull/8199 ### Motivation In production env, we will monitor Pulsar broker log level and alert when encountered error log. However, when getBacklogQuota failed from topic policy or namespace policy, it will

[GitHub] [pulsar] rudy2steiner commented on pull request #8048: [Issue 7903][proxy]Enable AutoTopicCreationType partitioned through proxy

2020-10-04 Thread GitBox
rudy2steiner commented on pull request #8048: URL: https://github.com/apache/pulsar/pull/8048#issuecomment-703241347 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] eolivelli commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
eolivelli commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499236382 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookupT

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499239138 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates

2020-10-04 Thread GitBox
315157973 commented on pull request #8198: URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703246102 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #8122: add python schema field default value

2020-10-04 Thread GitBox
hangc0276 commented on pull request #8122: URL: https://github.com/apache/pulsar/pull/8122#issuecomment-703248387 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #8197: fix pulsar service close exception

2020-10-04 Thread GitBox
hangc0276 commented on pull request #8197: URL: https://github.com/apache/pulsar/pull/8197#issuecomment-703248345 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] tuteng opened a new pull request #8200: Fixed latest doc version sidebar

2020-10-04 Thread GitBox
tuteng opened a new pull request #8200: URL: https://github.com/apache/pulsar/pull/8200 Fixes #8016 *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)* Master Issue: #8016 ### Motivation * Fixed

[GitHub] [pulsar] hangc0276 opened a new pull request #8201: check null to avoid NPE for internalSetTopicPolicies

2020-10-04 Thread GitBox
hangc0276 opened a new pull request #8201: URL: https://github.com/apache/pulsar/pull/8201 ### Motivation & Changes 1. add null check for topic policies to avoid NPE 2. add boundary check for `MaxUnackedMessagesOnSubscription` and `SetMaxUnackedMessagesOnConsumer` --

[GitHub] [pulsar] codelipenghui commented on pull request #8195: Add log level configuration in pulsar-client

2020-10-04 Thread GitBox
codelipenghui commented on pull request #8195: URL: https://github.com/apache/pulsar/pull/8195#issuecomment-703252317 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] eolivelli commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
eolivelli commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499247953 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookupT

[GitHub] [pulsar] aloyszhang commented on pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#issuecomment-703346317 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499309485 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] hangc0276 commented on issue #8171: AutoRecovery should respect to the ensemble policy used in Pulsar

2020-10-04 Thread GitBox
hangc0276 commented on issue #8171: URL: https://github.com/apache/pulsar/issues/8171#issuecomment-703347006 I checked bookkeeper autoRecovery logic, it respected to the ensemble policy store in ledgerMetadata for each ledger fragment. The code as follow. `BookKeeperAdmin#getReplacementBoo

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499309485 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] aloyszhang commented on a change in pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang commented on a change in pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#discussion_r499309485 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java ## @@ -41,6 +42,14 @@ */ CompletableFuture lookup

[GitHub] [pulsar] ndr-thitinan opened a new issue #8202: The pulsar crashes after a few mins

2020-10-04 Thread GitBox
ndr-thitinan opened a new issue #8202: URL: https://github.com/apache/pulsar/issues/8202 **Describe the bug** After I execute the pulsar using docker for a few mins, it crashed. **To Reproduce** Steps to reproduce the behavior: 1. Run the following command (no addition config

[GitHub] [pulsar] hangc0276 commented on issue #8183: JMX scrape failed after upgrading broker to 2.6.1

2020-10-04 Thread GitBox
hangc0276 commented on issue #8183: URL: https://github.com/apache/pulsar/issues/8183#issuecomment-703358461 This may be caused by pulsar-function JMX metric exporter, would you please paste more detail logs? This is an auto

[GitHub] [pulsar] hangc0276 commented on pull request #8201: check null to avoid NPE for internalSetTopicPolicies

2020-10-04 Thread GitBox
hangc0276 commented on pull request #8201: URL: https://github.com/apache/pulsar/pull/8201#issuecomment-703365379 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #8122: add python schema field default value

2020-10-04 Thread GitBox
hangc0276 commented on pull request #8122: URL: https://github.com/apache/pulsar/pull/8122#issuecomment-703365508 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #8199: change getBacklogQuota exception log level from error to warn

2020-10-04 Thread GitBox
hangc0276 commented on pull request #8199: URL: https://github.com/apache/pulsar/pull/8199#issuecomment-703365436 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] tuteng merged pull request #8200: Fixed latest doc version sidebar

2020-10-04 Thread GitBox
tuteng merged pull request #8200: URL: https://github.com/apache/pulsar/pull/8200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] tuteng closed issue #8016: [website] The master doc page is displayed without navigation

2020-10-04 Thread GitBox
tuteng closed issue #8016: URL: https://github.com/apache/pulsar/issues/8016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[pulsar] branch master updated: Fixed latest doc version sidebar (#8200)

2020-10-04 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5528113 Fixed latest doc version sidebar (#8

[GitHub] [pulsar] abhishekheaven7 opened a new issue #8203: Pulsar client with version 2.6.1 has critical vulnerability CVE-2019-17638

2020-10-04 Thread GitBox
abhishekheaven7 opened a new issue #8203: URL: https://github.com/apache/pulsar/issues/8203 Pulsar client has jetty dependency [pulsar-client-2.6.1.jar (shaded: org.eclipse.jetty:jetty-util:9.4.29.v20200521) ] which has critical security vulnerability. CWE-672 CWE-672 Operation on a Res

[GitHub] [pulsar] abhishekheaven7 closed issue #8203: Pulsar client with version 2.6.1 has critical vulnerability CVE-2019-17638

2020-10-04 Thread GitBox
abhishekheaven7 closed issue #8203: URL: https://github.com/apache/pulsar/issues/8203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable

2020-10-04 Thread GitBox
aloyszhang removed a comment on pull request #7848: URL: https://github.com/apache/pulsar/pull/7848#issuecomment-692491022 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] aloyszhang removed a comment on pull request #7605: Support partitioned topic lookup

2020-10-04 Thread GitBox
aloyszhang removed a comment on pull request #7605: URL: https://github.com/apache/pulsar/pull/7605#issuecomment-703236615 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to