[GitHub] [pulsar] eolivelli commented on a change in pull request #8938: [Tiered Storage] Exclude current ledger from offload deque

2020-12-13 Thread GitBox
eolivelli commented on a change in pull request #8938: URL: https://github.com/apache/pulsar/pull/8938#discussion_r542170088 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1411,9 +1411,21 @@ synchronized void ledgerC

[GitHub] [pulsar] zymap commented on pull request #8907: [Issue #8874]Fix the package upload failed issue

2020-12-13 Thread GitBox
zymap commented on pull request #8907: URL: https://github.com/apache/pulsar/pull/8907#issuecomment-744219919 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari edited a comment on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari edited a comment on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744183206 > what about log4j2.garbagefreeThreadContextMap ? probably it is not worth, and we should perform benchmarks @eolivelli Good point. That would also be required for c

[GitHub] [pulsar] lhotari commented on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari commented on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744183206 > what about log4j2.garbagefreeThreadContextMap ? probably it is not worth, and we should perform benchmarks @eolivelli Good point. That would also be required for [configu

[pulsar] branch master updated: Fix NSQ source META-INF file name and sourceConfigClass (#8941)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4df7bb0 Fix NSQ source META-INF file name and so

[GitHub] [pulsar] sijie merged pull request #8941: Fix NSQ source META-INF file name and sourceConfigClass

2020-12-13 Thread GitBox
sijie merged pull request #8941: URL: https://github.com/apache/pulsar/pull/8941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie closed issue #8940: NSQ Connector fails to appear.

2020-12-13 Thread GitBox
sijie closed issue #8940: URL: https://github.com/apache/pulsar/issues/8940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] sijie commented on pull request #8796: [Issue 8751] Update Dockerfile for Pulsar and Dashboard to Create and Use pulsar User (nonroot user)

2020-12-13 Thread GitBox
sijie commented on pull request #8796: URL: https://github.com/apache/pulsar/pull/8796#issuecomment-744173864 @michaeljmarshall It seems that all integration tests failed. It seems that it is related to this change. I am trying it locally. -

[pulsar] branch master updated (1654e88 -> ff3dbce)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1654e88 Expose non-contiguous deleted messages ranges stats. (#8936) add ff3dbce [ISSUE 8872][docs] fix the jso

[GitHub] [pulsar] sijie merged pull request #8920: [ISSUE 8872][docs] fix the json format of BrokerClientAuthParam

2020-12-13 Thread GitBox
sijie merged pull request #8920: URL: https://github.com/apache/pulsar/pull/8920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on pull request #8942: support limit max topics per namespace

2020-12-13 Thread GitBox
sijie commented on pull request #8942: URL: https://github.com/apache/pulsar/pull/8942#issuecomment-744164505 @aahmed-se : > The limit should be per namespace. We usually add a default setting to broker/cluster-level first. Then add the setting to the namespace policy. We shou

[GitHub] [pulsar] sijie merged pull request #8936: Expose non-contiguous deleted messages ranges stats.

2020-12-13 Thread GitBox
sijie merged pull request #8936: URL: https://github.com/apache/pulsar/pull/8936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch master updated (26749a8 -> 1654e88)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 26749a8 [Functions] Provide an interface for functions worker service (#8560) add 1654e88 Expose non-contiguou

[GitHub] [pulsar] wolfstudy commented on issue #8582: Pulsar sink creation --topics-pattern argument not working as expected in Docker with pulsar-all image & cassandra sink

2020-12-13 Thread GitBox
wolfstudy commented on issue #8582: URL: https://github.com/apache/pulsar/issues/8582#issuecomment-744159728 @EliHarper Any update for this issue? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] codelipenghui opened a new pull request #8947: Fix subscription dispatch rate does not work after the topic unload without dispatch rate limit.

2020-12-13 Thread GitBox
codelipenghui opened a new pull request #8947: URL: https://github.com/apache/pulsar/pull/8947 ### Motivation Fix subscription dispatch rate does not work after the topic unload without dispatch rate limit. Currently, if the subscription dispatch rate is present then update the ra

[GitHub] [pulsar] sijie merged pull request #8560: [Functions] Provide an interface for functions worker service

2020-12-13 Thread GitBox
sijie merged pull request #8560: URL: https://github.com/apache/pulsar/pull/8560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch master updated: [ISSUE 8832] Avro custom schema not working in consumer (#8939)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3da2365 [ISSUE 8832] Avro custom schema not work

[GitHub] [pulsar] sijie merged pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
sijie merged pull request #8939: URL: https://github.com/apache/pulsar/pull/8939 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie closed issue #8832: consumer do not use custom SchemaReader when provided (2.7)

2020-12-13 Thread GitBox
sijie closed issue #8832: URL: https://github.com/apache/pulsar/issues/8832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] sijie commented on pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

2020-12-13 Thread GitBox
sijie commented on pull request #8945: URL: https://github.com/apache/pulsar/pull/8945#issuecomment-744155419 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lxcid commented on issue #8502: Upgrade Debezium to a newer version

2020-12-13 Thread GitBox
lxcid commented on issue #8502: URL: https://github.com/apache/pulsar/issues/8502#issuecomment-744148721 No problem! Hope to check back on this issue, any chance of dropping in next release? This is an automated message from

[GitHub] [pulsar] wuzhanpeng commented on a change in pull request #8946: make ledger rollover check task internal

2020-12-13 Thread GitBox
wuzhanpeng commented on a change in pull request #8946: URL: https://github.com/apache/pulsar/pull/8946#discussion_r542085494 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3300,6 +3305,13 @@ private void scheduleTim

[GitHub] [pulsar-client-go] hrsakai edited a comment on issue #389: Weird behaviour when connection is closed and Consumer.Ack() is called (unhandled connection closed error)

2020-12-13 Thread GitBox
hrsakai edited a comment on issue #389: URL: https://github.com/apache/pulsar-client-go/issues/389#issuecomment-744091316 @milos-matijasevic Yes, I reproduced scenario 1. My PR is just to fix following the issue in the scenario 2. > all messages before are acked even if every

[GitHub] [pulsar] hangc0276 commented on pull request #8946: make ledger rollover check task internal

2020-12-13 Thread GitBox
hangc0276 commented on pull request #8946: URL: https://github.com/apache/pulsar/pull/8946#issuecomment-744111964 @wuzhanpeng Please help take a look, thanks. This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] Jennifer88huang merged pull request #8937: [ISSUE 8909]Fix Giggso logo link error

2020-12-13 Thread GitBox
Jennifer88huang merged pull request #8937: URL: https://github.com/apache/pulsar/pull/8937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Jennifer88huang closed issue #8909: Giggso logo link error

2020-12-13 Thread GitBox
Jennifer88huang closed issue #8909: URL: https://github.com/apache/pulsar/issues/8909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[pulsar] branch master updated: [ISSUE 8909]Fix Giggso logo link error (#8937)

2020-12-13 Thread hjf
This is an automated email from the ASF dual-hosted git repository. hjf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a9e1ac3 [ISSUE 8909]Fix Giggso logo link error (#8

[GitHub] [pulsar] Jennifer88huang commented on pull request #8937: [ISSUE 8909]Fix Giggso logo link error

2020-12-13 Thread GitBox
Jennifer88huang commented on pull request #8937: URL: https://github.com/apache/pulsar/pull/8937#issuecomment-744109957 @reswqa that's ok. I mean if you're looking for kubernetes-helm.md, there is no such md file. `kubernetes-helm` is the id of the getting-started-helm.md file. -

[GitHub] [pulsar] hangc0276 opened a new pull request #8946: make ledger rollover check task internal

2020-12-13 Thread GitBox
hangc0276 opened a new pull request #8946: URL: https://github.com/apache/pulsar/pull/8946 Fix #7195 ### Changes 1. add a schedulerTask to rollover the ledger in `ManagedLedgerImpl` instead of `BrokerService` 2. add the test. -

[GitHub] [pulsar] Jennifer88huang commented on pull request #8912: [docs] Fix typo in broker.conf and standalone.conf

2020-12-13 Thread GitBox
Jennifer88huang commented on pull request #8912: URL: https://github.com/apache/pulsar/pull/8912#issuecomment-744108470 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] hangc0276 removed a comment on pull request #8942: support limit max topics per namespace

2020-12-13 Thread GitBox
hangc0276 removed a comment on pull request #8942: URL: https://github.com/apache/pulsar/pull/8942#issuecomment-744103581 > The limit should be per namespace. @aahmed-se Yes, the limit is per namespace. This is an auto

[GitHub] [pulsar] hangc0276 commented on pull request #8942: support limit max topics per namespace

2020-12-13 Thread GitBox
hangc0276 commented on pull request #8942: URL: https://github.com/apache/pulsar/pull/8942#issuecomment-744103581 > The limit should be per namespace. @aahmed-se Yes, the limit is per namespace. This is an automated me

[GitHub] [pulsar] codelipenghui commented on pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
codelipenghui commented on pull request #8939: URL: https://github.com/apache/pulsar/pull/8939#issuecomment-744094433 @congbobo184 Could you please help take a loot at this PR? This is an automated message from the Apache Git

[GitHub] [pulsar-client-go] hrsakai commented on issue #389: Weird behaviour when connection is closed and Consumer.Ack() is called (unhandled connection closed error)

2020-12-13 Thread GitBox
hrsakai commented on issue #389: URL: https://github.com/apache/pulsar-client-go/issues/389#issuecomment-744091316 @milos-matijasevic Yes, I reproduced scenario 1. My PR is just to avoid following the issue in the scenario 2. > all messages before are acked even if every 2nd i

[GitHub] [pulsar] eolivelli commented on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
eolivelli commented on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744071511 what about log4j2.garbagefreeThreadContextMap ? probably it is not worth, and we should perform benchmarks Thi

[GitHub] [pulsar] lhotari removed a comment on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari removed a comment on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744063839 /pulsarbot rerun-failure-checks This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] lhotari commented on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari commented on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744063839 /pulsarbot rerun-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] MarvinCai commented on pull request #8401: [Websocket]Update produce request and acknowledge for WebSocket.

2020-12-13 Thread GitBox
MarvinCai commented on pull request #8401: URL: https://github.com/apache/pulsar/pull/8401#issuecomment-744058367 @tarpdalton here's the pr to support deliverAt and deliverAfter in ms for Websocket producer:https://github.com/apache/pulsar/pull/8945 ---

[GitHub] [pulsar] MarvinCai opened a new pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

2020-12-13 Thread GitBox
MarvinCai opened a new pull request #8945: URL: https://github.com/apache/pulsar/pull/8945 ### Motivation Support deliverAt and deliverAfter attribute for Websocket producer ### Modifications Apply deliverAt and deliverAfter to message builder for Websocket messa

[GitHub] [pulsar] aahmed-se commented on pull request #8942: support limit max topics per namespace

2020-12-13 Thread GitBox
aahmed-se commented on pull request #8942: URL: https://github.com/apache/pulsar/pull/8942#issuecomment-744056976 The limit should be per namespace. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] moutasemalakkad commented on issue #8833: Failed to start Pulsar in stand alone mode

2020-12-13 Thread GitBox
moutasemalakkad commented on issue #8833: URL: https://github.com/apache/pulsar/issues/8833#issuecomment-744056734 It worked fine when I downloaded Pulsar from Apache. This is an automated message from the Apache Git Service.

[GitHub] [pulsar] moutasemalakkad closed issue #8833: Failed to start Pulsar in stand alone mode

2020-12-13 Thread GitBox
moutasemalakkad closed issue #8833: URL: https://github.com/apache/pulsar/issues/8833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] lhotari edited a comment on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari edited a comment on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744050750 > Can you explain more why are you saying that we do not use Java Web Servet technologies? I didn't mean that. I reworded the sentence, it's now "Since Pulsar isn't

[GitHub] [pulsar] lhotari commented on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari commented on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744050750 > Can you explain more why are you saying that we do not use Java Web Servet technologies? I didn't mean that. I reworded the sentence, it's now "Since Pulsar isn't a J2EE

[GitHub] [pulsar] lhotari commented on issue #8875: garbage collection occured too often

2020-12-13 Thread GitBox
lhotari commented on issue #8875: URL: https://github.com/apache/pulsar/issues/8875#issuecomment-744050285 There's also a PR to enable Log4j2's Garbage Free logging mode, it's #8944 . Applying both #8908 and #8944 should reduce GC pressure. Since both PRs are simply changes to the b

[GitHub] [pulsar] sijia-w edited a comment on issue #8477: [docs] Duplicate info of using C++ in Pulsar

2020-12-13 Thread GitBox
sijia-w edited a comment on issue #8477: URL: https://github.com/apache/pulsar/issues/8477#issuecomment-743159417 #8919 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] sijie commented on pull request #8936: Expose non-contiguous deleted messages ranges stats.

2020-12-13 Thread GitBox
sijie commented on pull request #8936: URL: https://github.com/apache/pulsar/pull/8936#issuecomment-74404 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on pull request #8941: Fix NSQ source META-INF file name and sourceConfigClass

2020-12-13 Thread GitBox
sijie commented on pull request #8941: URL: https://github.com/apache/pulsar/pull/8941#issuecomment-744045444 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[pulsar] branch master updated: [build] Use absolute path to locate license and checkstyle plugin config (#8918)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ab35e2d [build] Use absolute path to locate lice

[GitHub] [pulsar] sijie merged pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

2020-12-13 Thread GitBox
sijie merged pull request #8918: URL: https://github.com/apache/pulsar/pull/8918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari opened a new pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
lhotari opened a new pull request #8944: URL: https://github.com/apache/pulsar/pull/8944 ### Motivation Log4j2 has a Garbage Free logging mode which reduces GC pressure since the garbage created by logging is very low ("garbage free"). This mode is the default of Log4j2 unless there

[pulsar] branch master updated: Disable maven's http connection pooling to mitigate "connection reset" issues (#8921)

2020-12-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9405e6b Disable maven's http connection pooling

[GitHub] [pulsar] sijie merged pull request #8921: Disable maven's http connection pooling to mitigate "connection reset…

2020-12-13 Thread GitBox
sijie merged pull request #8921: URL: https://github.com/apache/pulsar/pull/8921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] eolivelli commented on pull request #8944: [logging] Enable Log4j2 Garbage Free Logging to reduce GC pressure

2020-12-13 Thread GitBox
eolivelli commented on pull request #8944: URL: https://github.com/apache/pulsar/pull/8944#issuecomment-744043877 Pulsar relays heavily on JAX-RS that is a server based technology. Can you explain more why are you saying that we do not use Java Web Servet technologies? I am not ag

[GitHub] [pulsar] lhotari commented on pull request #8908: Fix performance issue caused by invalid logging configuration

2020-12-13 Thread GitBox
lhotari commented on pull request #8908: URL: https://github.com/apache/pulsar/pull/8908#issuecomment-744043773 Related to log4j2 configuration and performance optimizations, there's a separate pull request to enable Log4j2's Garbage Free logging mode: #8944 . The Garbage Free logging mode

[GitHub] [pulsar] fshafiee opened a new issue #8943: Specifying delivery delays per subscription

2020-12-13 Thread GitBox
fshafiee opened a new issue #8943: URL: https://github.com/apache/pulsar/issues/8943 **Is your enhancement request related to a problem? Please describe.** Unable to setup delayed deliveries per subscription. In other words, the current way of delaying messages does not conform to [follo

[GitHub] [pulsar-client-go] milos-matijasevic commented on issue #389: Weird behaviour when connection is closed and Consumer.Ack() is called (unhandled connection closed error)

2020-12-13 Thread GitBox
milos-matijasevic commented on issue #389: URL: https://github.com/apache/pulsar-client-go/issues/389#issuecomment-743996526 Thanks @hrsakai for working on this! Did you try to reproduce scenario 1, if a connection to a broker is closed, a consumer will continue to read messages fro

[GitHub] [pulsar] reswqa commented on pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
reswqa commented on pull request #8939: URL: https://github.com/apache/pulsar/pull/8939#issuecomment-743992913 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] reswqa commented on a change in pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
reswqa commented on a change in pull request #8939: URL: https://github.com/apache/pulsar/pull/8939#discussion_r541881136 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/BrokerClientIntegrationTest.java ## @@ -858,8 +861,40 @@ public void asyncClose(or

[GitHub] [pulsar] reswqa commented on pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
reswqa commented on pull request #8939: URL: https://github.com/apache/pulsar/pull/8939#issuecomment-743974928 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] eolivelli commented on a change in pull request #8939: [ISSUE 8832] Avro custom schema not working in consumer

2020-12-13 Thread GitBox
eolivelli commented on a change in pull request #8939: URL: https://github.com/apache/pulsar/pull/8939#discussion_r541878983 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/BrokerClientIntegrationTest.java ## @@ -858,8 +861,40 @@ public void asyncClose

[GitHub] [pulsar] jiazhai commented on pull request #8930: Monitor if a cursor moves its mark-delete position

2020-12-13 Thread GitBox
jiazhai commented on pull request #8930: URL: https://github.com/apache/pulsar/pull/8930#issuecomment-743971911 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message