[GitHub] [pulsar] limingnihao opened a new pull request #9797: [Issue 9602] add scheme type validation

2021-03-03 Thread GitBox
limingnihao opened a new pull request #9797: URL: https://github.com/apache/pulsar/pull/9797 Fixes #9602 ### Motivation The schema should not be able to modify the type after it is first created. Unless he is Always compatible. ### Modifications When uploading a

[GitHub] [pulsar] codelipenghui commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-03 Thread GitBox
codelipenghui commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-790387105 /cc @BewareMyPower Please help take a look at this issue. This is an automated message from the Apache Git Servi

[GitHub] [pulsar] yitian108 opened a new issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-03 Thread GitBox
yitian108 opened a new issue #9796: URL: https://github.com/apache/pulsar/issues/9796 Expected behavior When I try to use c++ to test the pulsar program with asyn producer, I expect the program could run well like sync mode Tell us what should happen However, I encounter the s

[GitHub] [pulsar] 315157973 commented on pull request #9290: Support get topic applied policy for MaxUnackedMessagesPerSubscription

2021-03-03 Thread GitBox
315157973 commented on pull request #9290: URL: https://github.com/apache/pulsar/pull/9290#issuecomment-790383799 > Sorry for the late response @315157973 Could you please help resolve the conflicts? I think after this PR merged, all the applied policy is done right? Please help update the

[GitHub] [pulsar] codelipenghui commented on pull request #9290: Support get topic applied policy for MaxUnackedMessagesPerSubscription

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9290: URL: https://github.com/apache/pulsar/pull/9290#issuecomment-790382708 Sorry for the late response @315157973 Could you please help resolve the conflicts? I think after this PR merged, all the applied policy is done right? Please help update t

[GitHub] [pulsar] codelipenghui commented on issue #9792: Producer cannot connect after broker load shedding

2021-03-03 Thread GitBox
codelipenghui commented on issue #9792: URL: https://github.com/apache/pulsar/issues/9792#issuecomment-790381412 I think this issue is not easy to reproduce, it needs to simulate the producer creation with a timeout exception. We have fixed the related problem by introducing the epoch http

[GitHub] [pulsar] codelipenghui commented on pull request #9794: [ISSUE 9757][pulsar-admin] add cmd to get service url of the leader broker

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9794: URL: https://github.com/apache/pulsar/pull/9794#issuecomment-790378754 @linlinnn I noticed you have closed this PR, do you want to open a new PR to handle it? This is an automat

[GitHub] [pulsar] codelipenghui commented on issue #9793: the class loader in pulsar function recognizes jar file as an nar file?

2021-03-03 Thread GitBox
codelipenghui commented on issue #9793: URL: https://github.com/apache/pulsar/issues/9793#issuecomment-790377253 @nlu90 @freeznet Could you please help take a look at this issue? This is an automated message from the Apache G

[GitHub] [pulsar] eolivelli commented on a change in pull request #9779: [Doc] Add descriptions for bookieID

2021-03-03 Thread GitBox
eolivelli commented on a change in pull request #9779: URL: https://github.com/apache/pulsar/pull/9779#discussion_r587200227 ## File path: site2/docs/reference-configuration.md ## @@ -129,7 +129,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable st

[GitHub] [pulsar] limingnihao commented on issue #9602: Could not add AVRO schema using producer client

2021-03-03 Thread GitBox
limingnihao commented on issue #9602: URL: https://github.com/apache/pulsar/issues/9602#issuecomment-790369407 I will fix this issue, please assign it to me. A check for Scheme Type will be added. This is an automated messag

[GitHub] [pulsar] eolivelli commented on pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
eolivelli commented on pull request #9787: URL: https://github.com/apache/pulsar/pull/9787#issuecomment-790346874 Sorry. I came too late to the party. Btw I believe this approach is good +1 This is an automated mess

[GitHub] [pulsar] linlinnn closed pull request #9794: [ISSUE 9757][pulsar-admin] add cmd to get service url of the leader broker

2021-03-03 Thread GitBox
linlinnn closed pull request #9794: URL: https://github.com/apache/pulsar/pull/9794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] eolivelli commented on pull request #9614: Schema API: expose underlying Schema information for Fields

2021-03-03 Thread GitBox
eolivelli commented on pull request #9614: URL: https://github.com/apache/pulsar/pull/9614#issuecomment-790322160 Good idea. I will update the patch soon This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] Anonymitaet commented on pull request #9795: [Doc] Add descriptions for set-offload-policies

2021-03-03 Thread GitBox
Anonymitaet commented on pull request #9795: URL: https://github.com/apache/pulsar/pull/9795#issuecomment-790320201 @Renkai could you please help review? Thanks This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] Anonymitaet commented on pull request #8717: Configurable data source for offloaded messages

2021-03-03 Thread GitBox
Anonymitaet commented on pull request #8717: URL: https://github.com/apache/pulsar/pull/8717#issuecomment-790320099 @Renkai I've submitted https://github.com/apache/pulsar/pull/9795 to add docs, could you please help review? Thanks -

[GitHub] [pulsar] Anonymitaet opened a new pull request #9795: [Doc] Add descriptions for set-offload-policies

2021-03-03 Thread GitBox
Anonymitaet opened a new pull request #9795: URL: https://github.com/apache/pulsar/pull/9795 Fix https://github.com/apache/pulsar/pull/8717 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] linlinnn commented on issue #9792: Producer cannot connect after broker load shedding

2021-03-03 Thread GitBox
linlinnn commented on issue #9792: URL: https://github.com/apache/pulsar/issues/9792#issuecomment-790308819 @xche hi, can you reproduce this problem and provide detail error trace? This is an automated message from the Apache

[pulsar] branch master updated (795e889 -> c86f2f7)

2021-03-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 795e889 [Doc] Add doc on how to configure max subscriptions per topic at the namespace level (#9747) add c86f2

[GitHub] [pulsar] merlimat merged pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
merlimat merged pull request #9787: URL: https://github.com/apache/pulsar/pull/9787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] linlinnn opened a new pull request #9794: [ISSUE 9757][pulsar-admin] add cmd to get service url of the leader broker

2021-03-03 Thread GitBox
linlinnn opened a new pull request #9794: URL: https://github.com/apache/pulsar/pull/9794 ### Motivation see #9757 add cmd to get service url of the leader broker. ### Modifications add cmd parameter "leader-broker" in CmdBrokers, and provide "/admin/v2/brokers/leaderBroker" we

[GitHub] [pulsar] pointearth opened a new issue #9793: the class loader in pulsar function recognizes jar file as an nar file?

2021-03-03 Thread GitBox
pointearth opened a new issue #9793: URL: https://github.com/apache/pulsar/issues/9793 **Describe the bug** I met an exception when I run a pulsar function, it seems that the class loader in pulsar recognizes it as a nar file, but I don't use any nar. **To Reproduce** S

[GitHub] [pulsar] xiaotongwang1 commented on issue #8670: Security issues:pulsar create zookeeper path、data without ACL

2021-03-03 Thread GitBox
xiaotongwang1 commented on issue #8670: URL: https://github.com/apache/pulsar/issues/8670#issuecomment-790276682 @eolivelli @jiazhai @codelipenghui we had modify the source code base on 2.7.0 and it test and work fine in our system ,can i commit a pr to fix this problem with adding a judgm

[GitHub] [pulsar] xche opened a new issue #9792: Producer cannot connect after broker load shedding

2021-03-03 Thread GitBox
xche opened a new issue #9792: URL: https://github.com/apache/pulsar/issues/9792 **Describe the bug** pulsar:2.6.1 When the broker does loadshedding, producer can see the following log: Failed to create producer: Namespace is being unloaded, cannot add topic Failed to

[GitHub] [pulsar] Crtrpt edited a comment on issue #9791: How to fetch all function state?

2021-03-03 Thread GitBox
Crtrpt edited a comment on issue #9791: URL: https://github.com/apache/pulsar/issues/9791#issuecomment-790256390 > @Crtrpt You can use `bin/pulsar-admin functions querystate` to fetch the current state associated with a Pulsar Function. But only one And must provide a name

[GitHub] [pulsar] Crtrpt commented on issue #9791: How to fetch all function state?

2021-03-03 Thread GitBox
Crtrpt commented on issue #9791: URL: https://github.com/apache/pulsar/issues/9791#issuecomment-790256390 > @Crtrpt You can use `bin/pulsar-admin functions querystate` to fetch the current state associated with a Pulsar Function. But only one ---

[GitHub] [pulsar] codelipenghui commented on issue #9791: How to fetch all function state?

2021-03-03 Thread GitBox
codelipenghui commented on issue #9791: URL: https://github.com/apache/pulsar/issues/9791#issuecomment-790255657 @Crtrpt You can use `bin/pulsar-admin functions querystate` to fetch the current state associated with a Pulsar Function. -

[GitHub] [pulsar] Crtrpt opened a new issue #9791: How to fetch all function state?

2021-03-03 Thread GitBox
Crtrpt opened a new issue #9791: URL: https://github.com/apache/pulsar/issues/9791 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] **Describe the solution you'd like**

[GitHub] [pulsar] sijie commented on pull request #9614: Schema API: expose underlying Schema information for Fields

2021-03-03 Thread GitBox
sijie commented on pull request #9614: URL: https://github.com/apache/pulsar/pull/9614#issuecomment-790223831 I think what @codelipenghui suggested can be a good solution. This is an automated message from the Apache Git Ser

[GitHub] [pulsar] codelipenghui opened a new issue #9790: Support disabled the tenants/namespaces force deletion in the broker.conf

2021-03-03 Thread GitBox
codelipenghui opened a new issue #9790: URL: https://github.com/apache/pulsar/issues/9790 **Is your feature request related to a problem? Please describe.** Currently, we added the tenants and namespaces force deletion feature in the broker, which allows users to force delete the topics

[GitHub] [pulsar] codelipenghui commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-790219368 @murong00 Ok, I will create an issue first This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] gaoran10 commented on a change in pull request #9628: [Pulsar SQL] Add max split entry queue size bytes limitation

2021-03-03 Thread GitBox
gaoran10 commented on a change in pull request #9628: URL: https://github.com/apache/pulsar/pull/9628#discussion_r586937758 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java ## @@ -347,8 +355,16 @@ public void run() {

[GitHub] [pulsar] murong00 commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-03-03 Thread GitBox
murong00 commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-790205447 > @murong00 Then change looks good to me, shall we need to control the force delete tenants or namespaces in the broker.conf? such as forceDeleteNamepaceAllowed, forceDeleteTena

[GitHub] [pulsar] rdhabalia opened a new pull request #9789: [pulsar-broker] Allow broker to discover and unblock stuck subscription

2021-03-03 Thread GitBox
rdhabalia opened a new pull request #9789: URL: https://github.com/apache/pulsar/pull/9789 ### Motivation We have been frequently seeing issue where subscription gets stuck on different topics and broker is not dispatching messages though consumer has available-permits and no pending re

[GitHub] [pulsar] gaoran10 commented on a change in pull request #9628: [Pulsar SQL] Add max split entry queue size bytes limitation

2021-03-03 Thread GitBox
gaoran10 commented on a change in pull request #9628: URL: https://github.com/apache/pulsar/pull/9628#discussion_r586934418 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java ## @@ -222,7 +228,7 @@ public void setPulsarSq

[GitHub] [pulsar] BewareMyPower commented on pull request #9782: Add NPE check for PulsarService#getAdminClient

2021-03-03 Thread GitBox
BewareMyPower commented on pull request #9782: URL: https://github.com/apache/pulsar/pull/9782#issuecomment-790204515 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] Anonymitaet commented on pull request #9779: [Doc] Add descriptions for bookieID

2021-03-03 Thread GitBox
Anonymitaet commented on pull request #9779: URL: https://github.com/apache/pulsar/pull/9779#issuecomment-790200327 @eolivelli could you please help review? Thanks This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] dsm1212 commented on issue #9703: non-persistent topics don't seem to work with Key_Shared

2021-03-03 Thread GitBox
dsm1212 commented on issue #9703: URL: https://github.com/apache/pulsar/issues/9703#issuecomment-790198993 This pretty seriously impacts using non-persistent. Do you have any idea how long it might take for a fix? Or if you pin it down maybe you will see a work-around to share. thx -

[pulsar] branch master updated (a5e795c -> 795e889)

2021-03-03 Thread hjf
This is an automated email from the ASF dual-hosted git repository. hjf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a5e795c [pulsar-broker] Added support to force deleting tenant (#9677) add 795e889 [Doc] Add doc on how to config

[GitHub] [pulsar] Jennifer88huang merged pull request #9747: [Doc] Add doc on how to configure max subscriptions per topic at the namespace level

2021-03-03 Thread GitBox
Jennifer88huang merged pull request #9747: URL: https://github.com/apache/pulsar/pull/9747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] codelipenghui commented on pull request #9614: Schema API: expose underlying Schema information for Fields

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9614: URL: https://github.com/apache/pulsar/pull/9614#issuecomment-790197364 @eolivelli @sijie Is it better to add method `getNativeRecord` or `getOriginalRecord` in the `GenericRecord` interface? --

[GitHub] [pulsar] rdhabalia opened a new pull request #9788: [pulsar-broker] add pending read subscription metrics to stats-internal

2021-03-03 Thread GitBox
rdhabalia opened a new pull request #9788: URL: https://github.com/apache/pulsar/pull/9788 ### Motivation We frequently see consumer gets stuck and broker is not dispatching messages though it should. We need additional pending-read metrics of the topic for better debugging. eg: whe

[GitHub] [pulsar] Jennifer88huang commented on pull request #9747: [Doc] Add doc on how to configure max subscriptions per topic at the namespace level

2021-03-03 Thread GitBox
Jennifer88huang commented on pull request #9747: URL: https://github.com/apache/pulsar/pull/9747#issuecomment-790191083 @Anonymitaet PTAL, thank you. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] codelipenghui commented on pull request #9628: [Pulsar SQL] Add max split entry queue size bytes limitation

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9628: URL: https://github.com/apache/pulsar/pull/9628#issuecomment-790189661 @gaoran10 Could you please check sijie's comments? This is an automated message from the Apache Git Service

[pulsar] branch master updated (8659512 -> a5e795c)

2021-03-03 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8659512 [build] Enable detailed Java compiler warnings (#9780) add a5e795c [pulsar-broker] Added support to f

[GitHub] [pulsar] codelipenghui merged pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-03-03 Thread GitBox
codelipenghui merged pull request #9677: URL: https://github.com/apache/pulsar/pull/9677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] codelipenghui commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-790189060 @murong00 Then change looks good to me, shall we need to control the force delete tenants or namespaces in the broker.conf? such as forceDeleteNamepaceAllowed, forceDeleteT

[GitHub] [pulsar] codelipenghui commented on pull request #9694: Support get topic applied policy for MaxUnackedMessagePerConsumers

2021-03-03 Thread GitBox
codelipenghui commented on pull request #9694: URL: https://github.com/apache/pulsar/pull/9694#issuecomment-790186483 @315157973 Could you please help resolve the conflicts? This is an automated message from the Apache Git Se

[pulsar] branch master updated: [build] Enable detailed Java compiler warnings (#9780)

2021-03-03 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8659512 [build] Enable detailed Java compiler

[GitHub] [pulsar] codelipenghui merged pull request #9780: [build] Enable detailed Java compiler warnings

2021-03-03 Thread GitBox
codelipenghui merged pull request #9780: URL: https://github.com/apache/pulsar/pull/9780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] codelipenghui commented on a change in pull request #9786: [Issue 9173] [Non Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-03-03 Thread GitBox
codelipenghui commented on a change in pull request #9786: URL: https://github.com/apache/pulsar/pull/9786#discussion_r586913062 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -18,14 +18,6 @@ */ package org.apache.pulsar.

[GitHub] [pulsar] codelipenghui commented on issue #9197: Partitioned Topics not able to create on all clusters for geo redundancy

2021-03-03 Thread GitBox
codelipenghui commented on issue #9197: URL: https://github.com/apache/pulsar/issues/9197#issuecomment-790180244 @dlsprague I see, I think the problem is the `allowAutoTopicCreation=false` and the partitions have not created in the second cluster. It's related to https://github.com/apache/

[GitHub] [pulsar] zymap commented on pull request #9781: Fix topic ownership is not checked when get topic policy (target branch-2.7)

2021-03-03 Thread GitBox
zymap commented on pull request #9781: URL: https://github.com/apache/pulsar/pull/9781#issuecomment-790171595 Do not rerun the test. I can reproduce the errors on local. This is an automated message from the Apache Git Servic

[GitHub] [pulsar-client-go] merlimat merged pull request #481: Update jwt-go version to v4

2021-03-03 Thread GitBox
merlimat merged pull request #481: URL: https://github.com/apache/pulsar-client-go/pull/481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[pulsar-client-go] branch master updated: Update jwt-go version to v4 (#481)

2021-03-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new aca43f6 Update jwt-go version to v4 (

[GitHub] [pulsar] merlimat commented on a change in pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
merlimat commented on a change in pull request #9787: URL: https://github.com/apache/pulsar/pull/9787#discussion_r586754132 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentOpenHashMap.java ## @@ -354,42 +354,33 @@ void clear() {

[GitHub] [pulsar] lhotari commented on pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
lhotari commented on pull request #9787: URL: https://github.com/apache/pulsar/pull/9787#issuecomment-790032044 Nice! Can't wait to try it out. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] lhotari commented on a change in pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
lhotari commented on a change in pull request #9787: URL: https://github.com/apache/pulsar/pull/9787#discussion_r586749878 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentOpenHashMap.java ## @@ -354,42 +354,33 @@ void clear() {

[GitHub] [pulsar] dlsprague commented on issue #9197: Partitioned Topics not able to create on all clusters for geo redundancy

2021-03-03 Thread GitBox
dlsprague commented on issue #9197: URL: https://github.com/apache/pulsar/issues/9197#issuecomment-790007889 HI.. thank you for the response. yes, we are planning to upgrade to 2.7.0, or actually I think maybe waiting for 2.7.1. Its in the planning and testing stage now. Also

[GitHub] [pulsar] merlimat commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
merlimat commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-790001743 @eolivelli @lhotari Created #9787 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] merlimat opened a new pull request #9787: Ensure read-lock is not continuously held on a section while iterating over concurrent maps

2021-03-03 Thread GitBox
merlimat opened a new pull request #9787: URL: https://github.com/apache/pulsar/pull/9787 ### Motivation As discussed in #9764 the fact that we're potentially holding a read-lock while scanning through a section of the map has several implications: 1. If the process function

[GitHub] [pulsar] lhotari commented on pull request #9780: [build] Enable detailed Java compiler warnings

2021-03-03 Thread GitBox
lhotari commented on pull request #9780: URL: https://github.com/apache/pulsar/pull/9780#issuecomment-789988741 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] mlyahmed commented on issue #9173: Create partitions for a partitioned topic even if topic auto-creation disabled

2021-03-03 Thread GitBox
mlyahmed commented on issue #9173: URL: https://github.com/apache/pulsar/issues/9173#issuecomment-789987918 Here is a suggestion This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] mlyahmed opened a new pull request #9786: [Issue 9173] [Non Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-03-03 Thread GitBox
mlyahmed opened a new pull request #9786: URL: https://github.com/apache/pulsar/pull/9786 Fixes #9173 Master Issue: #9173 ### Motivation Please see #9173 ### Modifications When the BrokerService is about to create a non-persistent topic it checks if it is a part

[GitHub] [pulsar-client-go] fanjeff opened a new pull request #481: Update jwt-go version to v4

2021-03-03 Thread GitBox
fanjeff opened a new pull request #481: URL: https://github.com/apache/pulsar-client-go/pull/481 jwt-go before 4.0.0-preview1 allows attackers to bypass intended access restrictions in situations with []string{} for m["aud"] (which is allowed by the specification). Because the type asserti

[GitHub] [pulsar] eolivelli commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
eolivelli commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789972001 @merlimat > @eolivelli Even if do a ZK blocking call (which we shouldn't), that doesn't necessarily mean that there will be a deadlock. It will only be the case if the

[GitHub] [pulsar] lhotari commented on pull request #9780: [build] Enable detailed Java compiler warnings

2021-03-03 Thread GitBox
lhotari commented on pull request #9780: URL: https://github.com/apache/pulsar/pull/9780#issuecomment-789967351 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] lhotari closed pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
lhotari closed pull request #9764: URL: https://github.com/apache/pulsar/pull/9764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] lhotari commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
lhotari commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789959546 > I have a WIP solution already. Need to look it a bit more to see if I'm missing anything and I'll create a PR. Ok great. I'm looking forward to that. I'll close this

[GitHub] [pulsar] merlimat commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
merlimat commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789958385 I have a WIP solution already. Need to look it a bit more to see if I'm missing anything and I'll create a PR.

[GitHub] [pulsar] lhotari commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
lhotari commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789956789 > To conclude, in my opinion the easiest/lower-risk/lower-overhead change here would be to switch the forEach() to do the stamped+read-lock combination for each entry, instead of

[GitHub] [pulsar-client-go] sloan-dog opened a new issue #480: Question Regarding Protobuf schema

2021-03-03 Thread GitBox
sloan-dog opened a new issue #480: URL: https://github.com/apache/pulsar-client-go/issues/480 Hi, I would like to utilize protobuf to define schema for a topic. It is not apparent in documentation the format the protobuf schema function takes, and after reviewing a go test s

[GitHub] [pulsar] lhotari commented on pull request #9673: [Testing] Improve LocalRunner to support .nar files that aren't on the classpath

2021-03-03 Thread GitBox
lhotari commented on pull request #9673: URL: https://github.com/apache/pulsar/pull/9673#issuecomment-789953405 /pulsar-bot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] merlimat commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
merlimat commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789936268 > It can lead to spurious inconsistencies during re-hashing time, Scratch that. it's actually possible to do it with the current concurrency level, no funky stuff.

[GitHub] [pulsar] merlimat commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
merlimat commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789930324 > It's not really a defensive copy of the entire map. The copy is done one section at a time. By defensive, I mean that we'd be taking a copy of the entire map (section

[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)

2021-03-03 Thread GitBox
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-789898332 I have merged with current master in order to bootstrap CI again. Thank you @sijie for taking a look Th

[GitHub] [pulsar] kyomster commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-03 Thread GitBox
kyomster commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-789876182 I too need this PR. please @sijie This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-03 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-789869881 @sijie @zymap rebased This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] lhotari commented on pull request #9673: [Testing] Improve LocalRunner to support .nar files that aren't on the classpath

2021-03-03 Thread GitBox
lhotari commented on pull request #9673: URL: https://github.com/apache/pulsar/pull/9673#issuecomment-789869578 /pulsarbot run-failure-check This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] mlyahmed commented on issue #9173: Create partitions for a partitioned topic even if topic auto-creation disabled

2021-03-03 Thread GitBox
mlyahmed commented on issue #9173: URL: https://github.com/apache/pulsar/issues/9173#issuecomment-789833502 @codelipenghui got that thanks ! This auto-creation must be only for partitions right? The current behavior must be kept for the non-partitioned topics. For example, if a new subsc

[GitHub] [pulsar] DonHaul commented on issue #9784: The partitioned topic startMessageId is illegal

2021-03-03 Thread GitBox
DonHaul commented on issue #9784: URL: https://github.com/apache/pulsar/issues/9784#issuecomment-789807600 Thanks :), will wait be waiting for the next release. Will be using non partitioned topics as a workaround for now. ---

[GitHub] [pulsar] DonHaul closed issue #9784: The partitioned topic startMessageId is illegal

2021-03-03 Thread GitBox
DonHaul closed issue #9784: URL: https://github.com/apache/pulsar/issues/9784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] lhotari commented on pull request #9780: [build] Enable detailed Java compiler warnings about unchecked and unsafe operations

2021-03-03 Thread GitBox
lhotari commented on pull request #9780: URL: https://github.com/apache/pulsar/pull/9780#issuecomment-789806877 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] codelipenghui commented on issue #9173: Create partitions for a partitioned topic even if topic auto-creation disabled

2021-03-03 Thread GitBox
codelipenghui commented on issue #9173: URL: https://github.com/apache/pulsar/issues/9173#issuecomment-789783373 @mlyahmed No, Pulsar does not store any metadata for the non-persistent topic. This is an automated message fro

[GitHub] [pulsar] codelipenghui commented on issue #9699: Key_Shared subcription not working correctly

2021-03-03 Thread GitBox
codelipenghui commented on issue #9699: URL: https://github.com/apache/pulsar/issues/9699#issuecomment-789781833 @ilpanich The producer enabled the batching by default. You can print the message ID that the consumer received to check if the message is a batch message. If it is a batch mess

[GitHub] [pulsar] codelipenghui commented on issue #9783: Pulsar Proxy HashedWheelTimer and Frame Exception

2021-03-03 Thread GitBox
codelipenghui commented on issue #9783: URL: https://github.com/apache/pulsar/issues/9783#issuecomment-789776802 Thanks @xuesongxs . Seems the problem is the proxy creates a Pulsar client for each connection since the proxy need to do the authentication by the client. Since each Pulsar cli

[GitHub] [pulsar] codelipenghui commented on issue #9370: Consumer with KEY_SHARED subscription is not working with encrypted topic

2021-03-03 Thread GitBox
codelipenghui commented on issue #9370: URL: https://github.com/apache/pulsar/issues/9370#issuecomment-789772317 Thanks and looking forward to your feedback. This is an automated message from the Apache Git Service. To respon

[GitHub] [pulsar] codelipenghui commented on issue #9784: The partitioned topic startMessageId is illegal

2021-03-03 Thread GitBox
codelipenghui commented on issue #9784: URL: https://github.com/apache/pulsar/issues/9784#issuecomment-789771089 currently, the partitioned reader only supports setting the start position to the earliest or latest. You can find some details at https://github.com/apache/pulsar/issues/9301 .

[GitHub] [pulsar] dlsprague commented on issue #9370: Consumer with KEY_SHARED subscription is not working with encrypted topic

2021-03-03 Thread GitBox
dlsprague commented on issue #9370: URL: https://github.com/apache/pulsar/issues/9370#issuecomment-789768126 HI Actually when this occurs there are no errors in the logs on either client or server side. just does not consume. We have moved topic to a 2.7.0 server to see if this will corr

[GitHub] [pulsar] codelipenghui commented on issue #9557: Batch message serialization ignores batch size

2021-03-03 Thread GitBox
codelipenghui commented on issue #9557: URL: https://github.com/apache/pulsar/issues/9557#issuecomment-789767440 @Lanayx The broker does not do deserialization and filter the messages from a batch, this is expected behavior. And yes, this issue should be fixed since the consumer does not p

[GitHub] [pulsar] eolivelli opened a new pull request #9785: Pulsar Client: allow to print GenericRecord contents

2021-03-03 Thread GitBox
eolivelli opened a new pull request #9785: URL: https://github.com/apache/pulsar/pull/9785 ### Motivation When you are dealing with structured data it would be pretty useful to have a tool that prints decoded records directly to the console. ### Modifications Add two new op

[GitHub] [pulsar] 315157973 commented on pull request #9781: Fix topic ownership is not checked when get topic policy (target branch-2.7)

2021-03-03 Thread GitBox
315157973 commented on pull request #9781: URL: https://github.com/apache/pulsar/pull/9781#issuecomment-789741788 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] lhotari commented on pull request #9673: [Testing] Improve LocalRunner to support .nar files that aren't on the classpath

2021-03-03 Thread GitBox
lhotari commented on pull request #9673: URL: https://github.com/apache/pulsar/pull/9673#issuecomment-789715972 /pulsarbot run-failure-check This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization

2021-03-03 Thread GitBox
lhotari commented on pull request #9746: URL: https://github.com/apache/pulsar/pull/9746#issuecomment-789682057 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] lhotari commented on pull request #9780: [build] Enable detailed Java compiler warnings about unchecked and unsafe operations

2021-03-03 Thread GitBox
lhotari commented on pull request #9780: URL: https://github.com/apache/pulsar/pull/9780#issuecomment-789675514 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] zymap commented on pull request #9781: Fix topic ownership is not checked when get topic policy (target branch-2.7)

2021-03-03 Thread GitBox
zymap commented on pull request #9781: URL: https://github.com/apache/pulsar/pull/9781#issuecomment-789672499 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Lanayx commented on issue #9557: Batch message serialization ignores batch size

2021-03-03 Thread GitBox
Lanayx commented on issue #9557: URL: https://github.com/apache/pulsar/issues/9557#issuecomment-789651440 @zymap Hi! This test works, but not because the seek logic isn't broken, but because seek message id is stored as startMessageId in consumer and extra messages are ignored on receive.

[GitHub] [pulsar] DonHaul opened a new issue #9784: The partitioned topic startMessageId is illegal

2021-03-03 Thread GitBox
DonHaul opened a new issue #9784: URL: https://github.com/apache/pulsar/issues/9784 **Describe the bug** A clear and concise description of what the bug is. When using a reader to read a single message from a partitioned topic the error The partitioned topic startMessageId is illega

[GitHub] [pulsar] Vanlightly commented on pull request #9764: [Common] Reduce duration of locks when processing items held in ConcurrentOpenHashMaps

2021-03-03 Thread GitBox
Vanlightly commented on pull request #9764: URL: https://github.com/apache/pulsar/pull/9764#issuecomment-789643539 I've not spent much time in the Pulsar codebase, so don't know much about the wider context. But if it helps, I could model this ConcurrentOpenHashMap in TLA+ and see if it ha

[GitHub] [pulsar] xuesongxs opened a new issue #9783: Pulsar Proxy HashedWheelTimer and Frame Exception

2021-03-03 Thread GitBox
xuesongxs opened a new issue #9783: URL: https://github.com/apache/pulsar/issues/9783 **Describe the bug** ![image](https://user-images.githubusercontent.com/54351417/109797111-fa653a80-7c53-11eb-8cad-804755a63464.png) ![image](https://user-images.githubusercontent.com/54351417/1

[GitHub] [pulsar] zymap commented on a change in pull request #9782: Add NPE check for PulsarService#getAdminClient

2021-03-03 Thread GitBox
zymap commented on a change in pull request #9782: URL: https://github.com/apache/pulsar/pull/9782#discussion_r586315712 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1166,7 +1166,13 @@ public synchronized PulsarAdmin getAdminClie

  1   2   >